songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PCA: Corrected one bug for cuboids (dimension 0 tag) 

removed a default tag
This commit is contained in:
Pierre Alliez 2008-01-21 21:53:21 +00:00
parent 11474e52d7
commit 013183aeef
4 changed files with 228 additions and 221 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Principal_component_analysis/include/CGAL/linear_least_squares_fitting_cuboids_3.h
View File

@ -166,6 +166,10 @@ linear_least_squares_fitting_3(InputIterator first,
points.push_back(t[1]); points.push_back(t[1]);
points.push_back(t[2]); points.push_back(t[2]);
points.push_back(t[3]); points.push_back(t[3]);
points.push_back(t[4]);
points.push_back(t[5]);
points.push_back(t[6]);
points.push_back(t[7]);
} }
// compute fitting plane // compute fitting plane
@ -307,6 +311,10 @@ linear_least_squares_fitting_3(InputIterator first,
points.push_back(t[1]); points.push_back(t[1]);
points.push_back(t[2]); points.push_back(t[2]);
points.push_back(t[3]); points.push_back(t[3]);
points.push_back(t[4]);
points.push_back(t[5]);
points.push_back(t[6]);
points.push_back(t[7]);
} }
// compute fitting line // compute fitting line

4
Principal_component_analysis/include/CGAL/linear_least_squares_fitting_points_3.h
View File

@ -43,7 +43,7 @@ linear_least_squares_fitting_3(InputIterator first,
typename K::Point_3& c, // centroid typename K::Point_3& c, // centroid
const typename K::Point_3*, // used for indirection const typename K::Point_3*, // used for indirection
const K& k, // kernel const K& k, // kernel
const CGAL::PCA_dimension_0_tag& tag = CGAL::PCA_dimension_0_tag()) const CGAL::PCA_dimension_0_tag& tag)
{ {
typedef typename K::FT FT; typedef typename K::FT FT;
typedef typename K::Point_3 Point; typedef typename K::Point_3 Point;
@ -77,7 +77,7 @@ linear_least_squares_fitting_3(InputIterator first,
typename K::Point_3& c, // centroid typename K::Point_3& c, // centroid
const typename K::Point_3*, // used for indirection const typename K::Point_3*, // used for indirection
const K& k, // kernel const K& k, // kernel
const CGAL::PCA_dimension_0_tag& tag = CGAL::PCA_dimension_0_tag) const CGAL::PCA_dimension_0_tag& tag)
{ {
typedef typename K::FT FT; typedef typename K::FT FT;
typedef typename K::Point_3 Point; typedef typename K::Point_3 Point;

1
Principal_component_analysis/test/Principal_component_analysis/linear_least_squares_fitting_cuboids_3.cpp
View File

@ -22,7 +22,6 @@ int main()
cuboids.push_back(Iso_cuboid(a,b)); cuboids.push_back(Iso_cuboid(a,b));
cuboids.push_back(Iso_cuboid(a,c)); cuboids.push_back(Iso_cuboid(a,c));
Kernel kernel;
Line line; Line line;
Plane plane; Plane plane;
Point centroid; Point centroid;