From ba8bc776b5c302b7d507dceae5c0ec0a90771872 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 3 Apr 2018 12:31:51 +0200 Subject: [PATCH 01/31] Fixed Default_property_map's get() --- Property_map/include/CGAL/property_map.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Property_map/include/CGAL/property_map.h b/Property_map/include/CGAL/property_map.h index e8612db429c..57a7b789c13 100644 --- a/Property_map/include/CGAL/property_map.h +++ b/Property_map/include/CGAL/property_map.h @@ -450,10 +450,10 @@ struct Default_property_map{ typedef boost::readable_property_map_tag category; Default_property_map(const ValueType& default_value = ValueType()) : default_value (default_value) { } - - /// Free function to use a get the value from an iterator using Input_iterator_property_map. - inline friend ValueType - get (const Default_property_map&, const key_type&){ return ValueType(); } + + /// Free function that returns `pm.default_value`. + inline friend value_type + get (const Default_property_map& pm, const key_type&){ return pm.default_value; } }; /// \ingroup PkgProperty_map From a12ecf4a43a1f71c218760b356362f30e078e857 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 3 Apr 2018 12:47:29 +0200 Subject: [PATCH 02/31] Extend Default_property_map to be writeable --- Property_map/include/CGAL/property_map.h | 25 ++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/Property_map/include/CGAL/property_map.h b/Property_map/include/CGAL/property_map.h index 57a7b789c13..b5dbfc75418 100644 --- a/Property_map/include/CGAL/property_map.h +++ b/Property_map/include/CGAL/property_map.h @@ -440,20 +440,29 @@ make_property_map(const std::vector& v) } /// \ingroup PkgProperty_map -/// Property map that only returns the default value type -/// \cgalModels `ReadablePropertyMap` -template -struct Default_property_map{ +/// Property map that returns a fixed value. +/// Note that this value is chosen when the map is constructed and cannot +/// be changed afterwards. Specifically, the free function `put()` does nothing. +/// +/// \cgalModels `ReadWritePropertyMap` +template +struct Default_property_map +{ const ValueType default_value; - - typedef typename InputIterator::value_type key_type; - typedef boost::readable_property_map_tag category; - Default_property_map(const ValueType& default_value = ValueType()) : default_value (default_value) { } + typedef KeyType key_type; + typedef ValueType value_type; + typedef boost::read_write_property_map_tag category; + + Default_property_map(const value_type& default_value = value_type()) : default_value (default_value) { } /// Free function that returns `pm.default_value`. inline friend value_type get (const Default_property_map& pm, const key_type&){ return pm.default_value; } + + /// Free function that does nothing. + inline friend void + put (const Default_property_map&, const key_type&, const value_type&) { } }; /// \ingroup PkgProperty_map From 288417a9ed7d1859cd9f6eba1e1e052ffc94046a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 3 Apr 2018 14:11:49 +0200 Subject: [PATCH 03/31] Renamed Default_property_map to Constant_property_map --- .../CGAL/Classification/Point_set_feature_generator.h | 10 +++++----- Property_map/include/CGAL/property_map.h | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Classification/include/CGAL/Classification/Point_set_feature_generator.h b/Classification/include/CGAL/Classification/Point_set_feature_generator.h index 04c476d6548..b74ef1d16f6 100644 --- a/Classification/include/CGAL/Classification/Point_set_feature_generator.h +++ b/Classification/include/CGAL/Classification/Point_set_feature_generator.h @@ -496,7 +496,7 @@ private: launch_feature_computation (new Feature_adder_verticality (this, normal_map, 0)); } - void generate_normal_based_features(const CGAL::Default_property_map&) + void generate_normal_based_features(const CGAL::Constant_property_map&) { generate_multiscale_feature_variant_0 (); } @@ -544,7 +544,7 @@ private: 2, 25.f * float(i), 12.5f)); } - void generate_color_based_features(const CGAL::Default_property_map&) + void generate_color_based_features(const CGAL::Constant_property_map&) { } @@ -581,7 +581,7 @@ private: launch_feature_computation (new Feature_adder_echo (this, echo_map, i)); } - void generate_echo_based_features(const CGAL::Default_property_map&) + void generate_echo_based_features(const CGAL::Constant_property_map&) { } @@ -615,10 +615,10 @@ private: } template - Default_property_map + Constant_property_map get_parameter (const Default&) { - return Default_property_map(); + return Constant_property_map(); } template diff --git a/Property_map/include/CGAL/property_map.h b/Property_map/include/CGAL/property_map.h index b5dbfc75418..6280b0c653f 100644 --- a/Property_map/include/CGAL/property_map.h +++ b/Property_map/include/CGAL/property_map.h @@ -446,7 +446,7 @@ make_property_map(const std::vector& v) /// /// \cgalModels `ReadWritePropertyMap` template -struct Default_property_map +struct Constant_property_map { const ValueType default_value; @@ -454,15 +454,15 @@ struct Default_property_map typedef ValueType value_type; typedef boost::read_write_property_map_tag category; - Default_property_map(const value_type& default_value = value_type()) : default_value (default_value) { } + Constant_property_map(const value_type& default_value = value_type()) : default_value (default_value) { } /// Free function that returns `pm.default_value`. inline friend value_type - get (const Default_property_map& pm, const key_type&){ return pm.default_value; } + get (const Constant_property_map& pm, const key_type&){ return pm.default_value; } /// Free function that does nothing. inline friend void - put (const Default_property_map&, const key_type&, const value_type&) { } + put (const Constant_property_map&, const key_type&, const value_type&) { } }; /// \ingroup PkgProperty_map From bcfb7afead5115415168fae5c5dac8dd40a06b94 Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Wed, 25 Apr 2018 15:32:36 +0200 Subject: [PATCH 04/31] Add an operator for a Ray_3 to ConstructProjectedpoint_3 --- .../include/CGAL/Cartesian/function_objects.h | 5 +++++ .../CGAL/Homogeneous/function_objects.h | 5 +++++ .../Concepts/FunctionObjectConcepts.h | 6 +++++ .../include/CGAL/Kernel/function_objects.h | 22 +++++++++++++++++++ 4 files changed, 38 insertions(+) diff --git a/Cartesian_kernel/include/CGAL/Cartesian/function_objects.h b/Cartesian_kernel/include/CGAL/Cartesian/function_objects.h index 600fe1af0d5..a53b3fe55a8 100644 --- a/Cartesian_kernel/include/CGAL/Cartesian/function_objects.h +++ b/Cartesian_kernel/include/CGAL/Cartesian/function_objects.h @@ -3181,6 +3181,7 @@ namespace CartesianKernelFunctors { typedef typename K::Line_3 Line_3; typedef typename K::Triangle_3 Triangle_3; typedef typename K::Segment_3 Segment_3; + typedef typename K::Ray_3 Ray_3; typedef typename K::FT FT; public: typedef Point_3 result_type; @@ -3215,6 +3216,10 @@ namespace CartesianKernelFunctors { Point_3 operator()( const Segment_3& s, const Point_3& p ) const { return CommonKernelFunctors::Construct_projected_point_3()(p,s,K()); } + + Point_3 + operator()( const Ray_3& r, const Point_3& p ) const + { return CommonKernelFunctors::Construct_projected_point_3()(p,r,K()); } }; template diff --git a/Homogeneous_kernel/include/CGAL/Homogeneous/function_objects.h b/Homogeneous_kernel/include/CGAL/Homogeneous/function_objects.h index 080bd4929ea..40c2e3b2f65 100644 --- a/Homogeneous_kernel/include/CGAL/Homogeneous/function_objects.h +++ b/Homogeneous_kernel/include/CGAL/Homogeneous/function_objects.h @@ -3315,6 +3315,7 @@ namespace HomogeneousKernelFunctors { typedef typename K::Vector_3 Vector_3; typedef typename K::Triangle_3 Triangle_3; typedef typename K::Segment_3 Segment_3; + typedef typename K::Ray_3 Ray_3; public: typedef Point_3 result_type; @@ -3351,6 +3352,10 @@ namespace HomogeneousKernelFunctors { Point_3 operator()( const Segment_3& s, const Point_3& p ) const { return CommonKernelFunctors::Construct_projected_point_3()(p,s,K()); } + + Point_3 + operator()( const Ray_3& r, const Point_3& p ) const + { return CommonKernelFunctors::Construct_projected_point_3()(p,r,K()); } }; template diff --git a/Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h b/Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h index 2cb3db219c7..ef058713356 100644 --- a/Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h +++ b/Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h @@ -5976,6 +5976,12 @@ public: */ Kernel::Point_3 operator()(const Kernel::Segment_3& s, const Kernel::Point_3& p); + + /*! + returns the point of `r` that is the closest to `p`. + */ + Kernel::Point_3 operator()(const Kernel::Ray_3& r, + const Kernel::Point_3& p); /*! returns the point of `t` that is the closest to `p`. diff --git a/Kernel_23/include/CGAL/Kernel/function_objects.h b/Kernel_23/include/CGAL/Kernel/function_objects.h index 0ff0de5764b..ead44b48ea9 100644 --- a/Kernel_23/include/CGAL/Kernel/function_objects.h +++ b/Kernel_23/include/CGAL/Kernel/function_objects.h @@ -2881,6 +2881,28 @@ namespace CommonKernelFunctors { return closest_point_on_segment; } + typename K::Point_3 + operator()(const typename K::Point_3& query, + const typename K::Ray_3& ray, + const K& k) + { + typedef typename K::Point_3 Point_3; + + typename K::Construct_projected_point_3 projection = + k.construct_projected_point_3_object(); + + + + // Project query on segment supporting line + const Point_3 closest_point = projection(ray.supporting_line(), query); + + if ( ray.to_vector() * (closest_point-ray.source()) < 0) + closest_point = ray.source(); + + //returns the constructed point + return closest_point; + } + // code for operator for plane and point is defined in // CGAL/Cartesian/function_objects.h and CGAL/Homogeneous/function_objects.h }; From b20d0e090834d8d0a6b9a12917fd65b4fd973e49 Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Thu, 26 Apr 2018 10:02:43 +0200 Subject: [PATCH 05/31] Optimization --- .../include/CGAL/Kernel/function_objects.h | 41 ++++++------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/Kernel_23/include/CGAL/Kernel/function_objects.h b/Kernel_23/include/CGAL/Kernel/function_objects.h index ead44b48ea9..0b8950f863f 100644 --- a/Kernel_23/include/CGAL/Kernel/function_objects.h +++ b/Kernel_23/include/CGAL/Kernel/function_objects.h @@ -2855,10 +2855,7 @@ namespace CommonKernelFunctors { const typename K::Segment_3& segment, const K& k) { - typedef typename K::Point_3 Point_3; - typename K::Construct_projected_point_3 projection = - k.construct_projected_point_3_object(); typename K::Is_degenerate_3 is_degenerate = k.is_degenerate_3_object(); typename K::Construct_vertex_3 vertex = @@ -2867,18 +2864,13 @@ namespace CommonKernelFunctors { if(is_degenerate(segment)) return vertex(segment, 0); - // Project query on segment supporting line - const Point_3 proj = projection(segment.supporting_line(), query); - - Point_3 closest_point_on_segment; - bool inside = is_inside_segment_3(proj,segment,closest_point_on_segment,k); - + //bool inside = is_inside_segment_3(proj,segment,closest_point_on_segment,k); + if(segment.to_vector() * (query-segment.source()) < 0) + return segment.source(); + if(segment.to_vector() * (query-segment.target()) > 0) + return segment.target(); // If proj is inside segment, returns it - if ( inside ) - return proj; - - // Else returns the constructed point - return closest_point_on_segment; + return k.construct_projected_point_3_object()(segment.supporting_line(), query); } typename K::Point_3 @@ -2886,21 +2878,12 @@ namespace CommonKernelFunctors { const typename K::Ray_3& ray, const K& k) { - typedef typename K::Point_3 Point_3; - - typename K::Construct_projected_point_3 projection = - k.construct_projected_point_3_object(); - - - - // Project query on segment supporting line - const Point_3 closest_point = projection(ray.supporting_line(), query); - - if ( ray.to_vector() * (closest_point-ray.source()) < 0) - closest_point = ray.source(); - - //returns the constructed point - return closest_point; + if ( ray.to_vector() * (query-ray.source()) < 0) + return ray.source(); + else + { + return k.construct_projected_point_3_object()(ray.supporting_line(), query); + } } // code for operator for plane and point is defined in From 864e8ef27e830949d1401ad5f7d2c681b79e308a Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Thu, 26 Apr 2018 10:16:12 +0200 Subject: [PATCH 06/31] update doc in AABB_traits --- AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h b/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h index a579453e9f2..9afcfd566ce 100644 --- a/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h +++ b/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h @@ -66,7 +66,7 @@ typedef unspecified_type Construct_sphere_3; /*! A functor object to compute the point on a geometric primitive which is closest from a query. Provides the operator: -`Point_3 operator()(const Type_2& type_2, const Point_3& p);` where `Type_2` is any type among `Segment_3` and `Triangle_3`. The operator returns the point on `type_2` which is closest to `p`. +`Point_3 operator()(const Type_2& type_2, const Point_3& p);` where `Type_2` is any type among `Segment_3`, `Ray_3` and `Triangle_3`. The operator returns the point on `type_2` which is closest to `p`. */ typedef unspecified_type Construct_projected_point_3; From a8bd3605a7e7a6206720fedf8bf43927e4754b6f Mon Sep 17 00:00:00 2001 From: Laurent Rineau Date: Thu, 26 Apr 2018 16:16:10 +0200 Subject: [PATCH 07/31] A fix for MSVC 2017 15.7 with /permissive- MSVC is probably right that it was not a valid C++ code: the previous version called a static member function of the enclosing class, without qualification, and that static member function was defined *after*. --- AABB_tree/include/CGAL/AABB_traits.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/AABB_tree/include/CGAL/AABB_traits.h b/AABB_tree/include/CGAL/AABB_traits.h index 638153dc6c1..4b962f14658 100644 --- a/AABB_tree/include/CGAL/AABB_traits.h +++ b/AABB_tree/include/CGAL/AABB_traits.h @@ -291,7 +291,8 @@ public: */ class Sort_primitives { - const AABB_traits& m_traits; + typedef AABB_traits Traits; + const Traits& m_traits; public: Sort_primitives(const AABB_traits& traits) : m_traits(traits) {} @@ -302,7 +303,7 @@ public: const typename AT::Bounding_box& bbox) const { PrimitiveIterator middle = first + (beyond - first)/2; - switch(longest_axis(bbox)) + switch(Traits::longest_axis(bbox)) { case AT::CGAL_AXIS_X: // sort along x std::nth_element(first, middle, beyond, boost::bind(less_x,_1,_2,m_traits)); From 67ca3f9dcb47610b568fde8f0b675aadaf560975 Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Fri, 27 Apr 2018 09:18:48 +0200 Subject: [PATCH 08/31] fixes --- AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h | 3 ++- Kernel_23/include/CGAL/Kernel/function_objects.h | 7 +++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h b/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h index 9afcfd566ce..ec017f1efe3 100644 --- a/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h +++ b/AABB_tree/doc/AABB_tree/Concepts/AABBGeomTraits.h @@ -66,7 +66,8 @@ typedef unspecified_type Construct_sphere_3; /*! A functor object to compute the point on a geometric primitive which is closest from a query. Provides the operator: -`Point_3 operator()(const Type_2& type_2, const Point_3& p);` where `Type_2` is any type among `Segment_3`, `Ray_3` and `Triangle_3`. The operator returns the point on `type_2` which is closest to `p`. +`Point_3 operator()(const Type_2& type_2, const Point_3& p);` where `Type_2` can be any of the following types : `Segment_3`, `Ray_3`, or `Triangle_3`. +The operator returns the point on `type_2` which is closest to `p`. */ typedef unspecified_type Construct_projected_point_3; diff --git a/Kernel_23/include/CGAL/Kernel/function_objects.h b/Kernel_23/include/CGAL/Kernel/function_objects.h index 0b8950f863f..ec0681875e5 100644 --- a/Kernel_23/include/CGAL/Kernel/function_objects.h +++ b/Kernel_23/include/CGAL/Kernel/function_objects.h @@ -2864,10 +2864,9 @@ namespace CommonKernelFunctors { if(is_degenerate(segment)) return vertex(segment, 0); - //bool inside = is_inside_segment_3(proj,segment,closest_point_on_segment,k); - if(segment.to_vector() * (query-segment.source()) < 0) + if(segment.to_vector() * (query-segment.source()) <= 0) return segment.source(); - if(segment.to_vector() * (query-segment.target()) > 0) + if(segment.to_vector() * (query-segment.target()) >= 0) return segment.target(); // If proj is inside segment, returns it return k.construct_projected_point_3_object()(segment.supporting_line(), query); @@ -2878,7 +2877,7 @@ namespace CommonKernelFunctors { const typename K::Ray_3& ray, const K& k) { - if ( ray.to_vector() * (query-ray.source()) < 0) + if ( ray.to_vector() * (query-ray.source()) <= 0) return ray.source(); else { From d3b425281db8846a2a45fae63da3839d3eb72ea2 Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Fri, 27 Apr 2018 10:24:37 +0200 Subject: [PATCH 09/31] Add test for projections --- .../Kernel_23/include/CGAL/_test_fct_constructions_3.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Kernel_23/test/Kernel_23/include/CGAL/_test_fct_constructions_3.h b/Kernel_23/test/Kernel_23/include/CGAL/_test_fct_constructions_3.h index 2c3ff790b01..72326c520a7 100644 --- a/Kernel_23/test/Kernel_23/include/CGAL/_test_fct_constructions_3.h +++ b/Kernel_23/test/Kernel_23/include/CGAL/_test_fct_constructions_3.h @@ -26,12 +26,13 @@ template bool -_test_fct_constructions_3(const R&) +_test_fct_constructions_3(const R& r) { typedef typename R::RT RT; typedef typename R::Point_3 Point; typedef typename R::Weighted_point_3 Weighted_point; typedef typename R::Segment_3 Segment; + typedef typename R::Ray_3 Ray; typedef typename R::Plane_3 Plane; typedef typename R::Vector_3 Vector; typedef typename R::Triangle_3 Triangle; @@ -129,6 +130,12 @@ _test_fct_constructions_3(const R&) assert( CGAL::weighted_circumcenter( wp000_b, wp100_b, wp010_b) == wp000_b); assert( CGAL::weighted_circumcenter( wp000_b, wp100_b, wp010_b, wp001_b) == wp000_b); + // projected point + Ray ray(Point(0,0,0), Point (1,1,0)); + Segment s(Point(0,0,0), Point (1,1,0)); + assert( r.construct_projected_point_3_object()(ray, Point(-1,0,0)) == Point(0,0,0)); + assert( r.construct_projected_point_3_object()(s, Point(-1,0,0)) == Point(0,0,0)); + assert( r.construct_projected_point_3_object()(s, Point(2,0,0)) == Point(1,1,0)); return true; } From d2b89df177548185779147b9d446b3f03e245d42 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 2 May 2018 15:14:46 +0100 Subject: [PATCH 10/31] More Traits:: --- AABB_tree/include/CGAL/AABB_traits.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/AABB_tree/include/CGAL/AABB_traits.h b/AABB_tree/include/CGAL/AABB_traits.h index 4b962f14658..8cbbd4ebdf3 100644 --- a/AABB_tree/include/CGAL/AABB_traits.h +++ b/AABB_tree/include/CGAL/AABB_traits.h @@ -306,13 +306,13 @@ public: switch(Traits::longest_axis(bbox)) { case AT::CGAL_AXIS_X: // sort along x - std::nth_element(first, middle, beyond, boost::bind(less_x,_1,_2,m_traits)); + std::nth_element(first, middle, beyond, boost::bind(Traits::less_x,_1,_2,m_traits)); break; case AT::CGAL_AXIS_Y: // sort along y - std::nth_element(first, middle, beyond, boost::bind(less_y,_1,_2,m_traits)); + std::nth_element(first, middle, beyond, boost::bind(Traits::less_y,_1,_2,m_traits)); break; case AT::CGAL_AXIS_Z: // sort along z - std::nth_element(first, middle, beyond, boost::bind(less_z,_1,_2,m_traits)); + std::nth_element(first, middle, beyond, boost::bind(Traits::less_z,_1,_2,m_traits)); break; default: CGAL_error(); From 991f3847e824f5958bc07de8b4e11b48266e214f Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Sat, 24 Mar 2018 16:22:01 +0100 Subject: [PATCH 11/31] Do not include graph_traits_Polyhedron.h, properties_polyhedron.h and Polyhedron_iostream.h --- AABB_tree/test/AABB_tree/AABB_test_util.h | 2 +- AABB_tree/test/AABB_tree/aabb_any_all_benchmark.cpp | 1 - AABB_tree/test/AABB_tree/aabb_correctness_triangle_test.cpp | 1 - AABB_tree/test/AABB_tree/aabb_distance_edge_test.cpp | 1 - .../test/AABB_tree/aabb_distance_triangle_hint_test.cpp | 1 - AABB_tree/test/AABB_tree/aabb_distance_triangle_test.cpp | 1 - AABB_tree/test/AABB_tree/aabb_intersection_triangle_test.cpp | 1 - .../AABB_tree/aabb_naive_vs_tree_distance_segment_test.cpp | 1 - .../AABB_tree/aabb_naive_vs_tree_distance_triangle_test.cpp | 1 - .../test/AABB_tree/aabb_naive_vs_tree_triangle_test.cpp | 1 - AABB_tree/test/AABB_tree/aabb_test_ray_intersection.cpp | 1 - BGL/examples/BGL_LCC/copy_lcc.cpp | 2 -- BGL/examples/BGL_LCC/transform_iterator_lcc.cpp | 1 - BGL/test/BGL/borders.cpp | 2 -- BGL/test/BGL/graph_concept_Dual.cpp | 2 +- BGL/test/BGL/graph_concept_Gwdwg_Surface_mesh.cpp | 3 +-- BGL/test/BGL/graph_concept_Polyhedron_3.cpp | 2 +- BGL/test/BGL/graph_concept_Seam_mesh_Surface_mesh.cpp | 3 +-- BGL/test/BGL/graph_concept_Surface_mesh.cpp | 3 +-- BGL/test/BGL/test_Manifold_face_removal.cpp | 1 - BGL/test/BGL/test_bgl_read_write.cpp | 3 +-- BGL/test/BGL/test_circulator.cpp | 2 -- .../test/Convex_hull_3/test_halfspace_intersections.cpp | 2 +- .../test/Generalized_map/Generalized_map_2_test.h | 2 -- Generator/test/Generator/generic_random_test.cpp | 1 - Hash_map/test/Hash_map/Hash.cpp | 1 - .../test/Intersections_3/test_intersections_3.cpp | 2 +- Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp | 3 --- Mesh_3/test/Mesh_3/test_c3t3.cpp | 2 +- Nef_3/examples/Nef_3/handling_double_coordinates.cpp | 1 - Nef_3/examples/Nef_3/interface_polyhedron.cpp | 1 - Nef_3/examples/Nef_3/offIO.cpp | 1 - Nef_3/test/Nef_3/nef_union_error_llvm.cpp | 1 - .../poisson_reconstruction_example.cpp | 1 - .../poisson_reconstruction_function.cpp | 1 - .../test/Polygon_mesh_processing/fairing_test.cpp | 2 -- .../Polygon_mesh_processing/orient_polygon_soup_test.cpp | 2 -- .../point_inside_polyhedron_boundary_test.cpp | 2 -- .../Polygon_mesh_processing/polygon_mesh_slicer_test.cpp | 3 --- .../Polygon_mesh_processing/surface_intersection_sm_poly.cpp | 2 -- .../Polygon_mesh_processing/test_corefinement_bool_op.cpp | 1 - .../test/Polygon_mesh_processing/test_detect_features.cpp | 2 ++ .../test_is_polygon_soup_a_polygon_mesh.cpp | 1 - .../Polygon_mesh_processing/test_pmp_remove_border_edge.cpp | 2 -- .../test/Polygon_mesh_processing/test_stitching.cpp | 2 -- .../test/Polygon_mesh_processing/triangulate_faces_test.cpp | 1 - .../triangulate_hole_Polyhedron_3_no_delaunay_test.cpp | 5 ----- .../triangulate_hole_Polyhedron_3_test.cpp | 5 ----- .../triangulate_hole_polyline_test.cpp | 3 --- Polyhedron/examples/Polyhedron/polyhedron_prog_cut_cube.cpp | 1 - Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv.cpp | 1 - .../Polyhedron/polyhedron_prog_subdiv_with_boundary.cpp | 1 - .../examples/Polyhedron/polyhedron_self_intersection.cpp | 1 - .../test/Polyhedron/bug_polyhedron_incremental_builder_3.cpp | 1 - Polyhedron_IO/examples/Polyhedron_IO/off2stl.cpp | 1 - Polyhedron_IO/examples/Polyhedron_IO/polyhedron2vrml.cpp | 1 - Polyhedron_IO/examples/Polyhedron_IO/polyhedron_copy.cpp | 1 - Polyhedron_IO/test/Polyhedron_IO/test_polyhedron_io.cpp | 1 - Ridges_3/examples/Ridges_3/PolyhedralSurf.h | 3 --- Ridges_3/test/Ridges_3/PolyhedralSurf.h | 3 --- Skin_surface_3/test/Skin_surface_3/degenerate_test.cpp | 1 - Skin_surface_3/test/Skin_surface_3/degenerate_test_exact.cpp | 1 - .../Surface_mesh_deformation/Cactus_deformation_session.cpp | 1 - .../Surface_mesh_deformation/Cactus_performance_test.cpp | 1 - .../Surface_mesh_deformation_test_commons.h | 3 --- .../test/Surface_mesh_deformation/Symmetry_test.cpp | 1 - .../Surface_mesh_segmentation/Fast_sdf_calculation_test.cpp | 3 +-- .../test/Surface_mesh_segmentation/Filters_test.cpp | 3 +-- .../Surface_mesh_segmentation/mesh_segmentation_test.cpp | 3 +-- .../mesh_segmentation_test_using_boost.cpp | 3 +-- .../test_compute_sdf_values_and_segment_exact_rational.cpp | 3 +-- .../Surface_mesh_shortest_path_test_1.cpp | 2 -- .../Surface_mesh_shortest_path_test_2.cpp | 3 --- .../Surface_mesh_shortest_path_test_3.cpp | 2 -- .../Surface_mesh_shortest_path_test_4.cpp | 2 -- .../Surface_mesh_shortest_path_test_5.cpp | 2 -- .../Surface_mesh_shortest_path_traits_test.cpp | 2 -- .../test/Surface_mesh_shortest_path/TestMesh.cpp | 2 -- .../edge_collapse_bounded_normal_change.cpp | 2 -- .../test/Surface_mesh_simplification/basics.h | 2 -- .../Surface_mesh_simplification/edge_collapse_topology.cpp | 3 --- .../test/Surface_mesh_skeletonization/MCF_Skeleton_test.cpp | 2 -- .../skeleton_connectivity_test.cpp | 2 -- 83 files changed, 17 insertions(+), 135 deletions(-) diff --git a/AABB_tree/test/AABB_tree/AABB_test_util.h b/AABB_tree/test/AABB_tree/AABB_test_util.h index 55eeb4d84c8..bd5443a8548 100644 --- a/AABB_tree/test/AABB_tree/AABB_test_util.h +++ b/AABB_tree/test/AABB_tree/AABB_test_util.h @@ -29,7 +29,7 @@ #include #include -#include +#include #include diff --git a/AABB_tree/test/AABB_tree/aabb_any_all_benchmark.cpp b/AABB_tree/test/AABB_tree/aabb_any_all_benchmark.cpp index 70626442ac3..394bce109b5 100644 --- a/AABB_tree/test/AABB_tree/aabb_any_all_benchmark.cpp +++ b/AABB_tree/test/AABB_tree/aabb_any_all_benchmark.cpp @@ -15,7 +15,6 @@ #include #include -#include #include diff --git a/AABB_tree/test/AABB_tree/aabb_correctness_triangle_test.cpp b/AABB_tree/test/AABB_tree/aabb_correctness_triangle_test.cpp index 556a6f81bdd..8d511bea090 100644 --- a/AABB_tree/test/AABB_tree/aabb_correctness_triangle_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_correctness_triangle_test.cpp @@ -32,7 +32,6 @@ #include #include -#include #include #include diff --git a/AABB_tree/test/AABB_tree/aabb_distance_edge_test.cpp b/AABB_tree/test/AABB_tree/aabb_distance_edge_test.cpp index 3da5b2fa1b7..5c3ba4ca6e1 100644 --- a/AABB_tree/test/AABB_tree/aabb_distance_edge_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_distance_edge_test.cpp @@ -33,7 +33,6 @@ #include #include -#include #include diff --git a/AABB_tree/test/AABB_tree/aabb_distance_triangle_hint_test.cpp b/AABB_tree/test/AABB_tree/aabb_distance_triangle_hint_test.cpp index 0e248bf8b4e..2c8e715276a 100644 --- a/AABB_tree/test/AABB_tree/aabb_distance_triangle_hint_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_distance_triangle_hint_test.cpp @@ -33,7 +33,6 @@ #include #include -#include #include diff --git a/AABB_tree/test/AABB_tree/aabb_distance_triangle_test.cpp b/AABB_tree/test/AABB_tree/aabb_distance_triangle_test.cpp index 6dfe77e2594..ff1e2775200 100644 --- a/AABB_tree/test/AABB_tree/aabb_distance_triangle_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_distance_triangle_test.cpp @@ -29,7 +29,6 @@ #include #include -#include #include #include "AABB_test_util.h" diff --git a/AABB_tree/test/AABB_tree/aabb_intersection_triangle_test.cpp b/AABB_tree/test/AABB_tree/aabb_intersection_triangle_test.cpp index 30121277365..3cdf2b07f8e 100644 --- a/AABB_tree/test/AABB_tree/aabb_intersection_triangle_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_intersection_triangle_test.cpp @@ -32,7 +32,6 @@ #include #include -#include #include #include diff --git a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_segment_test.cpp b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_segment_test.cpp index 85a7a03ad41..acdfe0d2695 100644 --- a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_segment_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_segment_test.cpp @@ -33,7 +33,6 @@ #include #include -#include #include #include diff --git a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_triangle_test.cpp b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_triangle_test.cpp index 803f7397b50..04f6bbfbb8c 100644 --- a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_triangle_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_distance_triangle_test.cpp @@ -35,7 +35,6 @@ #include #include -#include #include #include diff --git a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_triangle_test.cpp b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_triangle_test.cpp index 22340369dc9..0035f0b5259 100644 --- a/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_triangle_test.cpp +++ b/AABB_tree/test/AABB_tree/aabb_naive_vs_tree_triangle_test.cpp @@ -34,7 +34,6 @@ #include #include -#include #include #include diff --git a/AABB_tree/test/AABB_tree/aabb_test_ray_intersection.cpp b/AABB_tree/test/AABB_tree/aabb_test_ray_intersection.cpp index 90f6902f679..549f925fb9e 100644 --- a/AABB_tree/test/AABB_tree/aabb_test_ray_intersection.cpp +++ b/AABB_tree/test/AABB_tree/aabb_test_ray_intersection.cpp @@ -12,7 +12,6 @@ #include #include -#include #include #include #include diff --git a/BGL/examples/BGL_LCC/copy_lcc.cpp b/BGL/examples/BGL_LCC/copy_lcc.cpp index c2ec115e12d..0def9a59b53 100644 --- a/BGL/examples/BGL_LCC/copy_lcc.cpp +++ b/BGL/examples/BGL_LCC/copy_lcc.cpp @@ -2,8 +2,6 @@ #include #include -#include -#include #include diff --git a/BGL/examples/BGL_LCC/transform_iterator_lcc.cpp b/BGL/examples/BGL_LCC/transform_iterator_lcc.cpp index 1268d4d9d77..40f1f884fee 100644 --- a/BGL/examples/BGL_LCC/transform_iterator_lcc.cpp +++ b/BGL/examples/BGL_LCC/transform_iterator_lcc.cpp @@ -1,5 +1,4 @@ #include -#include #include #include #include diff --git a/BGL/test/BGL/borders.cpp b/BGL/test/BGL/borders.cpp index e2c848718f9..4df20313137 100644 --- a/BGL/test/BGL/borders.cpp +++ b/BGL/test/BGL/borders.cpp @@ -2,8 +2,6 @@ #include #include -#include -#include #include #include #include diff --git a/BGL/test/BGL/graph_concept_Dual.cpp b/BGL/test/BGL/graph_concept_Dual.cpp index fc01a31ecae..6c29ab3fd57 100644 --- a/BGL/test/BGL/graph_concept_Dual.cpp +++ b/BGL/test/BGL/graph_concept_Dual.cpp @@ -1,5 +1,5 @@ #include -#include +#include #include #include diff --git a/BGL/test/BGL/graph_concept_Gwdwg_Surface_mesh.cpp b/BGL/test/BGL/graph_concept_Gwdwg_Surface_mesh.cpp index 02a5b6cf1e7..3e8c442a57e 100644 --- a/BGL/test/BGL/graph_concept_Gwdwg_Surface_mesh.cpp +++ b/BGL/test/BGL/graph_concept_Gwdwg_Surface_mesh.cpp @@ -1,5 +1,4 @@ -#include -#include +#include #include #include diff --git a/BGL/test/BGL/graph_concept_Polyhedron_3.cpp b/BGL/test/BGL/graph_concept_Polyhedron_3.cpp index 00b9bd6103d..8a0d04458b1 100644 --- a/BGL/test/BGL/graph_concept_Polyhedron_3.cpp +++ b/BGL/test/BGL/graph_concept_Polyhedron_3.cpp @@ -1,5 +1,5 @@ #include -#include +#include #include #include diff --git a/BGL/test/BGL/graph_concept_Seam_mesh_Surface_mesh.cpp b/BGL/test/BGL/graph_concept_Seam_mesh_Surface_mesh.cpp index 459b0709e92..222b683cd5f 100644 --- a/BGL/test/BGL/graph_concept_Seam_mesh_Surface_mesh.cpp +++ b/BGL/test/BGL/graph_concept_Seam_mesh_Surface_mesh.cpp @@ -1,5 +1,4 @@ -#include -#include +#include #include #include diff --git a/BGL/test/BGL/graph_concept_Surface_mesh.cpp b/BGL/test/BGL/graph_concept_Surface_mesh.cpp index dfeef4b03b6..1466fab4634 100644 --- a/BGL/test/BGL/graph_concept_Surface_mesh.cpp +++ b/BGL/test/BGL/graph_concept_Surface_mesh.cpp @@ -1,5 +1,4 @@ -#include -#include +#include #include #include diff --git a/BGL/test/BGL/test_Manifold_face_removal.cpp b/BGL/test/BGL/test_Manifold_face_removal.cpp index adc6f3bbe49..454a0d94ac5 100644 --- a/BGL/test/BGL/test_Manifold_face_removal.cpp +++ b/BGL/test/BGL/test_Manifold_face_removal.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include diff --git a/BGL/test/BGL/test_bgl_read_write.cpp b/BGL/test/BGL/test_bgl_read_write.cpp index bbbb1c4dbb7..894b772a610 100644 --- a/BGL/test/BGL/test_bgl_read_write.cpp +++ b/BGL/test/BGL/test_bgl_read_write.cpp @@ -1,10 +1,9 @@ #include #include -#include #include -#include +#include #include #include diff --git a/BGL/test/BGL/test_circulator.cpp b/BGL/test/BGL/test_circulator.cpp index ce2b1a7fb8e..8cd8ac1e6ec 100644 --- a/BGL/test/BGL/test_circulator.cpp +++ b/BGL/test/BGL/test_circulator.cpp @@ -1,7 +1,5 @@ #include #include -#include -#include #include #include diff --git a/Convex_hull_3/test/Convex_hull_3/test_halfspace_intersections.cpp b/Convex_hull_3/test/Convex_hull_3/test_halfspace_intersections.cpp index 7e0e00e9345..385236066d9 100644 --- a/Convex_hull_3/test/Convex_hull_3/test_halfspace_intersections.cpp +++ b/Convex_hull_3/test/Convex_hull_3/test_halfspace_intersections.cpp @@ -5,7 +5,7 @@ #include #include -#include +#include #include diff --git a/Generalized_map/test/Generalized_map/Generalized_map_2_test.h b/Generalized_map/test/Generalized_map/Generalized_map_2_test.h index ff1ae0576f0..15274a323fa 100644 --- a/Generalized_map/test/Generalized_map/Generalized_map_2_test.h +++ b/Generalized_map/test/Generalized_map/Generalized_map_2_test.h @@ -24,9 +24,7 @@ #include #include -#include #include -#include using namespace std; diff --git a/Generator/test/Generator/generic_random_test.cpp b/Generator/test/Generator/generic_random_test.cpp index d1c79fd0197..152071b8c44 100644 --- a/Generator/test/Generator/generic_random_test.cpp +++ b/Generator/test/Generator/generic_random_test.cpp @@ -18,7 +18,6 @@ #include #include -#include #include #include diff --git a/Hash_map/test/Hash_map/Hash.cpp b/Hash_map/test/Hash_map/Hash.cpp index fd558a42659..77e2c5c3b2f 100644 --- a/Hash_map/test/Hash_map/Hash.cpp +++ b/Hash_map/test/Hash_map/Hash.cpp @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include diff --git a/Intersections_3/test/Intersections_3/test_intersections_3.cpp b/Intersections_3/test/Intersections_3/test_intersections_3.cpp index 1390d6a407b..4a4ec69e0bf 100644 --- a/Intersections_3/test/Intersections_3/test_intersections_3.cpp +++ b/Intersections_3/test/Intersections_3/test_intersections_3.cpp @@ -9,7 +9,7 @@ #include #include -#include +#include #include #include diff --git a/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp b/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp index 9c5a5d1ae50..dfead0ab3b4 100644 --- a/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp +++ b/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp @@ -11,9 +11,6 @@ #include #include -// IO -#include - // Ouput #include diff --git a/Mesh_3/test/Mesh_3/test_c3t3.cpp b/Mesh_3/test/Mesh_3/test_c3t3.cpp index 1c296cbb970..83eae437387 100644 --- a/Mesh_3/test/Mesh_3/test_c3t3.cpp +++ b/Mesh_3/test/Mesh_3/test_c3t3.cpp @@ -32,7 +32,7 @@ // IO #include #include -#include +#include #include #include diff --git a/Nef_3/examples/Nef_3/handling_double_coordinates.cpp b/Nef_3/examples/Nef_3/handling_double_coordinates.cpp index 7f194599b50..9a570ef0599 100644 --- a/Nef_3/examples/Nef_3/handling_double_coordinates.cpp +++ b/Nef_3/examples/Nef_3/handling_double_coordinates.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include diff --git a/Nef_3/examples/Nef_3/interface_polyhedron.cpp b/Nef_3/examples/Nef_3/interface_polyhedron.cpp index ab6b36ca7a6..6cd007b3a0b 100644 --- a/Nef_3/examples/Nef_3/interface_polyhedron.cpp +++ b/Nef_3/examples/Nef_3/interface_polyhedron.cpp @@ -1,7 +1,6 @@ #include #include #include -#include #include #include #include diff --git a/Nef_3/examples/Nef_3/offIO.cpp b/Nef_3/examples/Nef_3/offIO.cpp index 94f69d586fc..ffc0fa34b24 100644 --- a/Nef_3/examples/Nef_3/offIO.cpp +++ b/Nef_3/examples/Nef_3/offIO.cpp @@ -1,7 +1,6 @@ #include #include #include -#include #include #include #include diff --git a/Nef_3/test/Nef_3/nef_union_error_llvm.cpp b/Nef_3/test/Nef_3/nef_union_error_llvm.cpp index bca9fec0243..d0683165374 100644 --- a/Nef_3/test/Nef_3/nef_union_error_llvm.cpp +++ b/Nef_3/test/Nef_3/nef_union_error_llvm.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include #include diff --git a/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_example.cpp b/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_example.cpp index e45b6ea9ee0..31f49252ad2 100644 --- a/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_example.cpp +++ b/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_example.cpp @@ -1,7 +1,6 @@ #include #include #include -#include #include #include #include diff --git a/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_function.cpp b/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_function.cpp index 704c88bb495..8ddef0b3273 100644 --- a/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_function.cpp +++ b/Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_function.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/fairing_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/fairing_test.cpp index dfbff75feb6..b3eff2f4aab 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/fairing_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/fairing_test.cpp @@ -1,8 +1,6 @@ #include #include #include -#include -#include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/orient_polygon_soup_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/orient_polygon_soup_test.cpp index a763b6b8128..eabf7f14538 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/orient_polygon_soup_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/orient_polygon_soup_test.cpp @@ -2,13 +2,11 @@ #include #include -#include #include #include #include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/point_inside_polyhedron_boundary_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/point_inside_polyhedron_boundary_test.cpp index e4ce28785ae..d2081853d35 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/point_inside_polyhedron_boundary_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/point_inside_polyhedron_boundary_test.cpp @@ -2,8 +2,6 @@ #include #include #include -#include -#include #include "point_inside_helpers.h" diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/polygon_mesh_slicer_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/polygon_mesh_slicer_test.cpp index 6d6820b9288..a08b5302938 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/polygon_mesh_slicer_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/polygon_mesh_slicer_test.cpp @@ -4,11 +4,8 @@ #include #ifdef USE_SURFACE_MESH #include -#include #else #include -#include -#include #endif #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/surface_intersection_sm_poly.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/surface_intersection_sm_poly.cpp index c362b06b61e..154b56bd6d4 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/surface_intersection_sm_poly.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/surface_intersection_sm_poly.cpp @@ -2,8 +2,6 @@ #include #include #include -#include -#include #include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_corefinement_bool_op.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_corefinement_bool_op.cpp index 6b1d61c739d..29501f793ea 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_corefinement_bool_op.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_corefinement_bool_op.cpp @@ -7,7 +7,6 @@ #include #include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_detect_features.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_detect_features.cpp index 2e88a149549..7199a5f4e58 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_detect_features.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_detect_features.cpp @@ -49,6 +49,7 @@ int main(int argc, char* argv[]) = PMP::sharp_edges_segmentation(mesh, 90, eif, pid, PMP::parameters::first_index(1) .vertex_incident_patches_map(vip)); + CGAL_assertion(number_of_patches == 6); PMP::detect_sharp_edges(mesh, 90, eif); @@ -89,3 +90,4 @@ int main(int argc, char* argv[]) return 0; } + diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_is_polygon_soup_a_polygon_mesh.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_is_polygon_soup_a_polygon_mesh.cpp index 06197919b57..edfc4802110 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_is_polygon_soup_a_polygon_mesh.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_is_polygon_soup_a_polygon_mesh.cpp @@ -1,5 +1,4 @@ #include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_pmp_remove_border_edge.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_pmp_remove_border_edge.cpp index 2fa0e4cef27..80d530789da 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_pmp_remove_border_edge.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_pmp_remove_border_edge.cpp @@ -1,8 +1,6 @@ #include #include #include -#include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_stitching.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_stitching.cpp index 14fc54b703e..21b85e5fb4b 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/test_stitching.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/test_stitching.cpp @@ -1,8 +1,6 @@ #include #include #include -#include -#include #include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_faces_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_faces_test.cpp index 524b23fde04..f2b2bed516a 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_faces_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_faces_test.cpp @@ -1,7 +1,6 @@ #include #include #include -#include #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_no_delaunay_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_no_delaunay_test.cpp index e3c7b62d9b6..213cfa95b5a 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_no_delaunay_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_no_delaunay_test.cpp @@ -5,13 +5,8 @@ #include #ifdef POLY #include -#include -#include -#include #else #include -#include -#include #endif #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_test.cpp index 4003415e2e4..afff2c7acba 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_Polyhedron_3_test.cpp @@ -3,13 +3,8 @@ #include #ifdef POLY #include -#include -#include -#include #else #include -#include -#include #endif #include diff --git a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_polyline_test.cpp b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_polyline_test.cpp index c6998746633..16cfe36105a 100644 --- a/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_polyline_test.cpp +++ b/Polygon_mesh_processing/test/Polygon_mesh_processing/triangulate_hole_polyline_test.cpp @@ -9,9 +9,6 @@ #include #include -#include -#include -#include #include diff --git a/Polyhedron/examples/Polyhedron/polyhedron_prog_cut_cube.cpp b/Polyhedron/examples/Polyhedron/polyhedron_prog_cut_cube.cpp index 74dcfff094a..c244c1c1c74 100644 --- a/Polyhedron/examples/Polyhedron/polyhedron_prog_cut_cube.cpp +++ b/Polyhedron/examples/Polyhedron/polyhedron_prog_cut_cube.cpp @@ -1,5 +1,4 @@ #include -#include #include #include #include diff --git a/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv.cpp b/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv.cpp index 009841ff69a..bf1104c3c3b 100644 --- a/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv.cpp +++ b/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include #include diff --git a/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv_with_boundary.cpp b/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv_with_boundary.cpp index 90ead40b2ff..744440fd123 100644 --- a/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv_with_boundary.cpp +++ b/Polyhedron/examples/Polyhedron/polyhedron_prog_subdiv_with_boundary.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include #include diff --git a/Polyhedron/examples/Polyhedron/polyhedron_self_intersection.cpp b/Polyhedron/examples/Polyhedron/polyhedron_self_intersection.cpp index 5bea593eaa1..a70ee0fd0e2 100644 --- a/Polyhedron/examples/Polyhedron/polyhedron_self_intersection.cpp +++ b/Polyhedron/examples/Polyhedron/polyhedron_self_intersection.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include #include diff --git a/Polyhedron/test/Polyhedron/bug_polyhedron_incremental_builder_3.cpp b/Polyhedron/test/Polyhedron/bug_polyhedron_incremental_builder_3.cpp index 17ead1f548f..df51270184b 100644 --- a/Polyhedron/test/Polyhedron/bug_polyhedron_incremental_builder_3.cpp +++ b/Polyhedron/test/Polyhedron/bug_polyhedron_incremental_builder_3.cpp @@ -1,7 +1,6 @@ #include #include #include -#include #include typedef CGAL::Simple_cartesian K; diff --git a/Polyhedron_IO/examples/Polyhedron_IO/off2stl.cpp b/Polyhedron_IO/examples/Polyhedron_IO/off2stl.cpp index 71e2c2b7723..0419f5e218e 100644 --- a/Polyhedron_IO/examples/Polyhedron_IO/off2stl.cpp +++ b/Polyhedron_IO/examples/Polyhedron_IO/off2stl.cpp @@ -2,7 +2,6 @@ #include #include -#include #include #include #include diff --git a/Polyhedron_IO/examples/Polyhedron_IO/polyhedron2vrml.cpp b/Polyhedron_IO/examples/Polyhedron_IO/polyhedron2vrml.cpp index a2466f354e1..f6431fd9b57 100644 --- a/Polyhedron_IO/examples/Polyhedron_IO/polyhedron2vrml.cpp +++ b/Polyhedron_IO/examples/Polyhedron_IO/polyhedron2vrml.cpp @@ -1,6 +1,5 @@ #include #include -#include #include #include diff --git a/Polyhedron_IO/examples/Polyhedron_IO/polyhedron_copy.cpp b/Polyhedron_IO/examples/Polyhedron_IO/polyhedron_copy.cpp index b192f224fe5..f93cd531db5 100644 --- a/Polyhedron_IO/examples/Polyhedron_IO/polyhedron_copy.cpp +++ b/Polyhedron_IO/examples/Polyhedron_IO/polyhedron_copy.cpp @@ -2,7 +2,6 @@ #include #include -#include #include #include #include diff --git a/Polyhedron_IO/test/Polyhedron_IO/test_polyhedron_io.cpp b/Polyhedron_IO/test/Polyhedron_IO/test_polyhedron_io.cpp index 181062a7990..f737d11d10f 100644 --- a/Polyhedron_IO/test/Polyhedron_IO/test_polyhedron_io.cpp +++ b/Polyhedron_IO/test/Polyhedron_IO/test_polyhedron_io.cpp @@ -32,7 +32,6 @@ // disabled compilers. #ifndef CGAL_USE_POLYHEDRON_DESIGN_ONE -#include #include #include #include diff --git a/Ridges_3/examples/Ridges_3/PolyhedralSurf.h b/Ridges_3/examples/Ridges_3/PolyhedralSurf.h index 13f555e1cf8..44a36ea7fd5 100644 --- a/Ridges_3/examples/Ridges_3/PolyhedralSurf.h +++ b/Ridges_3/examples/Ridges_3/PolyhedralSurf.h @@ -3,9 +3,6 @@ #include #include -#include -#include -#include #include #include #include diff --git a/Ridges_3/test/Ridges_3/PolyhedralSurf.h b/Ridges_3/test/Ridges_3/PolyhedralSurf.h index 13f555e1cf8..44a36ea7fd5 100644 --- a/Ridges_3/test/Ridges_3/PolyhedralSurf.h +++ b/Ridges_3/test/Ridges_3/PolyhedralSurf.h @@ -3,9 +3,6 @@ #include #include -#include -#include -#include #include #include #include diff --git a/Skin_surface_3/test/Skin_surface_3/degenerate_test.cpp b/Skin_surface_3/test/Skin_surface_3/degenerate_test.cpp index fbc6f377732..59638cf9178 100644 --- a/Skin_surface_3/test/Skin_surface_3/degenerate_test.cpp +++ b/Skin_surface_3/test/Skin_surface_3/degenerate_test.cpp @@ -3,7 +3,6 @@ #include #include #include -#include #include #include diff --git a/Skin_surface_3/test/Skin_surface_3/degenerate_test_exact.cpp b/Skin_surface_3/test/Skin_surface_3/degenerate_test_exact.cpp index 86590e8a36b..ca7fd696be9 100644 --- a/Skin_surface_3/test/Skin_surface_3/degenerate_test_exact.cpp +++ b/Skin_surface_3/test/Skin_surface_3/degenerate_test_exact.cpp @@ -2,7 +2,6 @@ #include #include #include -#include #include #include diff --git a/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_deformation_session.cpp b/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_deformation_session.cpp index 23d96f039f7..383b5cd2f66 100644 --- a/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_deformation_session.cpp +++ b/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_deformation_session.cpp @@ -5,7 +5,6 @@ #include #include #include -#include #include #include diff --git a/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_performance_test.cpp b/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_performance_test.cpp index 081c53030b2..6045e1cf4a7 100644 --- a/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_performance_test.cpp +++ b/Surface_mesh_deformation/test/Surface_mesh_deformation/Cactus_performance_test.cpp @@ -6,7 +6,6 @@ #include #include -#include #include #include diff --git a/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h b/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h index 2650b7dbc91..eaa06b83d95 100644 --- a/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h +++ b/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h @@ -1,6 +1,3 @@ -#include -#include - #include #include #include diff --git a/Surface_mesh_deformation/test/Surface_mesh_deformation/Symmetry_test.cpp b/Surface_mesh_deformation/test/Surface_mesh_deformation/Symmetry_test.cpp index 6dddddf8008..cea63122867 100644 --- a/Surface_mesh_deformation/test/Surface_mesh_deformation/Symmetry_test.cpp +++ b/Surface_mesh_deformation/test/Surface_mesh_deformation/Symmetry_test.cpp @@ -8,7 +8,6 @@ #include #include #include -#include typedef CGAL::Simple_cartesian Kernel; typedef CGAL::Polyhedron_3 Polyhedron; diff --git a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Fast_sdf_calculation_test.cpp b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Fast_sdf_calculation_test.cpp index 3b1c54d11cd..4f6c44ed6c9 100644 --- a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Fast_sdf_calculation_test.cpp +++ b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Fast_sdf_calculation_test.cpp @@ -1,6 +1,5 @@ #include -#include -#include +#include #include #include diff --git a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Filters_test.cpp b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Filters_test.cpp index 831ce389984..e4897a0dd6c 100644 --- a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Filters_test.cpp +++ b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/Filters_test.cpp @@ -1,8 +1,7 @@ #include #include -#include -#include +#include #include #include diff --git a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test.cpp b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test.cpp index ebd3e4019c6..2afde8999d9 100644 --- a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test.cpp +++ b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test.cpp @@ -1,6 +1,5 @@ #include -#include -#include +#include #include diff --git a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test_using_boost.cpp b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test_using_boost.cpp index 992203e964d..eaf9f8b1f81 100644 --- a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test_using_boost.cpp +++ b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/mesh_segmentation_test_using_boost.cpp @@ -1,8 +1,7 @@ #define CGAL_DO_NOT_USE_BOYKOV_KOLMOGOROV_MAXFLOW_SOFTWARE #include -#include -#include +#include #include diff --git a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/test_compute_sdf_values_and_segment_exact_rational.cpp b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/test_compute_sdf_values_and_segment_exact_rational.cpp index 80703d42805..36b3989e902 100644 --- a/Surface_mesh_segmentation/test/Surface_mesh_segmentation/test_compute_sdf_values_and_segment_exact_rational.cpp +++ b/Surface_mesh_segmentation/test/Surface_mesh_segmentation/test_compute_sdf_values_and_segment_exact_rational.cpp @@ -1,8 +1,7 @@ #include #include -#include +#include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_1.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_1.cpp index f5af383014e..457c5f951a0 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_1.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_1.cpp @@ -9,9 +9,7 @@ #include #include -#include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_2.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_2.cpp index 8b5493eea39..5a895e77fc4 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_2.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_2.cpp @@ -11,11 +11,8 @@ #include #include -#include #include -#include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_3.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_3.cpp index eb81aa1df7d..96af1eed022 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_3.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_3.cpp @@ -2,12 +2,10 @@ #include #include -#include #include #include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_4.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_4.cpp index 87020292d7c..c6ab30e0fef 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_4.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_4.cpp @@ -2,12 +2,10 @@ #include #include -#include #include #include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_5.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_5.cpp index a00e74fa66e..aea9ead5bd8 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_5.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_test_5.cpp @@ -10,9 +10,7 @@ #include #include -#include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_traits_test.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_traits_test.cpp index d3e575d5e68..04744d1b3ac 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_traits_test.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/Surface_mesh_shortest_path_traits_test.cpp @@ -2,14 +2,12 @@ #include #include -#include #include #include #include #include -#include #include #include diff --git a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/TestMesh.cpp b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/TestMesh.cpp index 2edc30b901c..89f57b80826 100644 --- a/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/TestMesh.cpp +++ b/Surface_mesh_shortest_path/test/Surface_mesh_shortest_path/TestMesh.cpp @@ -20,14 +20,12 @@ #include #include -#include #include #include #include #include -#include #include #include diff --git a/Surface_mesh_simplification/examples/Surface_mesh_simplification/edge_collapse_bounded_normal_change.cpp b/Surface_mesh_simplification/examples/Surface_mesh_simplification/edge_collapse_bounded_normal_change.cpp index 037d75c4c27..f46b2bfb847 100644 --- a/Surface_mesh_simplification/examples/Surface_mesh_simplification/edge_collapse_bounded_normal_change.cpp +++ b/Surface_mesh_simplification/examples/Surface_mesh_simplification/edge_collapse_bounded_normal_change.cpp @@ -2,8 +2,6 @@ #include #include #include -#include -#include // Simplification function #include diff --git a/Surface_mesh_simplification/test/Surface_mesh_simplification/basics.h b/Surface_mesh_simplification/test/Surface_mesh_simplification/basics.h index 6f3b1ae089d..0dc8b196a84 100644 --- a/Surface_mesh_simplification/test/Surface_mesh_simplification/basics.h +++ b/Surface_mesh_simplification/test/Surface_mesh_simplification/basics.h @@ -27,7 +27,6 @@ void Surface_simplification_external_trace( std::string s ) #include #include -#include #include #include @@ -35,7 +34,6 @@ void Surface_simplification_external_trace( std::string s ) #include #include -#include #include #include diff --git a/Surface_mesh_simplification/test/Surface_mesh_simplification/edge_collapse_topology.cpp b/Surface_mesh_simplification/test/Surface_mesh_simplification/edge_collapse_topology.cpp index e6c6d3d18ac..2501ead0069 100644 --- a/Surface_mesh_simplification/test/Surface_mesh_simplification/edge_collapse_topology.cpp +++ b/Surface_mesh_simplification/test/Surface_mesh_simplification/edge_collapse_topology.cpp @@ -3,9 +3,6 @@ #include #include -#include - -#include // Simplification function #include diff --git a/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/MCF_Skeleton_test.cpp b/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/MCF_Skeleton_test.cpp index 4467550ae86..63deba74b69 100644 --- a/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/MCF_Skeleton_test.cpp +++ b/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/MCF_Skeleton_test.cpp @@ -1,10 +1,8 @@ #include #include -#include #include #include #include -#include #include diff --git a/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/skeleton_connectivity_test.cpp b/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/skeleton_connectivity_test.cpp index 0fab0e9af72..4409100ab7e 100644 --- a/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/skeleton_connectivity_test.cpp +++ b/Surface_mesh_skeletonization/test/Surface_mesh_skeletonization/skeleton_connectivity_test.cpp @@ -1,10 +1,8 @@ #include #include -#include #include #include #include -#include #include From 0c61d13e2ffd3f4f025355500b1656b1cea4de01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Fri, 4 May 2018 10:45:15 +0200 Subject: [PATCH 12/31] add missing include directive --- BGL/include/CGAL/boost/graph/graph_traits_OpenMesh.h | 1 - .../Surface_mesh_deformation_test_commons.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/BGL/include/CGAL/boost/graph/graph_traits_OpenMesh.h b/BGL/include/CGAL/boost/graph/graph_traits_OpenMesh.h index bf95392fdb4..71baeb00990 100644 --- a/BGL/include/CGAL/boost/graph/graph_traits_OpenMesh.h +++ b/BGL/include/CGAL/boost/graph/graph_traits_OpenMesh.h @@ -34,7 +34,6 @@ #include #include - #if defined(BOOST_MSVC) # pragma warning(push) # pragma warning(disable:4267) diff --git a/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h b/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h index eaa06b83d95..b165ac6c6b2 100644 --- a/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h +++ b/Surface_mesh_deformation/test/Surface_mesh_deformation/Surface_mesh_deformation_test_commons.h @@ -1,3 +1,4 @@ +#include #include #include #include From 887766a0e1fc985580c67cd2ff33190ca99abe34 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Tue, 8 May 2018 17:12:10 +0100 Subject: [PATCH 13/31] Postfix class names with _2 and _3 as they are different --- Alpha_shapes_2/include/CGAL/internal/Lazy_alpha_nt_2.h | 8 ++++---- Alpha_shapes_3/include/CGAL/internal/Lazy_alpha_nt_3.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Alpha_shapes_2/include/CGAL/internal/Lazy_alpha_nt_2.h b/Alpha_shapes_2/include/CGAL/internal/Lazy_alpha_nt_2.h index eaafd27f71d..83eeac727d5 100644 --- a/Alpha_shapes_2/include/CGAL/internal/Lazy_alpha_nt_2.h +++ b/Alpha_shapes_2/include/CGAL/internal/Lazy_alpha_nt_2.h @@ -45,7 +45,7 @@ namespace internal { // template < class Input_traits, class Kernel_approx, class Kernel_exact, class Weighted_tag > -class Is_traits_point_convertible +class Is_traits_point_convertible_2 { typedef typename Kernel_traits::Kernel Kernel_input; @@ -60,7 +60,7 @@ public: }; template < class Input_traits, class Kernel_approx, class Kernel_exact > -class Is_traits_point_convertible { typedef typename Kernel_traits::Kernel Kernel_input; @@ -157,7 +157,7 @@ class Lazy_alpha_nt_2 Approx_point to_approx(const Input_point& wp) const { // The traits class' Point_2 must be convertible using the Cartesian converter - CGAL_static_assertion((Is_traits_point_convertible< + CGAL_static_assertion((Is_traits_point_convertible_2< Input_traits, Kernel_approx, Kernel_exact, Weighted_tag>::value)); To_approx converter; @@ -167,7 +167,7 @@ class Lazy_alpha_nt_2 Exact_point to_exact(const Input_point& wp) const { // The traits class' Point_2 must be convertible using the Cartesian converter - CGAL_static_assertion((Is_traits_point_convertible< + CGAL_static_assertion((Is_traits_point_convertible_2< Input_traits, Kernel_approx, Kernel_exact, Weighted_tag>::value)); To_exact converter; diff --git a/Alpha_shapes_3/include/CGAL/internal/Lazy_alpha_nt_3.h b/Alpha_shapes_3/include/CGAL/internal/Lazy_alpha_nt_3.h index 8a4effe1a4b..97005825a79 100644 --- a/Alpha_shapes_3/include/CGAL/internal/Lazy_alpha_nt_3.h +++ b/Alpha_shapes_3/include/CGAL/internal/Lazy_alpha_nt_3.h @@ -45,7 +45,7 @@ namespace internal{ // template < class Input_traits, class Kernel_approx, class Kernel_exact, class Weighted_tag > -class Is_traits_point_convertible +class Is_traits_point_convertible_3 { typedef typename Kernel_traits::Kernel Kernel_input; @@ -60,7 +60,7 @@ public: }; template < class Input_traits, class Kernel_approx, class Kernel_exact > -class Is_traits_point_convertible { typedef typename Kernel_traits::Kernel Kernel_input; @@ -148,7 +148,7 @@ class Lazy_alpha_nt_3{ Approx_point to_approx(const Input_point& wp) const { // The traits class' Point_3 must be convertible using the Cartesian converter - CGAL_static_assertion((Is_traits_point_convertible< + CGAL_static_assertion((Is_traits_point_convertible_3< Input_traits, Kernel_approx, Kernel_exact, Weighted_tag>::value)); To_approx converter; @@ -158,7 +158,7 @@ class Lazy_alpha_nt_3{ Exact_point to_exact(const Input_point& wp) const { // The traits class' Point_3 must be convertible using the Cartesian converter - CGAL_static_assertion((Is_traits_point_convertible< + CGAL_static_assertion((Is_traits_point_convertible_3< Input_traits, Kernel_approx, Kernel_exact, Weighted_tag>::value)); To_exact converter; From b4f16e759c53e00eaef767b8c9cb3c2ef3cfc640 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 9 May 2018 10:05:27 +0100 Subject: [PATCH 14/31] Remove a redundant figure and add the word 'conforming' --- Mesh_2/doc/Mesh_2/Mesh_2.txt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Mesh_2/doc/Mesh_2/Mesh_2.txt b/Mesh_2/doc/Mesh_2/Mesh_2.txt index 7d6484b1f90..3ff3e3797f4 100644 --- a/Mesh_2/doc/Mesh_2/Mesh_2.txt +++ b/Mesh_2/doc/Mesh_2/Mesh_2.txt @@ -98,11 +98,7 @@ printed. See \cgalFigureRef{Conformexampleconform} \cgalFigureBegin{Conformexampleconform,example-conform-Delaunay-Gabriel.png} -Initial triangulation and the corresponding Delaunay and Gabriel triangulation. -\cgalFigureEnd - -\cgalFigureBegin{ConformexampleconformDelaunay,example-conform-Delaunay.png} -The corresponding conforming Delaunay triangulation. +Initial triangulation and the corresponding conforming Delaunay and Gabriel triangulation. \cgalFigureEnd \section secMesh_2_meshes Meshes From b984dce2226f9e341cfb2fa72934666a9e871f86 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Fri, 11 May 2018 08:32:11 +0100 Subject: [PATCH 15/31] Address all remaining points of issue #1384, but the renderer --- .../include/CGAL/Arr_circle_segment_traits_2.h | 7 ++++++- Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Arrangement_on_surface_2/include/CGAL/Arr_circle_segment_traits_2.h b/Arrangement_on_surface_2/include/CGAL/Arr_circle_segment_traits_2.h index bdbd53d20a4..6a45bafe0c9 100644 --- a/Arrangement_on_surface_2/include/CGAL/Arr_circle_segment_traits_2.h +++ b/Arrangement_on_surface_2/include/CGAL/Arr_circle_segment_traits_2.h @@ -31,6 +31,7 @@ * The header file for the Arr_circle_segment_traits_2 class. */ +#include #include #include #include @@ -84,7 +85,11 @@ public: /*! Get the next curve index. */ static unsigned int get_index () { - static unsigned int index = 0; +#ifdef CGAL_NO_ATOMIC + static unsigned int index; +#else + static CGAL::cpp11::atomic index; +#endif return (++index); } diff --git a/Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h b/Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h index 69e7e29b755..d84c112662c 100644 --- a/Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h +++ b/Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h @@ -31,6 +31,7 @@ * The conic traits-class for the arrangement package. */ +#include #include #include #include @@ -114,7 +115,11 @@ public: /*! Get the next conic index. */ static unsigned int get_index () { - static unsigned int index = 0; +#ifdef CGAL_NO_ATOMIC + static unsigned int index; +#else + static CGAL::cpp11::atomic index; +#endif return (++index); } From 5ac03b991902b568a0a37271a69da10a6e9ceb15 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Fri, 11 May 2018 10:22:37 +0100 Subject: [PATCH 16/31] PSP: Use \cgalCite --- Point_set_processing_3/include/CGAL/mst_orient_normals.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Point_set_processing_3/include/CGAL/mst_orient_normals.h b/Point_set_processing_3/include/CGAL/mst_orient_normals.h index b46e626e91f..f05ab4ffa17 100644 --- a/Point_set_processing_3/include/CGAL/mst_orient_normals.h +++ b/Point_set_processing_3/include/CGAL/mst_orient_normals.h @@ -501,7 +501,7 @@ create_mst_graph( /** \ingroup PkgPointSetProcessingAlgorithms Orients the normals of the range of `points` using the propagation - of a seed orientation through a minimum spanning tree of the Riemannian graph [Hoppe92]. + of a seed orientation through a minimum spanning tree of the Riemannian graph \cgalCite{cgal:hddms-srup-92}. This method modifies the order of input points so as to pack all sucessfully oriented points first, and returns an iterator over the first point with an unoriented normal (see erase-remove idiom). From 16e4cc5e4b6a6e0f951266ec2ba8121eea2718b7 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Fri, 11 May 2018 14:42:30 +0100 Subject: [PATCH 17/31] Fix 2D Constrained Delaunay demo. The hint was outdated after cdt.clear() --- .../demo/Triangulation_2/TriangulationCircumcircle.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h b/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h index 59589cf1815..4a88e63a14d 100644 --- a/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h +++ b/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h @@ -33,6 +33,7 @@ protected: private: DT * dt; + typedef typename DT::Vertex_handle Vertex_handle; typename DT::Vertex_handle hint; typename DT::Face_handle fh; QGraphicsScene *scene_; @@ -89,8 +90,12 @@ TriangulationCircumcircle::mouseMoveEvent(QGraphicsSceneMouseEvent *event) { if(dt->dimension() != 2){ circle->hide(); + hint = Vertex_handle(); return; } + if (hint == Vertex_handle()){ + hint = dt->infinite_vertex(); + } typename T::Point p = typename T::Point(event->scenePos().x(), event->scenePos().y()); fh = dt->locate(p, hint->face()); hint = fh->vertex(0); From 7e42e9f5a2c9705b2a4fc92bfae6e0047d084475 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Fri, 11 May 2018 22:53:43 +0200 Subject: [PATCH 18/31] move citation to avoid line break in the brief. --- Point_set_processing_3/include/CGAL/mst_orient_normals.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Point_set_processing_3/include/CGAL/mst_orient_normals.h b/Point_set_processing_3/include/CGAL/mst_orient_normals.h index f05ab4ffa17..f441f209de9 100644 --- a/Point_set_processing_3/include/CGAL/mst_orient_normals.h +++ b/Point_set_processing_3/include/CGAL/mst_orient_normals.h @@ -501,11 +501,12 @@ create_mst_graph( /** \ingroup PkgPointSetProcessingAlgorithms Orients the normals of the range of `points` using the propagation - of a seed orientation through a minimum spanning tree of the Riemannian graph \cgalCite{cgal:hddms-srup-92}. - + of a seed orientation through a minimum spanning tree of the Riemannian graph. This method modifies the order of input points so as to pack all sucessfully oriented points first, and returns an iterator over the first point with an unoriented normal (see erase-remove idiom). For this reason it should not be called on sorted containers. + It is based on \cgalCite{cgal:hddms-srup-92}. + \warning This function may fail when Boost version 1.54 is used, because of the following bug: https://svn.boost.org/trac/boost/ticket/9012 From 0b505bb7466df3f9921d4b76b29def88f37fdce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Fri, 11 May 2018 23:04:39 +0200 Subject: [PATCH 19/31] remove unused figure --- .../doc/Mesh_2/fig/example-conform-Delaunay.png | Bin 4500 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 Mesh_2/doc/Mesh_2/fig/example-conform-Delaunay.png diff --git a/Mesh_2/doc/Mesh_2/fig/example-conform-Delaunay.png b/Mesh_2/doc/Mesh_2/fig/example-conform-Delaunay.png deleted file mode 100644 index 580db6feb3df34ec63ab00365af75198bb121c15..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 4500 zcmXX~3pkVQ8{f%c4$C%Q!jLeO5MquKO4jDkk|@$)v~rkH&P`KQ z7WHq=aqJb(Xrv{r^T7XX;$*=Z) zBBSbxGrx7%$LZUbsl-$TO1zz1Ys+GrjblpmHpJZ4gu?vgccaBl)pHa$B{21OZ+#Z7 zPhbR?f0eGDS3bs1Lxo(K^$9)fga|*GgQH~_jXqM7P~ubXtVoSjk(svHbS=LHjF*<4 zYSfl=qZjmfUgu=AXd7ZzHoan+z0ee+o1f*Xb<5#NlY4{N@oeKUTAoqC!SboFh(Lnb zn6%g^dSA^I{Ybo8PL}0%A5O-jncp$^m$Ro2Z}T*BV;0fzjvh}!0p|foN`m)TV^zIV z*@LWtD@K+#4tgn-to`EcWjo$_nM-iGf9|?kjLJ-Wmc{oSYlXspg08#sR}8vo$MZgr zjh1hm-KL#sPqVq@Icj`H>RZI1d#2BX0vl;2N{gfmb4t=_^8vMpb$aMT2_hBmcAO+{Q4gIW!P)Evk>8W zW_NOhx=RPlq1c4Qj%{POb7H;*Ok{qhfxYg|)_1=#`+VJ4%jHVzLW{bEh;<9FDe13N ze4|5mm2;>H9$3;Q+hx4znJepufk&+dCz?A75u|ykcPUoH`pjbcG5agIKBN$+MvJ}VO}mh_A3M>Y&L#SzNF=p!cxndF3LQ#Q(RcShq*J2=c2&6&?zT0>WHH<=Ut+)ba$>OkQ*&iE7^zl5>=!LgjO>T; zKwn;4$p!yUnq)g@mR0g`>J^5L)vN#h+P#|!^yYb)=T)307}o6{SoDRYJfHgy7o78@ zsfaNeTwn<$+bQRoCs*r>o-zfB=2c`5Nvt~fHQy@ensHg~K4vTV>=x|3)3gE9Shc3dpZ`#neiy;zfxLh zNiw7@b|hQd8d3+ggFf< z59d(X-?n>B_SD}g{M_Pt)P>0)d6xD#RGE26npP7({F?5AI3e8;@Nq$5>-Ps8racyc ze3>K*PE`9dyDBdt&yZ43ARQ6vE^;LPYt%KFzW3v&PWvn2_}1MhkDAn93OH)uB}{_8 zXm#|u!TvMhkqSB#JA8)*&MS=GpFaQT>N8@(W+ANisHDi3apa!tG1&5{aLm|Qi?o$5 zamR_{Dg_3r2+KV5yV9bF>3rM8n=m#RW2;}-wQg%BIyTm+``A!)EJP#o35-1yMo0Y< zw&(~p)EvOQH4vSq_{)4l(sJs$;BB8$&MJVbw+!HRKU@zA2xhSV8UajD{5b(~YBU#%yy)&bUkYT{btd7VPaA=^Ys zFRXe^VC)lv6Z-9Tad-7HjNv%6d7kBVaHv9&?-rjKM&dPjaBCt1q<1f7hj{OqiR^*GjH3zuZP7rri<`T!>>Wi*1sq6q4MqyW;ob>ZP9jewbUL{bRc~(x# zhsWhl5FiL&9DP3=g1A{C=pykdEm-Uyc|gKUL@lG{-lbG_Q;wI&^mb-)kuSFcr2q>q zDA)nRTr|&9tB=+z3XrQkpJ8qQ&ZLFWLoA*zKV-OibD~<2G6PnKP-?GiIY_ z@;8jorDqGGMUOV5=!v?>LFhCBl*~M4=1TF1$4IWu`!GtB6Mp^csgEX`*_c z>KV%^(Zj1M9DNawkAILih1vM8ln@^p|;d+6;y1Xy0xi~#g=O;(e6!G z#Ca3{q9*aGz+kzY`UeNEGN8V>+^)gd|7bb%cF0OQ8K5ien@c49f*UU_B%xHGhob#y zJg{^gg2?bbuYsR=u2-8Lsu;(QM0`CkL+Z_av3Hx5*$T`_%Pc<24-33xo;IY+iWwv|5#t-9Gmd(goy_)&2+e2;B^>31{5YV z(7vUM`8WUJZ2-MW$T3YdTJV;JtC)SihOZfjELSv%$9$nk1py7Z$CieoZZ~ZQ47%>r({Q9 z2%>nTP%Aq5BOsk5RbVG0dp;ul{D~r7AH57dI`mgqLmKl21Dc+oHr<2_`mp;U^{BT$ zOJHwsz=#)|;=VG!-uC^>NS3tzv7^&YAlTMRiEa=?Ot^p+86oE|)@x$^BzBl-EM$eD zmvU{iz5TA!o(6TcJ~vj~+Pr8;h`3-wetfjX&Xea=|X0Lzs!e<{TxJS#!(TFSRKCf~YqUGKGJ&jeZSVD-Vf#M1-hc*3oK`foL+!oaC^Dq zDm2lxx=?QPq|}5r{x`h(^koHiH3O4^3_|gCOK%t4-yEl({~< zczWmuiHHyT`uc$%sp#!Vy#bU0kp-nzo(XOFW7#Z=9&Mfb5gn$)?an#`wI zTI^P%7yLl~%+TjME1k{TU->`~d*p3G;W(?$N;ZCtD6~e@y9w^u@YAKhc7nEPl*b(k zPG+HiO$asZd49GTXh<0#bUS;+2sGM){!X8zp~+&`&NE*jbIM@M1|-Cf~K ziFuW^1xcjT!G9G7W7qhPhJ-*oi!(G~>|S}B)w*mCwPU+IB!n;k8~hbtc?HJ4mccTI zRLI~lwBk49bQ*e}+-t>@1ju6WEm$a5?7%9q`gG4D@c`p?Lw86hs3XR_P1tc1ZncekVP9 zeGB^bUCkq+m+laSeRyz1F0BIxOG33Pk0YheZ9A05m!D;;$Nao$c5F9%W_Y;M!67YC zy7-*0EF;4@v$Il(w`{GtdCr8(h$V7QL_kJ##j*$K1|fcc`FP_apgJXtY|S`#9uyrR zLW4K$=cehw98^NNX_jFpWkvTqzB)gb`}8jFWj;EN7d_>=D+(Hm32;FcB|V6QHXec2 zx^dHlux4|yEaC5L|E&AiG|QTeEL&PeK^x@bu> z2=ZyhtTQ*QTs{sJAsVWWYT5ni$DOhIBuU>}uv)~HqpdB?yWiz5`H*FgaVw7-Y&w$k z&6%IBMV2|n)#U)k+r_B&WqB{>`{?d)GEAr*@mFo8QN?<58-8XX`AODNAK;|(9N%bk zere9Aaa&4^UUVlz(FSAKy?8Tg3E2S?E?cjvd|D20TMg&wO+T4NMug~g&%C?3^aAcM zyUCZUo@SI^9l~!q>Vk~8g{IKmRy+5F*Z^JwP?X+#yRtJkacSfnBXYoGR;DtS7JbPG zP3p?ZRODI;n^BYmzwKiuAg01-Bqb!;V9ZOC8Tq?8o_8q`b4#h>Q#qdntbYOTras%P zK64MOHoe77{on3CX0`+3teg7s4ZX1@@avgB|Cmm6Qx{yY8QY7ciAM~(dAB2xsjENz z{Gm?gxO>&P?N9(z6AYFvUZ{tu@PN`(Lb From c2c2c1e4981c3dfef1c85a67d0dd2efa6e9a6326 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Fri, 11 May 2018 23:06:40 +0200 Subject: [PATCH 20/31] improve phrasing --- Mesh_2/doc/Mesh_2/Mesh_2.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Mesh_2/doc/Mesh_2/Mesh_2.txt b/Mesh_2/doc/Mesh_2/Mesh_2.txt index 3ff3e3797f4..64012f69e97 100644 --- a/Mesh_2/doc/Mesh_2/Mesh_2.txt +++ b/Mesh_2/doc/Mesh_2/Mesh_2.txt @@ -98,7 +98,7 @@ printed. See \cgalFigureRef{Conformexampleconform} \cgalFigureBegin{Conformexampleconform,example-conform-Delaunay-Gabriel.png} -Initial triangulation and the corresponding conforming Delaunay and Gabriel triangulation. +From left to right: Initial Delaunay triangulation, the corresponding conforming Delaunay, and the corresponding Gabriel triangulation. \cgalFigureEnd \section secMesh_2_meshes Meshes From aef93a1d86f54336b9eb724af942d84c75c3c419 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Mon, 14 May 2018 16:19:34 +0200 Subject: [PATCH 21/31] add missing include directive --- Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp b/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp index dfead0ab3b4..8316a6f5335 100644 --- a/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp +++ b/Mesh_3/examples/Mesh_3/mesh_hybrid_mesh_domain.cpp @@ -7,6 +7,7 @@ #include #include +#include #include #include #include From 5690cc4a0242f45eb855a36a0760738b91a97aea Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 2 May 2018 15:40:49 +0100 Subject: [PATCH 22/31] Arrangement_2: Add Forward Declaration --- .../include/CGAL/Surface_sweep_2/Arr_overlay_traits_2.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Arrangement_on_surface_2/include/CGAL/Surface_sweep_2/Arr_overlay_traits_2.h b/Arrangement_on_surface_2/include/CGAL/Surface_sweep_2/Arr_overlay_traits_2.h index 1ef10dcf3c9..6df312301ba 100644 --- a/Arrangement_on_surface_2/include/CGAL/Surface_sweep_2/Arr_overlay_traits_2.h +++ b/Arrangement_on_surface_2/include/CGAL/Surface_sweep_2/Arr_overlay_traits_2.h @@ -347,6 +347,9 @@ public: return os; } + class Parameter_space_in_x_2; + class Parameter_space_in_y_2; + /*! A functor that computes intersections between x-monotone curves. */ class Intersect_2 { protected: From 99bc374cce52f419118df8f4d0ff12b06b1aa7e1 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 2 May 2018 16:17:47 +0100 Subject: [PATCH 23/31] More forward declarations --- Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h | 4 +++- .../include/CGAL/Arr_polycurve_traits_2.h | 3 +++ Polynomial/include/CGAL/Polynomial_traits_d.h | 8 +++----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h b/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h index 905b6d8eba2..43505f07271 100644 --- a/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h +++ b/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h @@ -201,7 +201,9 @@ public: }; // class Algebraic_real_traits - + + class Construct_algebraic_real_1; + // Functors of Algebraic_kernel_d_1 struct Solve_1 { public: diff --git a/Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h b/Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h index 34c7931e702..ef0d6e94e4c 100644 --- a/Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h +++ b/Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h @@ -163,6 +163,9 @@ public: /// \name Construction functors(based on the subcurve traits). //@{ +#ifndef DOXYGEN_RUNNING + class Push_back_2; +#endif /*! \class * A functor that divides an arc into x-monotone arcs. That are, arcs that * do not cross the identification arc. diff --git a/Polynomial/include/CGAL/Polynomial_traits_d.h b/Polynomial/include/CGAL/Polynomial_traits_d.h index 42c96b05c15..1c8b7f827af 100644 --- a/Polynomial/include/CGAL/Polynomial_traits_d.h +++ b/Polynomial/include/CGAL/Polynomial_traits_d.h @@ -729,7 +729,9 @@ public: return gic( gc( p, exponent ), ev ); }; }; - + + typedef CGAL::internal::Monomial_representation Monomial_representation; + // Swap variable x_i with x_j struct Swap { typedef Polynomial_d result_type; @@ -1537,10 +1539,6 @@ struct Construct_innermost_coefficient_const_iterator_range }; - typedef - CGAL::internal::Monomial_representation - Monomial_representation; - // returns the Exponten_vector of the innermost leading coefficient struct Degree_vector{ typedef Exponent_vector result_type; From b33ab791e1308414c3816eb33775bc41a46a09b4 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Sat, 5 May 2018 15:03:06 +0100 Subject: [PATCH 24/31] Disable a warning. Fix an allocator call --- CGAL_Core/include/CGAL/CORE/CoreDefs.h | 3 +++ Installation/include/CGAL/disable_warnings.h | 1 + .../CGAL/Partition_2/Rotation_tree_2.h | 4 ++++ .../include/CGAL/Segment_tree_d.h | 19 ++++++++++++++++++- 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/CGAL_Core/include/CGAL/CORE/CoreDefs.h b/CGAL_Core/include/CGAL/CORE/CoreDefs.h index 90759e086fa..499d7b1dbf3 100644 --- a/CGAL_Core/include/CGAL/CORE/CoreDefs.h +++ b/CGAL_Core/include/CGAL/CORE/CoreDefs.h @@ -41,6 +41,7 @@ #include #include +#include #ifdef CGAL_HEADER_ONLY @@ -340,4 +341,6 @@ inline void setPositionalFormat(std::ostream& o = std::cout) { #include #endif // CGAL_HEADER_ONLY +#include + #endif // _CORE_COREDEFS_H_ diff --git a/Installation/include/CGAL/disable_warnings.h b/Installation/include/CGAL/disable_warnings.h index 6c180ab3514..587492aad9c 100644 --- a/Installation/include/CGAL/disable_warnings.h +++ b/Installation/include/CGAL/disable_warnings.h @@ -34,6 +34,7 @@ # pragma warning(disable: 4714) // function marked as __forceinline not inlined # pragma warning(disable: 4800) // forcing value to bool 'true' or 'false' (performance warning) # pragma warning(disable: 4913) // user defined binary operator ',' exists but no overload could convert all operands, default built-in binary operator ',' used +# pragma warning(disable: 4834) // discarding return value of function with 'nodiscard' attribute #endif diff --git a/Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h b/Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h index f9228e36d0b..a149a137f06 100644 --- a/Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h +++ b/Partition_2/include/CGAL/Partition_2/Rotation_tree_2.h @@ -36,6 +36,8 @@ #ifndef CGAL_ROTATION_TREE_H #define CGAL_ROTATION_TREE_H +#include + #include @@ -178,6 +180,8 @@ private: #include +#include + #endif // CGAL_ROTATION_TREE_H // For the Emacs editor: diff --git a/SearchStructures/include/CGAL/Segment_tree_d.h b/SearchStructures/include/CGAL/Segment_tree_d.h index 1c0b6dafe39..625050bd1c5 100644 --- a/SearchStructures/include/CGAL/Segment_tree_d.h +++ b/SearchStructures/include/CGAL/Segment_tree_d.h @@ -107,7 +107,8 @@ protected: typedef Segment_tree_node Segment_tree_node_t; typedef Segment_tree_node *link_type; - std::allocator alloc; + typedef std::allocator allocator_type; + allocator_type alloc; C_Interface m_interface; bool is_built; @@ -197,7 +198,11 @@ protected: { Segment_tree_node_t node(l,r,kl,kr); Segment_tree_node_t* node_ptr = alloc.allocate(1); +#ifdef CGAL_CXX11 + std::allocator_traits::construct(alloc, node_ptr, node); +#else alloc.construct(node_ptr, node); +#endif return node_ptr; } @@ -205,7 +210,11 @@ protected: { Segment_tree_node_t node(kl,kr); Segment_tree_node_t* node_ptr = alloc.allocate(1); +#ifdef CGAL_CXX11 + std::allocator_traits::construct(alloc, node_ptr, node); +#else alloc.construct(node_ptr, node); +#endif return node_ptr; } @@ -213,7 +222,11 @@ protected: { Segment_tree_node_t node; Segment_tree_node_t* node_ptr = alloc.allocate(1); +#ifdef CGAL_CXX11 + std::allocator_traits::construct(alloc, node_ptr, node); +#else alloc.construct(node_ptr, node); +#endif return node_ptr; } @@ -298,7 +311,11 @@ protected: void delete_node(Segment_tree_node_t* node_ptr) { +#ifdef CGAL_CXX11 + std::allocator_traits::destroy(alloc, node_ptr); +#else alloc.destroy(node_ptr); +#endif alloc.deallocate(node_ptr,1); } From c65a07db7ea3d70ef0ba44a70eef0179266401cf Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Sat, 5 May 2018 18:48:34 +0100 Subject: [PATCH 25/31] Qualify local struct with class scope --- Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_traits_2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_traits_2.h b/Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_traits_2.h index 7088fd1b83d..1eb99e9e72a 100644 --- a/Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_traits_2.h +++ b/Minkowski_sum_2/include/CGAL/Minkowski_sum_2/AABB_traits_2.h @@ -102,11 +102,11 @@ public: if (bbox.xmax()-bbox.xmin() >= bbox.ymax()-bbox.ymin()) { - std::nth_element(first, middle, beyond, less_x); // sort along x + std::nth_element(first, middle, beyond, AABB_traits_2::less_x); // sort along x } else { - std::nth_element(first, middle, beyond, less_y); // sort along y + std::nth_element(first, middle, beyond, AABB_traits_2::less_y); // sort along y } } }; From 654980580e72fdfba460e35e9f18a0865bd0b467 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Mon, 7 May 2018 11:01:40 +0100 Subject: [PATCH 26/31] class -> struct --- Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h b/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h index 43505f07271..c60e509abea 100644 --- a/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h +++ b/Algebraic_kernel_d/include/CGAL/Algebraic_kernel_d_1.h @@ -202,7 +202,7 @@ public: }; // class Algebraic_real_traits - class Construct_algebraic_real_1; + struct Construct_algebraic_real_1; // Functors of Algebraic_kernel_d_1 struct Solve_1 { From af9605a773b74bfdf8a33a21b6596328c5533c4a Mon Sep 17 00:00:00 2001 From: Maxime Gimeno Date: Fri, 4 May 2018 13:55:17 +0200 Subject: [PATCH 27/31] Make the dependencies check NOT order dependant. --- .../developer_scripts/cgal_check_dependencies.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Scripts/developer_scripts/cgal_check_dependencies.sh b/Scripts/developer_scripts/cgal_check_dependencies.sh index de3f26f48b7..d394e40f56d 100644 --- a/Scripts/developer_scripts/cgal_check_dependencies.sh +++ b/Scripts/developer_scripts/cgal_check_dependencies.sh @@ -28,19 +28,22 @@ do fi done -cmake -DCGAL_ENABLE_CHECK_HEADERS=TRUE -DDOXYGEN_EXECUTABLE="$DOX_PATH" -DCGAL_COPY_DEPENDENCIES=TRUE -DCMAKE_CXX_FLAGS="-std=c++11" .. +cmake -DCGAL_HEADER_ONLY=FALSE -DCGAL_ENABLE_CHECK_HEADERS=TRUE -DDOXYGEN_EXECUTABLE="$DOX_PATH" -DCGAL_COPY_DEPENDENCIES=TRUE -DCMAKE_CXX_FLAGS="-std=c++11" .. make -j$(nproc --all) packages_dependencies echo " Checks finished" for pkg_path in $CGAL_ROOT/* do pkg=$(basename $pkg_path) if [ -f "$pkg_path/package_info/$pkg/dependencies" ]; then - PKG_DIFF=$(diff -N -w "$pkg_path/package_info/$pkg/dependencies.old" "$pkg_path/package_info/$pkg/dependencies" || true) + PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies.old" "$pkg_path/package_info/$pkg/dependencies" || true) if [ -n "$PKG_DIFF" ]; then HAS_DIFF=TRUE - echo "Differences in $pkg: $PKG_DIFF" - else - echo "No differencies in $pkg dependencies." + echo "Differences in $pkg: $PKG_DIFF are new and not committed." + fi + PKG_DIFF=$(grep -Fxv -f "$pkg_path/package_info/$pkg/dependencies" "$pkg_path/package_info/$pkg/dependencies.old" || true) + if [ -n "$PKG_DIFF" ]; then + HAS_DIFF=TRUE + echo "Differences in $pkg: $PKG_DIFF have disappeared." fi if [ -f $pkg_path/package_info/$pkg/dependencies.old ]; then rm $pkg_path/package_info/$pkg/dependencies.old @@ -51,7 +54,8 @@ echo " Checks finished" cd $CGAL_ROOT rm -r dep_check_build if [ -n "$HAS_DIFF" ]; then - echo " You should run cmake with options CGAL_ENABLE_CHECK_HEADERS and CGAL_COPY_DEPENDENCIES ON, make the target packages_dependencies and commit the new dependencies files." + echo " You can run cmake with options CGAL_ENABLE_CHECK_HEADERS and CGAL_COPY_DEPENDENCIES ON, make the target packages_dependencies and commit the new dependencies files," + echo " or simply manually edit the problematic files." exit 1 else echo "The dependencies are up to date." From 0bf465dee602f88e22bd71025fe32c18b412609d Mon Sep 17 00:00:00 2001 From: Laurent Rineau Date: Tue, 15 May 2018 15:32:04 +0000 Subject: [PATCH 28/31] Fix indentation --- GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h b/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h index 4a88e63a14d..dad56939a61 100644 --- a/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h +++ b/GraphicsView/demo/Triangulation_2/TriangulationCircumcircle.h @@ -90,11 +90,11 @@ TriangulationCircumcircle::mouseMoveEvent(QGraphicsSceneMouseEvent *event) { if(dt->dimension() != 2){ circle->hide(); - hint = Vertex_handle(); + hint = Vertex_handle(); return; } if (hint == Vertex_handle()){ - hint = dt->infinite_vertex(); + hint = dt->infinite_vertex(); } typename T::Point p = typename T::Point(event->scenePos().x(), event->scenePos().y()); fh = dt->locate(p, hint->face()); From e24a089ae8250086afdca526c01f02523360743d Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 2 May 2018 15:19:45 +0100 Subject: [PATCH 29/31] The class std::iterator got deprecated. It only served to define some types --- .../CGAL/internal/boost/array_binary_tree.hpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp index ed646779099..dc9e8a6b4e5 100644 --- a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp +++ b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp @@ -20,7 +20,7 @@ #ifndef CGAL_INTERNAL_ARRAY_BINARY_TREE_HPP #define CGAL_INTERNAL_ARRAY_BINARY_TREE_HPP -#include +#include #include #include @@ -52,12 +52,12 @@ public: struct children_type { struct iterator - : ::boost::iterator { // replace with iterator_adaptor implementation -JGS + typedef std::forward_iterator_tag Category; + typedef ArrayBinaryTreeNode value_type; + typedef size_type difference_type + typedef ArrayBinaryTreeNode* Pointer; + typedef ArrayBinaryTreeNode& Reference; inline iterator() : i(0), n(0) { } inline iterator(const iterator& x) : r(x.r), i(x.i), n(x.n), id(x.id) { } From f777fc291652645d130ac17d5fe5341c38f74b0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Wed, 16 May 2018 08:51:03 +0200 Subject: [PATCH 30/31] add missing semicolon --- STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp index dc9e8a6b4e5..e2d5ebd2f66 100644 --- a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp +++ b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp @@ -55,7 +55,7 @@ public: { // replace with iterator_adaptor implementation -JGS typedef std::forward_iterator_tag Category; typedef ArrayBinaryTreeNode value_type; - typedef size_type difference_type + typedef size_type difference_type; typedef ArrayBinaryTreeNode* Pointer; typedef ArrayBinaryTreeNode& Reference; From 4ceeb920207faeb0488c85edaa01e368f04dd9e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Wed, 16 May 2018 08:51:03 +0200 Subject: [PATCH 31/31] add missing semicolon --- STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp index dc9e8a6b4e5..e2d5ebd2f66 100644 --- a/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp +++ b/STL_Extension/include/CGAL/internal/boost/array_binary_tree.hpp @@ -55,7 +55,7 @@ public: { // replace with iterator_adaptor implementation -JGS typedef std::forward_iterator_tag Category; typedef ArrayBinaryTreeNode value_type; - typedef size_type difference_type + typedef size_type difference_type; typedef ArrayBinaryTreeNode* Pointer; typedef ArrayBinaryTreeNode& Reference;