songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the previous fix in is_facet_convex()

This commit is contained in:
Guillaume Damiand 2021-09-17 10:47:26 +02:00
parent 9ab7e9df33
commit 0700e56168
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
GraphicsView/include/CGAL/Buffer_for_vao.h
View File

@ -521,17 +521,15 @@ public:
local_orientation=Local_kernel::Orientation_3()(V1, V2, normal) ;
if(local_orientation!=CGAL::ZERO && local_orientation!=orientation)
{ return false; }
// V1 and V2 are collinear
if(local_orientation==CGAL::ZERO )
if(local_orientation!=CGAL::ZERO)
{
//TS and TU are opposite
if(CGAL::scalar_product(V1,V2) >=0)
return true;
//TS and TU have the same direction.
else
return false;
if(local_orientation!=orientation)
{ return false; }
}
else
{
if(CGAL::scalar_product(V1,V2)<0)
{ return false; } //TS and TU are opposite
}
}
return true;