songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More fixes for normal computations of meshes with degenerate faces

This commit is contained in:
Mael Rouxel-Labbé 2020-02-04 15:56:55 +01:00
parent 55afaf713f
commit 0c05fc6e80
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/compute_normal.h
View File

@ -265,6 +265,8 @@ bool does_enclose_other_normals(const std::size_t i, const std::size_t j, const
continue;
const Vector_ref nl = get(face_normals, incident_faces[l]);
if(nl == CGAL::NULL_VECTOR)
continue;
// this is a bound on how much the scalar product between (v1,v2) and (v1, v3) can change
// when the angle changes theta_bound := 0.01°
@ -432,9 +434,8 @@ compute_most_visible_normal_3_points(const std::vector<typename boost::graph_tra
const Vector_ref nj = get(face_normals, incident_faces[j]);
const Vector_ref nk = get(face_normals, incident_faces[k]);
CGAL_warning(ni != CGAL::NULL_VECTOR);
CGAL_warning(nj != CGAL::NULL_VECTOR);
CGAL_warning(nk != CGAL::NULL_VECTOR);
if(ni == CGAL::NULL_VECTOR || nj == CGAL::NULL_VECTOR || nk == CGAL::NULL_VECTOR)
continue;
Vector_3 nb = compute_normals_bisector(ni, nj, nk, traits);
if(traits.equal_3_object()(nb, CGAL::NULL_VECTOR))