From 0e1a871b0cc2bed3d3727c8605d6f62a96432b04 Mon Sep 17 00:00:00 2001
From: Marc Glisse <marc.glisse@inria.fr>
Date: Thu, 9 Apr 2020 23:50:26 +0200
Subject: [PATCH] Add comments

---
 NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h | 4 ++++
 NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h        | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h b/NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h
index 1a94550d342..1b2a80a2a69 100644
--- a/NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h
+++ b/NewKernel_d/include/CGAL/NewKernel_d/Cartesian_filter_K.h
@@ -50,6 +50,10 @@ template<> struct Functors_without_division<Dimension_tag<6> > {
   typedef typeset<Orientation_of_points_tag, Side_of_oriented_sphere_tag> type;
 };
 
+// FIXME:
+// - Is_exact (which should be renamed to Uses_no_arithmetic) predicates should not be filtered
+// - Functors_without_division should be defined near/in the actual functors
+
 template < typename Base_, typename AK_, typename EK_, typename Pred_list = typeset_all >
 struct Cartesian_filter_K : public Base_
 {
diff --git a/NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h b/NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h
index 758a6260f13..051bff5a942 100644
--- a/NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h
+++ b/NewKernel_d/include/CGAL/NewKernel_d/LA_eigen/LA.h
@@ -122,6 +122,9 @@ template<class NT_,class Dim_,class Max_dim_=Dim_> struct LA_eigen {
                 return m.determinant();
         }
 
+	// TODO: https://gitlab.com/libeigen/eigen/-/issues/1782
+	// Implement a version of (sign_of_)determinant that works
+	// without (inexact) division in any dimension
         template<class Mat_> static NT determinant(Mat_ const&m,bool=false){
           switch(m.rows()){
             //case 0: