songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
This commit is contained in:
Andreas Fabri 2023-08-24 09:59:12 +02:00 committed by GitHub
parent 2d9186184d
commit 0efc2cdc03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Nef_2/include/CGAL/Nef_2/PM_overlayer.h
View File

@ -646,8 +646,9 @@ avoid the simplification for edge pairs referenced by |e|.}*/
for (f = this->faces_begin(); f != fend; f=fn) { for (f = this->faces_begin(); f != fend; f=fn) {
fn=f; ++fn; fn=f; ++fn;
Union_find_handle pit = Pitem[f]; Union_find_handle pit = Pitem[f];
if (unify_faces.find(pit) != pit) {
Union_find_handle root = unify_faces.find(pit); Union_find_handle root = unify_faces.find(pit);
if (root != pit) {
for(Isolated_vertex_iterator ivi = isolated_vertices_begin(f); ivi != isolated_vertices_end(f); ++ivi){ for(Isolated_vertex_iterator ivi = isolated_vertices_begin(f); ivi != isolated_vertices_end(f); ++ivi){
ivi->set_face(*root); ivi->set_face(*root);
link_as_isolated_vertex(*root,ivi); link_as_isolated_vertex(*root,ivi);

2
Nef_2/include/CGAL/Nef_2/Segment_overlay_traits.h
View File

@ -167,7 +167,7 @@ public:
Point_2 target(const ISegment& is) const Point_2 target(const ISegment& is) const
{ return K.target(is->first()); } { return K.target(is->first()); }
ITERATOR original(xonst ISegment& s) const ITERATOR original(const ISegment& s) const
{ return s->second(); } { return s->second(); }
int orientation(ST_item sit, const Point_2& p) const int orientation(ST_item sit, const Point_2& p) const