songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix ambiguous comparisons error with C++20 

```
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/afftrafo-test.cpp:136:31: error: use of overloaded operator '==' is ambiguous (with operand types 'VectorHd<CGAL::VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::RT, CGAL::VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::LA>' (aka 'VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >') and 'Vector_d<CGAL::Homogeneous_d<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > > >')
    CGAL_TEST(v.transform(at9)==3*v){}
              ~~~~~~~~~~~~~~~~^ ~~~
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/include/CGAL/test_macros.h:10:28: note: expanded from macro 'CGAL_TEST'
                           ^
/mnt/testsuite/include/CGAL/Kernel_d/VectorHd.h:350:6: note: candidate function
bool operator==(const VectorHd<RT,LA>& w) const
     ^
/mnt/testsuite/include/CGAL/Kernel_d/Vector_d.h:90:8: note: candidate function (with reversed parameter order)
  bool operator==(const Self& w) const
       ^
```

```
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/afftrafo-test.cpp:141:33: error: use of overloaded operator '==' is ambiguous (with operand types 'DirectionHd<CGAL::DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::RT, CGAL::DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::LA>' (aka 'DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >') and 'Direction' (aka 'Direction_d<Homogeneous_d<__gmp_expr<__mpz_struct [1], __mpz_struct [1]> > >'))
    CGAL_TEST(dir.transform(at9)==dir){}
              ~~~~~~~~~~~~~~~~~~^ ~~~
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/include/CGAL/test_macros.h:10:28: note: expanded from macro 'CGAL_TEST'
                           ^
/mnt/testsuite/include/CGAL/Kernel_d/DirectionHd.h:181:6: note: candidate function
bool operator==(const DirectionHd<RT,LA>& w) const
     ^
/mnt/testsuite/include/CGAL/Kernel_d/Direction_d.h:61:8: note: candidate function (with reversed parameter order)
  bool operator==(const Self& w) const
       ^
```
This commit is contained in:
Laurent Rineau 2020-06-10 17:57:54 +02:00
parent 6747341f66
commit 127d76c370
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Kernel_d/include/CGAL/Kernel_d/Direction_d.h
View File

@ -62,6 +62,10 @@ class Direction_d : public pR::Direction_d_base
{ return Base::operator==(w); } { return Base::operator==(w); }
bool operator!=(const Self& w) const bool operator!=(const Self& w) const
{ return Base::operator!=(w); } { return Base::operator!=(w); }
bool operator==(const Base& w) const
{ return Base::operator==(w); }
bool operator!=(const Base& w) const
{ return Base::operator!=(w); }
}; };
} //namespace CGAL } //namespace CGAL

4
Kernel_d/include/CGAL/Kernel_d/Vector_d.h
View File

@ -91,6 +91,10 @@ class Vector_d : public pR::Vector_d_base
{ return Base::operator==(w); } { return Base::operator==(w); }
bool operator!=(const Self& w) const bool operator!=(const Self& w) const
{ return Base::operator!=(w); } { return Base::operator!=(w); }
bool operator==(const Base& w) const
{ return Base::operator==(w); }
bool operator!=(const Base& w) const
{ return Base::operator!=(w); }
}; };