From eebc635da07492454a7ac7416f9f488c9cc166fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Mon, 11 Sep 2023 09:38:27 +0200 Subject: [PATCH 1/3] fix concept doc --- .../Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h index c30553b5519..92689531537 100644 --- a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h +++ b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h @@ -69,10 +69,10 @@ public: /// \param tm_e mesh containing `h_e` void intersection_point_detected(std::size_t i_id, int sdim, - halfedge_descriptor h_f, halfedge_descriptor h_e, - const Triangle_mesh& tm_f, + halfedge_descriptor h_f, const Triangle_mesh& tm_e, + const Triangle_mesh& tm_f, bool is_target_coplanar, bool is_source_coplanar); From 2905e381177c52c3a86a0b9abe1bbb729fb92fc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Mon, 11 Sep 2023 11:28:22 +0200 Subject: [PATCH 2/3] update parameter orders --- .../Concepts/PMPCorefinementVisitor.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h index 92689531537..a95d31f2e19 100644 --- a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h +++ b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h @@ -58,15 +58,15 @@ public: /// \param i_id the id of the intersection point, starting at 0. Ids are consecutive. /// \param sdim indicates the dimension of the simplex part of the face that is intersected by the edge /// (0 for a vertex, 1 for an edge, 2 for the interior of the face) + /// \param tm_e mesh containing `h_e` + /// \param tm_f mesh containing `h_f` + /// \param h_e a halfedge from `tm_e` /// \param h_f a halfedge from `tm_f` indicating the simplex intersected: /// if `sdim==0` the target of `h_f` is the intersection point, /// if `sdim==1` the edge of `h_f` contains the intersection point in its interior, /// if `sdim==2` the face of `h_f` contains the intersection point in its interior. - /// \param h_e a halfedge from `tm_e` /// \param is_target_coplanar `true` iff the target of `h_e` is the intersection point /// \param is_source_coplanar `true` iff the source of `h_e` is the intersection point - /// \param tm_f mesh containing `h_f` - /// \param tm_e mesh containing `h_e` void intersection_point_detected(std::size_t i_id, int sdim, halfedge_descriptor h_e, From 4f29b83610445a0497fcd65258ee9205be112679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Loriot?= Date: Mon, 11 Sep 2023 15:14:51 +0200 Subject: [PATCH 3/3] really fix the order --- .../Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h index a95d31f2e19..80b1e64f6ed 100644 --- a/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h +++ b/Polygon_mesh_processing/doc/Polygon_mesh_processing/Concepts/PMPCorefinementVisitor.h @@ -58,13 +58,13 @@ public: /// \param i_id the id of the intersection point, starting at 0. Ids are consecutive. /// \param sdim indicates the dimension of the simplex part of the face that is intersected by the edge /// (0 for a vertex, 1 for an edge, 2 for the interior of the face) - /// \param tm_e mesh containing `h_e` - /// \param tm_f mesh containing `h_f` /// \param h_e a halfedge from `tm_e` /// \param h_f a halfedge from `tm_f` indicating the simplex intersected: /// if `sdim==0` the target of `h_f` is the intersection point, /// if `sdim==1` the edge of `h_f` contains the intersection point in its interior, /// if `sdim==2` the face of `h_f` contains the intersection point in its interior. + /// \param tm_e mesh containing `h_e` + /// \param tm_f mesh containing `h_f` /// \param is_target_coplanar `true` iff the target of `h_e` is the intersection point /// \param is_source_coplanar `true` iff the source of `h_e` is the intersection point void intersection_point_detected(std::size_t i_id,