songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
This commit is contained in:
lvalque 2025-07-28 16:44:29 +02:00 committed by GitHub
parent 20d1c99950
commit 1b830ee23c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/compute_normal.h
View File

@ -447,7 +447,7 @@ compute_vertex_normal_most_visible_min_circle(typename boost::graph_traits<Polyg
} }
} }
// At each step, we get a vertex outside of the current circum circle to define a larger circum circle // At each step, we get a vertex outside of the current circumcircle to define a larger circumcircle
while(true) while(true)
{ {
Vector_3 center; Vector_3 center;
@ -480,7 +480,7 @@ compute_vertex_normal_most_visible_min_circle(typename boost::graph_traits<Polyg
circum_points.push_back(f_out); circum_points.push_back(f_out);
} else { } else {
if(is_negative(sp_3(center, no))) if(is_negative(sp_3(center, no)))
return NULL_VECTOR; // The circle will become bigger than an hemisphere, no normal visible by all return NULL_VECTOR; // The circle will become bigger than a hemisphere, no normal visible by all
const Vector_ref nk = get(face_normals, circum_points[2]); const Vector_ref nk = get(face_normals, circum_points[2]);