From 237940883dace92301bbc1a5361c40b228988447 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 9 Jan 2024 10:59:23 +0100 Subject: [PATCH] Add remarks --- Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp | 2 +- Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h | 2 +- .../CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h | 3 +++ .../CGAL/Isosurfacing_3/internal/marching_cubes_functors.h | 3 ++- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp b/Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp index ff2486c881b..81ec444c642 100644 --- a/Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp +++ b/Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp @@ -79,7 +79,7 @@ int main(int, char**) CGAL::Isosurfacing::marching_cubes(domain, isovalue, points_mc, polygons_mc); CGAL::Isosurfacing::dual_contouring(domain, isovalue, points_dc, polygons_dc); - // save output indexed meshes to files, in the OFF format + // save output indexed meshes to files, in the OFF format @fixme these are not meshes... CGAL::IO::write_OFF("output_mc.off", points_mc, polygons_mc); CGAL::IO::write_OFF("output_dc.off", points_dc, polygons_dc); diff --git a/Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h b/Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h index f3c5b886467..9f841f427fb 100644 --- a/Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h +++ b/Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h @@ -320,7 +320,7 @@ to_image() const { // select number type WORD_KIND wordkind; - if(std::is_floating_point::value) + if(std::is_floating_point::value) // @fixme seems meaningless given that vx vy vz are doubles wordkind = WK_FLOAT; else wordkind = WK_FIXED; diff --git a/Isosurfacing_3/include/CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h b/Isosurfacing_3/include/CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h index 1365b889dd4..c3ce1134046 100644 --- a/Isosurfacing_3/include/CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h +++ b/Isosurfacing_3/include/CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h @@ -124,6 +124,9 @@ create_implicit_Cartesian_grid_domain(const Bbox_3& bbox, return Domain{ topo, geom, func, grad, gt }; } +// @todo add an undocumented convenience overload with Vector_3 to match CGAL kernels +// without having to provide the kernel in the call like f(...) + } // namespace Isosurfacing } // namespace CGAL diff --git a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/marching_cubes_functors.h b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/marching_cubes_functors.h index 232464a923e..7090315ddfb 100644 --- a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/marching_cubes_functors.h +++ b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/marching_cubes_functors.h @@ -181,7 +181,8 @@ void mc_construct_triangles(const int i_case, if(Cube_table::triangle_cases[t_index] == -1) break; - const int eg0 = Cube_table::triangle_cases[t_index + 0]; // TODO: move more of this stuff into the table + // @todo move more of this stuff into the table + const int eg0 = Cube_table::triangle_cases[t_index + 0]; const int eg1 = Cube_table::triangle_cases[t_index + 1]; const int eg2 = Cube_table::triangle_cases[t_index + 2];