songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add remarks

This commit is contained in:
Mael Rouxel-Labbé 2024-01-09 10:59:23 +01:00
parent 7b18855e0c
commit 237940883d
4 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Isosurfacing_3/examples/Isosurfacing_3/all_Cartesian_cube.cpp
View File

@ -79,7 +79,7 @@ int main(int, char**)
CGAL::Isosurfacing::marching_cubes(domain, isovalue, points_mc, polygons_mc); CGAL::Isosurfacing::marching_cubes(domain, isovalue, points_mc, polygons_mc);
CGAL::Isosurfacing::dual_contouring(domain, isovalue, points_dc, polygons_dc); CGAL::Isosurfacing::dual_contouring(domain, isovalue, points_dc, polygons_dc);
// save output indexed meshes to files, in the OFF format // save output indexed meshes to files, in the OFF format @fixme these are not meshes...
CGAL::IO::write_OFF("output_mc.off", points_mc, polygons_mc); CGAL::IO::write_OFF("output_mc.off", points_mc, polygons_mc);
CGAL::IO::write_OFF("output_dc.off", points_dc, polygons_dc); CGAL::IO::write_OFF("output_dc.off", points_dc, polygons_dc);

2
Isosurfacing_3/include/CGAL/Isosurfacing_3/Cartesian_grid_3.h
View File

@ -320,7 +320,7 @@ to_image() const
{ {
// select number type // select number type
WORD_KIND wordkind; WORD_KIND wordkind;
if(std::is_floating_point<FT>::value) if(std::is_floating_point<FT>::value) // @fixme seems meaningless given that vx vy vz are doubles
wordkind = WK_FLOAT; wordkind = WK_FLOAT;
else else
wordkind = WK_FIXED; wordkind = WK_FIXED;

3
Isosurfacing_3/include/CGAL/Isosurfacing_3/Implicit_Cartesian_grid_domain_3.h
View File

@ -124,6 +124,9 @@ create_implicit_Cartesian_grid_domain(const Bbox_3& bbox,
return Domain{ topo, geom, func, grad, gt }; return Domain{ topo, geom, func, grad, gt };
} }
// @todo add an undocumented convenience overload with Vector_3<GeomTraits> to match CGAL kernels
// without having to provide the kernel in the call like f<kernel>(...)
} // namespace Isosurfacing } // namespace Isosurfacing
} // namespace CGAL } // namespace CGAL

3
Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/marching_cubes_functors.h
View File

@ -181,7 +181,8 @@ void mc_construct_triangles(const int i_case,
if(Cube_table::triangle_cases[t_index] == -1) if(Cube_table::triangle_cases[t_index] == -1)
break; break;
const int eg0 = Cube_table::triangle_cases[t_index + 0]; // TODO: move more of this stuff into the table // @todo move more of this stuff into the table
const int eg0 = Cube_table::triangle_cases[t_index + 0];
const int eg1 = Cube_table::triangle_cases[t_index + 1]; const int eg1 = Cube_table::triangle_cases[t_index + 1];
const int eg2 = Cube_table::triangle_cases[t_index + 2]; const int eg2 = Cube_table::triangle_cases[t_index + 2];