diff --git a/Frechet_distance/include/CGAL/Frechet_distance/internal/filter.h b/Frechet_distance/include/CGAL/Frechet_distance/internal/filter.h index d730856366a..081784a188f 100644 --- a/Frechet_distance/include/CGAL/Frechet_distance/internal/filter.h +++ b/Frechet_distance/include/CGAL/Frechet_distance/internal/filter.h @@ -105,11 +105,11 @@ bool Filter::isFree(Point const& fixed, Curve const& var_curve, PointID start { auto mid = (start + end + 1) / 2; auto max = (CGAL::max)(var_curve.curve_length(start + 1, mid), - var_curve.curve_length(mid, end)); + var_curve.curve_length(mid, end)); if (certainly(distance > max)){ auto mid_dist = Curve::distance(fixed, var_curve[mid]); - if(certainly(mid_dist <= CGAL::abs(distance - max))) { // Uncertain (A) // TODO: can we remove abs? + if(certainly(mid_dist <= distance - max)) { // Uncertain (A) return true; } } diff --git a/Frechet_distance/include/CGAL/Frechet_distance/internal/frechet_light.h b/Frechet_distance/include/CGAL/Frechet_distance/internal/frechet_light.h index d4ca39311f0..acf25c52efb 100644 --- a/Frechet_distance/include/CGAL/Frechet_distance/internal/frechet_light.h +++ b/Frechet_distance/include/CGAL/Frechet_distance/internal/frechet_light.h @@ -387,7 +387,7 @@ inline bool FrechetLight::updateQSimpleInterval(QSimpleInterval& qsimple, // heuristic tests avoiding sqrts if (certainly(distance > maxdist)){ - auto comp_dist1 = CGAL::abs(distance - maxdist); // TODO remove abs? + auto comp_dist1 = distance - maxdist; if (certainly(mid_dist <= comp_dist1)) { // Uncertain (A) qsimple.setFreeInterval(min, max); // full qsimple.validate(); @@ -395,7 +395,7 @@ inline bool FrechetLight::updateQSimpleInterval(QSimpleInterval& qsimple, return true; } } - auto comp_dist2 = CGAL::abs(distance + maxdist); // TODO remove abs? + auto comp_dist2 = distance + maxdist; if (certainly(mid_dist > comp_dist2)) { // Uncertain (A) qsimple.setFreeInterval(max, min); // empty qsimple.validate(); @@ -471,13 +471,13 @@ inline void FrechetLight::continueQSimpleSearch(QSimpleInterval& qsimple, auto mid_dist = Curve::distance(fixed_point, curve[mid]); if (current_free && certainly(distance > maxdist) && // Uncertain (A) - certainly(mid_dist <= CGAL::abs(distance - maxdist))) { // TODO remove abs? + certainly(mid_dist <= distance - maxdist)) { cur += stepsize; stepsize *= 2; continue; } - if (!current_free && certainly(mid_dist > CGAL::abs(distance + maxdist))) { // Uncertain (A) // TODO remove abs? + if (!current_free && certainly(mid_dist > distance + maxdist)) { // Uncertain (A) cur += stepsize; stepsize *= 2; @@ -1082,7 +1082,7 @@ CPoint FrechetLight::getLastReachablePoint(Curve const& curve1, PointID i, auto mid_dist = Curve::distance(point, curve2[mid]); - if(certainly(distance > maxdist) && (certainly(mid_dist <= CGAL::abs(distance - maxdist)))) { // Uncertain (A) // TODO remove abs? + if(certainly(distance > maxdist) && (certainly(mid_dist <= distance - maxdist))) { // Uncertain (A) cur += stepsize; stepsize *= 2; }