From 343dad840a84caa1d5532b75bb914ecfb01ebe5c Mon Sep 17 00:00:00 2001 From: Laurent Rineau Date: Mon, 20 Jul 2020 17:07:07 +0200 Subject: [PATCH] -DCGAL_USE_VTK should be only for io_image_plugin Otherwise, I had a ld.so error with a few Mesh_3 plugins that do not use VTK. --- Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt b/Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt index 2e819fa7124..c979f027c84 100644 --- a/Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt +++ b/Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt @@ -22,9 +22,7 @@ if (VTK_FOUND) if(TARGET VTK::IOImage) set(VTK_LIBRARIES VTK::IOImage) endif() - if(VTK_LIBRARIES) - add_definitions(-DCGAL_USE_VTK) - else() + if(NOT VTK_LIBRARIES) message(STATUS "NOTICE : the DICOM files (.dcm) need VTK libraries to be open and will not be able to.") endif() else() @@ -39,6 +37,9 @@ if(Boost_FILESYSTEM_FOUND) qt5_wrap_ui( imgUI_FILES Image_res_dialog.ui raw_image.ui) polyhedron_demo_plugin(io_image_plugin Io_image_plugin Volume_plane_intersection.cpp Raw_image_dialog.cpp ${imgUI_FILES} ${VOLUME_MOC_OUTFILES} KEYWORDS IO Mesh_3) target_link_libraries(io_image_plugin PUBLIC scene_image_item ${VTK_LIBRARIES} CGAL::CGAL_ImageIO) + if(VTK_LIBRARIES) + target_compile_definitions(io_image_plugin PRIVATE CGAL_USE_VTK) + endif() if(TARGET Boost::filesystem) target_link_libraries(io_image_plugin PUBLIC Boost::filesystem Boost::system) else()