diff --git a/GraphicsView/include/CGAL/Buffer_for_vao.h b/GraphicsView/include/CGAL/Buffer_for_vao.h index 6cb6bfa5b86..1845c75c77c 100644 --- a/GraphicsView/include/CGAL/Buffer_for_vao.h +++ b/GraphicsView/include/CGAL/Buffer_for_vao.h @@ -71,7 +71,7 @@ namespace internal static typename Local_kernel::Point_3 get_local_point(const typename K::Point_2& p) { CGAL::Cartesian_converter converter; - return Local_point(converter(p.x()), 0, converter(p.y())); + return typename Local_kernel::Point_3(converter(p.x()), converter(p.y()), 0); } static typename Local_kernel::Point_3 get_local_point(const typename K::Weighted_point_2& p) { @@ -91,7 +91,7 @@ namespace internal static typename Local_kernel::Vector_3 get_local_vector(const typename K::Vector_2& v) { CGAL::Cartesian_converter converter; - return Local_vector(converter(v.x()), 0, converter(v.y())); + return typename Local_kernel::Vector_3(converter(v.x()), converter(v.y()), 0); } static typename Local_kernel::Vector_3 get_local_vector(const typename K::Vector_3& v) { @@ -105,15 +105,15 @@ namespace internal struct Geom_utils { static typename Local_kernel::Point_3 get_local_point(const typename Local_kernel::Point_2& p) - { return typename Local_kernel::Point_3(p.x(), 0, p.y()); } + { return typename Local_kernel::Point_3(p.x(), p.y(), 0); } static typename Local_kernel::Point_3 get_local_point(const typename Local_kernel::Weighted_point_2& p) - { return typename Local_kernel::Point_3(p.point().x(), 0, p.point().y());} + { return typename Local_kernel::Point_3(p.point().x(), p.point().y(), 0);} static const typename Local_kernel::Point_3 & get_local_point(const typename Local_kernel::Point_3& p) { return p; } static typename Local_kernel::Point_3 get_local_point(const typename Local_kernel::Weighted_point_3& p) { return typename Local_kernel::Point_3(p);} static typename Local_kernel::Vector_3 get_local_vector(const typename Local_kernel::Vector_2& v) - { return typename Local_kernel::Vector_3(v.x(), 0, v.y()); } + { return typename Local_kernel::Vector_3(v.x(), v.y(), 0); } static const typename Local_kernel::Vector_3& get_local_vector(const typename Local_kernel::Vector_3& v) { return v; } }; @@ -484,23 +484,23 @@ protected: if (m_indices_of_points_of_face.size()>0) { add_indexed_point(m_indices_of_points_of_face[i]); - } + } else { add_point(m_points_of_face[i]); // Add the position of the point - if (m_started_face_is_colored) - { add_color(m_color_of_face); } // Add the color - add_flat_normal(normal); // Add the flat normal - // Its smooth normal (if given by the user) - if (m_vertex_normals_for_face.size()>0) - { // Here we have 3 vertex normals; we can use Gouraud - add_gouraud_normal(m_vertex_normals_for_face[i]); - } - else - { // Here user does not provide all vertex normals: we use face normal istead - // and thus we will not be able to use Gouraud - add_gouraud_normal(normal); - } + if (m_started_face_is_colored) + { add_color(m_color_of_face); } // Add the color + add_flat_normal(normal); // Add the flat normal + // Its smooth normal (if given by the user) + if (m_vertex_normals_for_face.size()>0) + { // Here we have 3 vertex normals; we can use Gouraud + add_gouraud_normal(m_vertex_normals_for_face[i]); + } + else + { // Here user does not provide all vertex normals: we use face normal istead + // and thus we will not be able to use Gouraud + add_gouraud_normal(normal); + } } } } diff --git a/Linear_cell_complex/include/CGAL/draw_linear_cell_complex.h b/Linear_cell_complex/include/CGAL/draw_linear_cell_complex.h index 0a411c66a42..d53dd49e23d 100644 --- a/Linear_cell_complex/include/CGAL/draw_linear_cell_complex.h +++ b/Linear_cell_complex/include/CGAL/draw_linear_cell_complex.h @@ -168,7 +168,7 @@ public: bool anofaces=false, const DrawingFunctorLCC& drawing_functor=DrawingFunctorLCC()) : // First draw: vertices; edges, faces; multi-color; inverse normal - Base(parent, title, true, true, true, false, true), + Base(parent, title, true, true, true, false, false), lcc(alcc), m_nofaces(anofaces), m_random_face_color(false),