songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6510 from oesi82/PCA-Linear_least_squares_fitting_3_NaN-GF 

Fixed degenerated case of plane fitting to a linear set of points.
This commit is contained in:
Laurent Rineau 2022-05-06 14:22:00 +02:00
parent 5994eb48b5 39df59901b
commit 3c2fa8f493
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Principal_component_analysis/include/CGAL/PCA_util.h
View File

@ -723,7 +723,11 @@ fitting_plane_3(typename DiagonalizeTraits::Covariance_matrix& covariance, // co
eigen_vectors[1],
eigen_vectors[2]);
plane = Plane(c,normal);
return FT(1) - eigen_values[0] / eigen_values[1];
if (eigen_values[1] == 0)
return FT(0); // line case
else
return FT(1) - eigen_values[0] / eigen_values[1]; // regular case
} // end regular case
}