Examples are now all ok.

Linear_cell_complex/examples/Linear_cell_complex/CMakeLists.txt

@@ -37,13 +37,14 @@ if ( CGAL_FOUND )
 
 # If you want to visualize a linear cell complex, there are 2 viewers 
 # based on qt and vtk. Just uncomment the corresponding line
-  include("CMakeLCCViewerQt.inc")
+  #  include("CMakeLCCViewerQt.inc")
   #  include("CMakeLCCViewerVtk.inc")
 
   add_executable(linear_cell_complex_3_triangulation
                           linear_cell_complex_3_triangulation.cpp)
   target_link_libraries(linear_cell_complex_3_triangulation ${CGAL_LIBRARIES}
-                                   ${CGAL_3RD_PARTY_LIBRARIES} ${MAP_VIEWER_LIBRARIES})
+                                   ${CGAL_3RD_PARTY_LIBRARIES}
+                                   ${MAP_VIEWER_LIBRARIES})
 
   add_executable(voronoi_2 voronoi_2.cpp)
   target_link_libraries(voronoi_2 ${CGAL_LIBRARIES} ${CGAL_3RD_PARTY_LIBRARIES}

Linear_cell_complex/examples/Linear_cell_complex/data/small_points_3

@@ -2,5 +2,14 @@
 1 0 0
 0 1 0
 0 0 1
+0 0 0
+-1 0 0
+0 -1 0
+0 0 -1
+-2 -2 -2
 2 2 2
 -1 0 1
+-3 0 5
+3 0 5
+-2.2 2 4.8
+2.2 2 4.8

Linear_cell_complex/examples/Linear_cell_complex/voronoi_2.cpp

@@ -34,6 +34,12 @@
 #endif
 #endif
 
+/* // If you want to use exact constructions.
+#include <CGAL/Exact_predicates_exact_constructions_kernel.h>
+typedef CGAL::Linear_cell_complex<2,2,
+  CGAL::Linear_cell_complex_traits<2, CGAL::Exact_predicates_exact_constructions_kernel> > LCC_2;
+*/
+
 typedef CGAL::Linear_cell_complex<2> LCC_2;
 typedef LCC_2::Dart_handle           Dart_handle;
 typedef LCC_2::Point                 Point;
@@ -117,8 +123,7 @@ void set_geometry_of_dual(LCC& alcc, TR& tr,
       alcc.set_vertex_attribute
         (it->second,alcc.create_vertex_attribute(tr.circumcenter(it->first)));
     else
-      alcc.set_vertex_attribute
-        (it->second,alcc.create_vertex_attribute());
+      alcc.set_vertex_attribute(it->second,alcc.create_vertex_attribute());
   }
 }
 
@@ -160,19 +165,14 @@ int main(int narg, char** argv)
   std::map<typename Triangulation::Face_handle,
            typename LCC_2::Dart_handle > face_to_dart;
   
-  Dart_handle dh=
-    CGAL::import_from_triangulation_2<LCC_2, Triangulation>(lcc, T,
-                                                            &face_to_dart);
+  Dart_handle dh=CGAL::import_from_triangulation_2<LCC_2, Triangulation>
+    (lcc, T, &face_to_dart);
   CGAL_assertion(lcc.is_without_boundary());
 
   std::cout<<"Delaunay triangulation :"<<std::endl<<"  ";
   lcc.display_characteristics(std::cout) << ", valid=" 
                                          << lcc.is_valid() << std::endl;
 
-#ifdef CGAL_LCC_USE_VIEWER
-  display_lcc(lcc);
-#endif // CGAL_LCC_USE_VIEWER
-
   // 3) Compute the dual lcc.
   LCC_2 dual_lcc;
   Dart_handle ddh=lcc.dual(dual_lcc, dh);

Linear_cell_complex/examples/Linear_cell_complex/voronoi_3.cpp

@@ -34,6 +34,12 @@
 #endif
 #endif
 
+/* // If you want to use exact constructions.
+#include <CGAL/Exact_predicates_exact_constructions_kernel.h>
+typedef CGAL::Linear_cell_complex<3,3,
+  CGAL::Linear_cell_complex_traits<3, CGAL::Exact_predicates_exact_constructions_kernel> > LCC_3;
+*/
+
 typedef CGAL::Linear_cell_complex<3> LCC_3;
 typedef LCC_3::Dart_handle           Dart_handle;
 typedef LCC_3::Point                 Point;
@@ -43,16 +49,17 @@ typedef CGAL::Delaunay_triangulation_3<LCC_3::Traits> Triangulation;
 // Function used to display the voronoi diagram.
 void display_voronoi(LCC_3& alcc, Dart_handle adart)
 {
-  // We remove all the volumes containing one dart of the infinite volume
+  // We remove the infinite volume plus all the volumes adjacent to it.
+  // Indeed, we cannot view these volumes since they do not have
+  // a "correct geometry". 
   std::stack<Dart_handle> toremove;
   int mark_toremove=alcc.get_new_mark();
 
-  // We cannot view the infinite volume since it does not have
-  // a correct geometry. For that we have to remove the infinite volume.
+  // adart belongs to the infinite volume.
   toremove.push(adart);
   CGAL::mark_cell<LCC_3,3>(alcc, adart, mark_toremove);
  
-  // Plus all the volumes sharing a face with it.
+  // Now we get all the volumes adjacent to the infinite volume.
   for (LCC_3::Dart_of_cell_range<3>::iterator
          it=alcc.darts_of_cell<3>(adart).begin(),
          itend=alcc.darts_of_cell<3>(adart).end(); it!=itend; ++it)
@@ -61,7 +68,7 @@ void display_voronoi(LCC_3& alcc, Dart_handle adart)
     {
       CGAL::mark_cell<LCC_3,3>(alcc, it->beta(3), mark_toremove);
       toremove.push(it->beta(3));
-    }    
+    }
   }
   
   while( !toremove.empty() )
@@ -70,11 +77,57 @@ void display_voronoi(LCC_3& alcc, Dart_handle adart)
     toremove.pop();
   }
 
+  CGAL_assertion(alcc.is_without_boundary(1) && alcc.is_without_boundary(2));
+  
+  std::cout<<"Voronoi subdvision, only finite volumes:"<<std::endl<<"  ";
+  alcc.display_characteristics(std::cout) << ", valid=" 
+                                          << alcc.is_valid()
+                                          << std::endl;
+
 #ifdef CGAL_LCC_USE_VIEWER
   display_lcc(alcc);
 #endif // CGAL_LCC_USE_VIEWER
 }
 
+template<typename LCC, typename TR>
+void transform_dart_to_their_dual(LCC& alcc, LCC& adual,
+                                  std::map<typename TR::Cell_handle,
+                                           typename LCC::Dart_handle>& assoc)
+{
+  typename LCC::Dart_range::iterator it1=alcc.darts().begin();
+  typename LCC::Dart_range::iterator it2=adual.darts().begin();
+
+  std::map<typename LCC::Dart_handle, typename LCC::Dart_handle> dual;
+  
+  for ( ; it1!=alcc.darts().end(); ++it1, ++it2 )
+  {
+    dual[it1]=it2;
+  }
+
+  for ( typename std::map<typename TR::Cell_handle, typename LCC::Dart_handle>
+          ::iterator it=assoc.begin(), itend=assoc.end(); it!=itend; ++it)
+  {
+    assoc[it->first]=dual[it->second];
+  }
+}
+
+template<typename LCC, typename TR>
+void set_geometry_of_dual(LCC& alcc, TR& tr,
+                          std::map<typename TR::Cell_handle,
+                                   typename LCC::Dart_handle>& assoc)
+{
+  for ( typename std::map<typename TR::Cell_handle, typename LCC::Dart_handle>
+          ::iterator it=assoc.begin(), itend=assoc.end(); it!=itend; ++it)
+  {
+    if ( !tr.is_infinite(it->first) )
+      alcc.set_vertex_attribute
+        (it->second,alcc.create_vertex_attribute(tr.dual(it->first)));
+    else
+      alcc.set_vertex_attribute(it->second,alcc.create_vertex_attribute());
+  }
+}
+
+
 int main(int narg, char** argv)
 {
   if (narg>1 && (!strcmp(argv[1],"-h") || !strcmp(argv[1],"-?")) )
@@ -110,8 +163,11 @@ int main(int narg, char** argv)
  
   // 2) Convert the triangulation into a 3D lcc.
   LCC_3 lcc;
-  Dart_handle dh=
-    CGAL::import_from_triangulation_3<LCC_3, Triangulation>(lcc, T);
+  std::map<typename Triangulation::Cell_handle,
+           typename LCC_3::Dart_handle > vol_to_dart;
+
+  Dart_handle dh=CGAL::import_from_triangulation_3<LCC_3, Triangulation>
+    (lcc, T, &vol_to_dart);
 
   std::cout<<"Delaunay triangulation :"<<std::endl<<"  ";
   lcc.display_characteristics(std::cout) << ", valid=" 
@@ -121,8 +177,15 @@ int main(int narg, char** argv)
   LCC_3 dual_lcc;
   Dart_handle ddh=lcc.dual(dual_lcc, dh);
   // Here, dual_lcc is the 3D Voronoi diagram.
+  CGAL_assertion(dual_lcc.is_without_boundary());
+
+  // 4) We update the geometry of dual_lcc by using the std::map
+  //    face_to_dart.
+  transform_dart_to_their_dual<LCC_3,Triangulation>
+    (lcc, dual_lcc, vol_to_dart);
+  set_geometry_of_dual<LCC_3,Triangulation>(dual_lcc, T, vol_to_dart);
   
-  // 4) Display the dual_lcc characteristics.
+  // 5) Display the dual_lcc characteristics.
   std::cout<<"Voronoi subdvision :"<<std::endl<<"  ";
   dual_lcc.display_characteristics(std::cout) << ", valid=" 
                                               << dual_lcc.is_valid()