From 4c27d08372eb4390c0e13d30a91dfab0d0f44568 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Wed, 22 Oct 2025 11:17:31 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mael --- Stream_support/include/CGAL/IO/GOCAD.h | 2 +- Stream_support/include/CGAL/IO/Generic_writer.h | 2 +- Stream_support/include/CGAL/IO/OBJ.h | 2 +- Stream_support/include/CGAL/IO/OFF.h | 2 +- Stream_support/include/CGAL/IO/STL.h | 6 +++--- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Stream_support/include/CGAL/IO/GOCAD.h b/Stream_support/include/CGAL/IO/GOCAD.h index c63b7c9b6ab..c95706547cc 100644 --- a/Stream_support/include/CGAL/IO/GOCAD.h +++ b/Stream_support/include/CGAL/IO/GOCAD.h @@ -339,7 +339,7 @@ bool write_GOCAD(std::ostream& os, * \cgalParamNBegin{point_map} * \cgalParamDescription{a property map associating points to the elements of the range `points`} * \cgalParamType{a model of `ReadablePropertyMap` whose key type is the value type - * of the iterator of `PointRange` and value type is a model of the concept`Point_3`} + * of the iterator of `PointRange` and value type is a model of the concept `Kernel::Point_3`} * \cgalParamDefault{`CGAL::Identity_property_map::value_type>`} * \cgalParamNEnd * \cgalParamNBegin{stream_precision} diff --git a/Stream_support/include/CGAL/IO/Generic_writer.h b/Stream_support/include/CGAL/IO/Generic_writer.h index f56d5b7dc7c..afd0b8be5d6 100644 --- a/Stream_support/include/CGAL/IO/Generic_writer.h +++ b/Stream_support/include/CGAL/IO/Generic_writer.h @@ -59,7 +59,7 @@ public: m_writer.write_header(m_os, points.size(), 0, polygons.size()); for(std::size_t i=0, end=points.size(); i::value_type>`} * \cgalParamNEnd * \cgalParamNBegin{stream_precision} diff --git a/Stream_support/include/CGAL/IO/OFF.h b/Stream_support/include/CGAL/IO/OFF.h index da1e2598a54..d2b1b5c9934 100644 --- a/Stream_support/include/CGAL/IO/OFF.h +++ b/Stream_support/include/CGAL/IO/OFF.h @@ -317,7 +317,7 @@ bool write_OFF(std::ostream& os, * \cgalParamNBegin{point_map} * \cgalParamDescription{a property map associating points to the elements of the range `points`} * \cgalParamType{a model of `ReadablePropertyMap` whose key type is the value type - * of the iterator of `PointRange` and value type is a model of the concept `Point_3`} + * of the iterator of `PointRange` and value type is a model of the concept `Kernel::Point_3`} * \cgalParamDefault{`CGAL::Identity_property_map::value_type>`} * \cgalParamNEnd * \cgalParamNBegin{stream_precision} diff --git a/Stream_support/include/CGAL/IO/STL.h b/Stream_support/include/CGAL/IO/STL.h index 043ef0c5a3d..1c7470e1598 100644 --- a/Stream_support/include/CGAL/IO/STL.h +++ b/Stream_support/include/CGAL/IO/STL.h @@ -325,9 +325,9 @@ bool write_STL(std::ostream& os, const Point& q = get(point_map, points[face[1]]); const Point& r = get(point_map, points[face[2]]); - Point_3 pp = conv(p); - Point_3 qq = conv(q); - Point_3 rr = conv(r); + decltype(auto) pp = conv(p); + decltype(auto) qq = conv(q); + decltype(auto) rr = conv(r); const Vector_3 nn = collinear(pp,qq,rr) ? Vector_3(static_cast(1),static_cast(0),static_cast(0)) : unit_normal(pp,qq,rr);