mirror of https://github.com/CGAL/cgal
various changes just after discussions in Graz
This commit is contained in:
parent
1795cde28e
commit
5446f4643d
|
|
@ -7,6 +7,9 @@ kernel with all the algebraic functionalities on bivariate polynomials
|
|||
required for the manipulation of arcs of algebraic curves of general degree
|
||||
$d$ in $\R^2$.
|
||||
|
||||
\ccRefines
|
||||
\ccc{AlgebraicKernel_d_1}
|
||||
|
||||
\ccTypes
|
||||
|
||||
A model of \ccc{AlgebraicKernel_d_2} is supposed to provide
|
||||
|
|
|
|||
|
|
@ -9,7 +9,7 @@ A model of \ccRefName\ represents a real root of a univariat polynomial
|
|||
|
||||
\ccNestedType{Boundary}
|
||||
{ A \ccc{RealEmbeddable} number type that is dense in \R. \\
|
||||
It is required to be \ccc{ImplicitInteroperable} with \ccc{AlgebraicKernel_d_1::FT}, where \ccc{AlgebraicKernel_d_1::FT} is the coercion type.
|
||||
It is required to be \ccc{ImplicitInteroperable} with \ccc{AlgebraicKernel_d_1::Coefficient}, where \ccc{AlgebraicKernel_d_1::Coefficient} is the coercion type.
|
||||
}
|
||||
|
||||
\ccOperations
|
||||
|
|
|
|||
|
|
@ -6,6 +6,10 @@
|
|||
\item Missing Doc for IsSquareFree\_2, IsCoprime\_2, MakeSquareFree\_2,
|
||||
MakeCoprime\_2, Solve\_2
|
||||
\item revise doc of AK\_1
|
||||
\item Move methods from AlgebraicReal\_1 to a traits class and make
|
||||
this traits class concept a refinement of RealEmbedableTraits.
|
||||
\item Move methods from AlgebraicReal\_2 to a traits class.
|
||||
\item AlgebraicReal\_2 - Add GetX() and GetY() functors.
|
||||
\end{itemize}
|
||||
|
||||
\subsection{done}
|
||||
|
|
@ -22,17 +26,13 @@
|
|||
\section{Questions}
|
||||
\subsection{Open}
|
||||
\begin{itemize}
|
||||
\item Does AK\_1 provide an FT ?
|
||||
\item IT ? and if is IT == Coefficient ?
|
||||
\item Is Derivative and XCriticalPoints/YCriticalPoints redundant?\\
|
||||
Michael: I think we should keep it, since it is more abstract than $solve(derivative(p),p)$. This would again move the {\em AlgebraicKernel} towards a more abstract layer.
|
||||
\item AlgebraicReal\_2 - Do we provide .x() and .y() method??\\
|
||||
Michael: Since in this case two y values at differnt x values must be comparable as well, it seems hard (costly) to provide this.
|
||||
I don't like this idea.
|
||||
|
||||
\item Names of CurveAnalysis\_2, CurveVerticalLine\_1 and
|
||||
CurvePairAnalysis\_2, CurvePairVerticalLine\_1?
|
||||
\item Use "int" at all places, or stick to distinction of unsigned int + int?
|
||||
\item Names of CurveVerticalLine\_1 and CurvePairVerticalLine\_1?
|
||||
\item Use "int" at all places, or stick to distinction of \texttt{unsigned
|
||||
int} + \texttt{int}?
|
||||
(Menelaos: if the semantics of \texttt{unsigned int} is to enumerate
|
||||
objects in a sequence, then a new nested type \texttt{size\_type}
|
||||
can be introduced and used as the \texttt{return\_type} or
|
||||
\texttt{argument\_type}).
|
||||
\item others?
|
||||
\end{itemize}
|
||||
|
||||
|
|
@ -48,5 +48,12 @@
|
|||
\item SquareFreeFactorization is not returning an additional constant
|
||||
factor. This prevents us from providing an extra interface for
|
||||
algebraic coefficients.
|
||||
\end{itemize}
|
||||
\item Is Derivative and XCriticalPoints/YCriticalPoints are not
|
||||
redundant. We decided to kepp them both because it is possible that
|
||||
XCriticalPoints/YCriticalPoints use a different methodology, other
|
||||
than residing to the Derivative functor. As Michael pointed out:
|
||||
\emph{``I think we should keep it, since it is more abstract than
|
||||
$solve(derivative(p),p)$. This would again move the {\em
|
||||
AlgebraicKernel} towards a more abstract layer.''}
|
||||
\item AlgebraicReal\_2 - Do we provide .x() and .y() method??\\\end{itemize}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue