songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

checking sign before using squared cos angle

This commit is contained in:
Sven Oesau 2025-07-23 10:37:04 +02:00
parent c3e3c0eb31
commit 547e2a3c0f
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Shape_detection/include/CGAL/Shape_detection/Region_growing/Point_set/Least_squares_line_fit_region.h
View File

@ -241,6 +241,10 @@ namespace Point_set {
const FT cos_value = const FT cos_value =
m_scalar_product_2(query_normal, m_normal_of_best_fit); m_scalar_product_2(query_normal, m_normal_of_best_fit);
if (cos_value < 0)
return false;
const FT squared_cos_value = cos_value * cos_value; const FT squared_cos_value = cos_value * cos_value;
FT squared_cos_value_threshold = FT squared_cos_value_threshold =

4
Shape_detection/include/CGAL/Shape_detection/Region_growing/Segment_set/Least_squares_line_fit_region.h
View File

@ -244,6 +244,10 @@ namespace Segment_set {
const FT cos_value = const FT cos_value =
m_scalar_product(query_direction, m_direction_of_best_fit); m_scalar_product(query_direction, m_direction_of_best_fit);
if (cos_value < 0)
return false;
const FT squared_cos_value = cos_value * cos_value; const FT squared_cos_value = cos_value * cos_value;
FT squared_cos_value_threshold = FT squared_cos_value_threshold =