songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added a comment in LSCM about the wrong use of Eigen_type 

Replacing OpenNL with Eigen in the LSCM parameterizer is todo
This commit is contained in:
Mael Rouxel-Labbé 2016-11-25 12:13:18 +01:00
parent 58b863101b
commit 5720e83c32
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Surface_mesh_parameterization/include/CGAL/Surface_mesh_parameterization/LSCM_parameterizer_3.h
View File

@ -88,6 +88,13 @@ template
= Two_vertices_parameterizer_3<TriangleMesh>,
class SparseLinearAlgebraTraits_d
#if defined(CGAL_EIGEN3_ENABLED) || defined(DOXYGEN_RUNNING)
// WARNING: at the moment, the choice of SparseLinearAlgebraTraits_d is completely
// ignored and `OpenNL::LinearSolver<Sparse_LA>` is used anyway. If you were to
// use Eigen solver traits, there is a bug in the line below, though.
// Indeed `Eigen_sparse_symmetric_matrix<double>::EigenType` is a NON SYMMETRIC
// Eigen sparse matrix, and thus Sparse_LA::Matrix will be a NON SYMMETRIC matrix
// and the whole symmetry aspect will be completely ignored.
// @fixme
= Eigen_solver_traits<Eigen::SimplicialLDLT<Eigen_sparse_symmetric_matrix<double>::EigenType> >
#else
= OpenNL::SymmetricLinearSolverTraits<typename TriangleMesh::NT>