songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

KSR: Ghost edge insertion assert (#8978) 

## Summary of Changes

Relaxed the assertion condition in ghost edge insertion. Non-manifold
vertices are actually not an issue.

## Release Management

* Affected package(s): Kinetic_surface_reconstruction
* Issue(s) solved (if any): fix #8946
This commit is contained in:
Sebastien Loriot 2025-07-15 20:18:03 +02:00 committed by GitHub
parent a4654b07c4 11b5da660a
commit 59c253af78
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Kinetic_surface_reconstruction/include/CGAL/Kinetic_surface_reconstruction_3.h
View File

@ -946,7 +946,7 @@ private:
KSP_3::internal::dump_polygons(polygon_regions, "faces_by_region-" + std::to_string(lambda) + ".ply"); KSP_3::internal::dump_polygons(polygon_regions, "faces_by_region-" + std::to_string(lambda) + ".ply");
std::vector<std::vector<std::size_t> > borders; std::vector<std::vector<std::size_t> > borders;
std::vector<std::vector<std::size_t> > borders_per_region; std::vector<std::vector<std::size_t> > borders_per_region(region);
collect_connected_border(borders, region_index, borders_per_region); collect_connected_border(borders, region_index, borders_per_region);
for (std::size_t i = 0; i < region; i++) { for (std::size_t i = 0; i < region; i++) {
@ -1363,7 +1363,7 @@ private:
for (std::size_t j = 0; j < polygons[i].size(); j++) { for (std::size_t j = 0; j < polygons[i].size(); j++) {
vertices.push_back(cdt.insert(pl.to_2d(m_lcc.point(m_lcc.template dart_of_attribute<0>(polygons[i][j]))))); vertices.push_back(cdt.insert(pl.to_2d(m_lcc.point(m_lcc.template dart_of_attribute<0>(polygons[i][j])))));
CGAL_assertion_code(auto it =) va2vh.insert(std::make_pair(polygons[i][j], vertices.size() - 1)); CGAL_assertion_code(auto it =) va2vh.insert(std::make_pair(polygons[i][j], vertices.size() - 1));
CGAL_assertion(it.second); CGAL_assertion(it.second || it.first->first == polygons[i][j]);
vertices.back()->info().i = i; vertices.back()->info().i = i;
vertices.back()->info().j = j; vertices.back()->info().j = j;
@ -1573,8 +1573,6 @@ private:
//borders contains Attribute<0> handles casted to std::size_t //borders contains Attribute<0> handles casted to std::size_t
std::vector<bool> processed(m_lcc.upper_bound_on_dart_ids(), false); std::vector<bool> processed(m_lcc.upper_bound_on_dart_ids(), false);
borders_per_region.resize(region_index.size());
for (std::size_t i = 0;i<region_index.size();i++) { for (std::size_t i = 0;i<region_index.size();i++) {
if (region_index[i] == -1) if (region_index[i] == -1)
continue; continue;