songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix the fatal bug of the convolution calculation part of the Minkowski sum (#8573) 

## Summary of Changes
Modify the convolution calculation part of the Minkowski sum. In the
'elimination of antennas' phase, before I fix it, only the antennas of
the first segment were eliminated, skipping the possible subsequent
antennas. For more details, please refer to the explanation in the
issue. I modified it so that if a new antenna is merged, the newly
merged antenna is used as `curr` for the next iteration; otherwise,
`after_next` is used as `curr`.


## Release Management
* Affected package(s): Minkowski_sum_2
* Issue(s) solved: fix #8551
This commit is contained in:
Sebastien Loriot 2024-11-14 14:16:07 +01:00 committed by GitHub
parent 6cb87048bd 78c0810181
commit 5aec09a838
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Minkowski_sum_2/include/CGAL/Minkowski_sum_2/Minkowski_sum_conv_2.h
View File

@ -611,7 +611,7 @@ private:
res = f_compare_xy(curr_pt, next_pt);
if (res != EQUAL) {
cycle.insert(curr,
after_next = cycle.insert(curr,
Labeled_segment_2(Segment_2(curr_pt, next_pt),
X_curve_label((res == SMALLER),
cycle_id,