diff --git a/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/orientation.h b/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/orientation.h index 486ba067c67..a4467b3d8b8 100644 --- a/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/orientation.h +++ b/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/orientation.h @@ -70,18 +70,18 @@ namespace internal{ const PolygonMesh& pmesh, const NamedParameters& np) { - using parameters::choose_parameter; + using parameters::get_parameter; CGAL_assertion(halfedge(v_max, pmesh)!=boost::graph_traits::null_halfedge()); //VertexPointMap typedef typename GetVertexPointMap::const_type VPMap; - VPMap vpmap = choose_parameter(get_parameter(np, internal_np::vertex_point), + VPMap vpmap = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::vertex_point), get_const_property_map(vertex_point, pmesh)); //Kernel typedef typename GetGeomTraits::type GT; - GT gt = choose_parameter(get_parameter(np, internal_np::geom_traits), GT()); + GT gt = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::geom_traits), GT()); //among the incoming edges of `v_max`, find one edge `e` with the minimal slope typedef typename boost::graph_traits::halfedge_descriptor halfedge_descriptor; @@ -183,16 +183,16 @@ bool is_outward_oriented(const PolygonMesh& pmesh, if (faces(pmesh).first == faces(pmesh).second) return true; - using parameters::choose_parameter; + using parameters::get_parameter; //VertexPointMap typedef typename GetVertexPointMap::const_type VPMap; - VPMap vpmap = choose_parameter(get_parameter(np, internal_np::vertex_point), + VPMap vpmap = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::vertex_point), get_const_property_map(vertex_point, pmesh)); //Kernel typedef typename GetGeomTraits::type GT; - GT gt = choose_parameter(get_parameter(np, internal_np::geom_traits), GT()); + GT gt = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::geom_traits), GT()); //find the vertex with maximal z coordinate internal::Compare_vertex_points_z_3 less_z(vpmap, gt); @@ -483,16 +483,15 @@ void orient(TriangleMesh& tm, const NamedParameters& np) CGAL_assertion(is_valid_polygon_mesh(tm)); CGAL_assertion(is_closed(tm)); - using parameters::choose_parameter; using parameters::get_parameter; - bool orient_outward = choose_parameter( + bool orient_outward = CGAL::parameters::choose_parameter( get_parameter(np, internal_np::outward_orientation),true); - Vpm vpm = choose_parameter(get_parameter(np, internal_np::vertex_point), + Vpm vpm = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::vertex_point), get_const_property_map(boost::vertex_point, tm)); - Fid_map fid_map = choose_parameter(get_parameter(np, internal_np::face_index), + Fid_map fid_map = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::face_index), get_const_property_map(boost::face_index, tm)); std::vector face_cc(num_faces(tm), std::size_t(-1)); @@ -590,16 +589,16 @@ void orient_to_bound_a_volume(TriangleMesh& tm, if (!is_closed(tm)) return; if (!is_triangle_mesh(tm)) return; - using parameters::choose_parameter; + using parameters::get_parameter; - bool orient_outward = choose_parameter( + bool orient_outward = CGAL::parameters::choose_parameter( get_parameter(np, internal_np::outward_orientation),true); - Vpm vpm = choose_parameter(get_parameter(np, internal_np::vertex_point), + Vpm vpm = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::vertex_point), get_const_property_map(boost::vertex_point, tm)); - Fid_map fid_map = choose_parameter(get_parameter(np, internal_np::face_index), + Fid_map fid_map = CGAL::parameters::choose_parameter(get_parameter(np, internal_np::face_index), get_const_property_map(boost::face_index, tm)); std::vector face_cc(num_faces(tm), std::size_t(-1)); diff --git a/Triangulation_2/test/Triangulation_2/issue_4010.cpp b/Triangulation_2/test/Triangulation_2/issue_4010.cpp index db08a006081..f24babc4d8a 100644 --- a/Triangulation_2/test/Triangulation_2/issue_4010.cpp +++ b/Triangulation_2/test/Triangulation_2/issue_4010.cpp @@ -27,7 +27,7 @@ int main() cdtp.remove_constraint(handle1,handle3); - auto lastConstraintId = cdtp.insert_constraint(handle1,handle3); + Constraint_id lastConstraintId = cdtp.insert_constraint(handle1,handle3); if (lastConstraintId == Constraint_id()){ std::cout << "problem" << std::endl;