From 7485e3887b51df76108171373d0515b82dcfa586 Mon Sep 17 00:00:00 2001 From: Andreas Fabri Date: Thu, 22 Apr 2021 13:43:07 +0100 Subject: [PATCH] Improve documentation and the example that performs affine transformations --- Kernel_23/doc/Kernel_23/CGAL/Aff_transformation_3.h | 4 ++-- Nef_3/doc/Nef_3/Nef_3.txt | 1 - Nef_3/examples/Nef_3/transformation.cpp | 11 ++--------- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/Kernel_23/doc/Kernel_23/CGAL/Aff_transformation_3.h b/Kernel_23/doc/Kernel_23/CGAL/Aff_transformation_3.h index 6181b0bc6d5..1b5781e7f89 100644 --- a/Kernel_23/doc/Kernel_23/CGAL/Aff_transformation_3.h +++ b/Kernel_23/doc/Kernel_23/CGAL/Aff_transformation_3.h @@ -200,12 +200,12 @@ returns `true`, if the transformation is reflecting. bool is_odd() const; /*! -returns `true`, if the transformation type is the specialized scaling. +returns `true`, if the object was constructed using the tag `CGAL::Scaling`, or as a composition of such objects. */ bool is_scaling() const; /*! -returns `true`, if the transformation type is the specialized translation. +returns `true`, if the object was constructed using the tag `CGAL::Translation`, or as a composition of such objects. */ bool is_translation() const; diff --git a/Nef_3/doc/Nef_3/Nef_3.txt b/Nef_3/doc/Nef_3/Nef_3.txt index b4fee9d321a..636630cd569 100644 --- a/Nef_3/doc/Nef_3/Nef_3.txt +++ b/Nef_3/doc/Nef_3/Nef_3.txt @@ -579,4 +579,3 @@ the `Object_handle` can represent a `Vertex_const_handle`, a */ } /* namespace CGAL */ - diff --git a/Nef_3/examples/Nef_3/transformation.cpp b/Nef_3/examples/Nef_3/transformation.cpp index 74d1108888f..0e79e62e832 100644 --- a/Nef_3/examples/Nef_3/transformation.cpp +++ b/Nef_3/examples/Nef_3/transformation.cpp @@ -4,11 +4,7 @@ #include -//instead of -//typedef CGAL::Extended_homogeneous Kernel; -// workaround for VC++ -struct Kernel : public CGAL::Extended_homogeneous {}; - +typedef CGAL::Extended_homogeneous Kernel; typedef CGAL::Nef_polyhedron_3 Nef_polyhedron; typedef Nef_polyhedron::Plane_3 Plane_3; typedef Nef_polyhedron::Vector_3 Vector_3; @@ -22,10 +18,7 @@ int main() { 0,0,-1, 0,1,0, 1); - Aff_transformation_3 scale(3,0,0, - 0,3,0, - 0,0,3, - 2); + Aff_transformation_3 scale(CGAL::SCALING, 3, 2); N.transform(transl); CGAL_assertion(N == Nef_polyhedron(Plane_3(0,1,0,-7)));