songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bug-fix: use longest border polyline to compute the normal 

fix bug of Thingi 1439534
This commit is contained in:
Laurent Rineau 2025-10-13 17:18:56 +02:00
parent b11e42c4a7
commit 75c2ac5a68
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
View File

@ -725,6 +725,29 @@ public:
std::make_move_iterator(other_polylines.end())); std::make_move_iterator(other_polylines.end()));
} }
if(polylines.size() > 1) {
double max_sq_length = 0;
auto longest_it = polylines.begin();
for(auto it = polylines.begin(); it != polylines.end(); ++it) {
auto& polyline = *it;
using CGAL::Bbox_3;
Bbox_3 bb;
for(auto v : polyline) {
bb = bb + Bbox_3(get(mesh_vp_map, v).bbox());
}
double sq_diagonal_length = CGAL::square(bb.xmax() - bb.xmin()) +
CGAL::square(bb.ymax() - bb.ymin()) +
CGAL::square(bb.zmax() - bb.zmin());
if(sq_diagonal_length > max_sq_length) {
max_sq_length = sq_diagonal_length;
longest_it = it;
}
}
if(longest_it != polylines.begin()) {
std::iter_swap(longest_it, polylines.begin());
}
}
std::optional<int> face_index; std::optional<int> face_index;
for(auto& polyline : polylines) { for(auto& polyline : polylines) {
CGAL_assertion(!polyline.empty() && polyline.front() == polyline.back()); CGAL_assertion(!polyline.empty() && polyline.front() == polyline.back());

23
Constrained_triangulation_3/test/Constrained_triangulation_3/cdt_3_from_off.cpp
View File

@ -721,6 +721,29 @@ int go(Mesh mesh, CDT_options options) {
std::make_move_iterator(other_polylines.end())); std::make_move_iterator(other_polylines.end()));
} }
if(polylines.size() > 1) {
double max_sq_length = 0;
auto longest_it = polylines.begin();
for(auto it = polylines.begin(); it != polylines.end(); ++it) {
auto& polyline = *it;
using CGAL::Bbox_3;
Bbox_3 bb;
for(auto v : polyline) {
bb = bb + Bbox_3(get(mesh_vp_map, v).bbox());
}
double sq_diagonal_length = CGAL::square(bb.xmax() - bb.xmin()) +
CGAL::square(bb.ymax() - bb.ymin()) +
CGAL::square(bb.zmax() - bb.zmin());
if(sq_diagonal_length > max_sq_length) {
max_sq_length = sq_diagonal_length;
longest_it = it;
}
}
if(longest_it != polylines.begin()) {
std::iter_swap(longest_it, polylines.begin());
}
}
std::optional<int> face_index; std::optional<int> face_index;
for(auto& polyline : polylines) { for(auto& polyline : polylines) {
CGAL_assertion(!polyline.empty() && polyline.front() == polyline.back()); CGAL_assertion(!polyline.empty() && polyline.front() == polyline.back());