songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a warning when `FT` is `int` 

https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-63/Arrangement_on_surface_2_Examples/TestReport_Blake_Windows_MSVCPreview-Release-64bits.gz
This commit is contained in:
Laurent Rineau 2018-12-07 12:01:39 +01:00
parent db9204aced
commit 8634fc94e9
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Cartesian_kernel/include/CGAL/constructions/kernel_ftC2.h
View File

@ -28,6 +28,7 @@
#include <CGAL/determinant.h> #include <CGAL/determinant.h>
#include <CGAL/number_utils.h> #include <CGAL/number_utils.h>
#include <boost/type_traits/is_integral.hpp>
namespace CGAL { namespace CGAL {
@ -284,6 +285,15 @@ line_get_pointC2(const FT &a, const FT &b, const FT &c, int i,
{ {
if (CGAL_NTS is_zero(b)) if (CGAL_NTS is_zero(b))
{ {
// Laurent Rineau, 2018/12/07: I had this CGAL_assume to calm
// down a warning from MSVC 2017:
// > include\cgal\constructions\kernel_ftc2.h(287) :
// > warning C4723: potential divide by 0
// The test `!boost::is_integral<FT>::value` is there to avoid
// that `a != 0` is tested on anything but integral types, for
// performance reasons.
CGAL_assume(!boost::is_integral<FT>::value || a != FT(0));
x = -c/a; x = -c/a;
y = 1 - i * a; y = 1 - i * a;
} }