songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace the comparison of 2 lines with a more efficient one (just for this specific case where direction doesnt matter).

This commit is contained in:
Pedro Machado Manhaes de Castro 2006-06-05 09:25:23 +00:00
parent 4a1272c522
commit 871a04e88c
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Curved_kernel/include/CGAL/Curved_kernel/internal_functions_on_line_arc_2.h
View File

@ -296,10 +296,16 @@ namespace CircularFunctors {
typedef typename CK::Point_2 Point_2;
typedef typename CK::Root_of_2 Root_of_2;
typedef typename CK::Root_for_circles_2_2 Root_for_circles_2_2;
// We can make the comparison below clevered
if ((a1.supporting_line() == a2.supporting_line())
|| (a1.supporting_line() == a2.supporting_line().opposite())) {
if(compare_xy(a1.left(),a2.left()) < 0){
const typename CK::RT &a1c = a1.supporting_line().a();
const typename CK::RT &b1c = a1.supporting_line().b();
const typename CK::RT &c1c = a1.supporting_line().c();
const typename CK::RT &a2c = a2.supporting_line().a();
const typename CK::RT &b2c = a2.supporting_line().b();
const typename CK::RT &c2c = a2.supporting_line().c();
if((a1c*b2c == a2c*b1c) &&
(a1c*c2c == a2c*c1c) &&
(b1c*c2c == b2c*c1c)) {
if(compare_xy(a1.left(),a2.left()) < 0) {
int comparison = compare_xy(a2.left(),a1.right());
if(comparison < 0){
if(compare_xy(a1.right(),a2.right()) <= 0){