From 5a5539b45de17910ad2bb9cfcc632664fa863d5a Mon Sep 17 00:00:00 2001 From: Marc Glisse Date: Mon, 22 May 2023 22:04:29 +0200 Subject: [PATCH 1/2] Inconsistent return type in Kernel_d concepts All implementations seem to agree. --- .../doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h | 2 +- .../doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h | 2 +- Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h index b8339c7df6a..187619df4ad 100644 --- a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h +++ b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_affine_hull_d.h @@ -19,7 +19,7 @@ affine hull of the points in `A = tuple [first,last)`. \tparam ForwardIterator has `Kernel_d::Point_d` as value type. */ -template Bounded_side +template bool operator()( ForwardIterator first, ForwardIterator last, const Kernel_d::Point_d& p); diff --git a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h index 42d043b52c0..4f2ff72d7d0 100644 --- a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h +++ b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_linear_hull_d.h @@ -18,7 +18,7 @@ linear hull of the vectors in `A = tuple [first,last)`. \pre The objects are of the same dimension. \tparam ForwardIterator has `Kernel_d::Vector_d` as value type. */ -template Bounded_side +template bool operator()( ForwardIterator first, ForwardIterator last, const Kernel_d::Vector_d& v); diff --git a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h index 41af6fd8d9e..b2cea6611a4 100644 --- a/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h +++ b/Kernel_d/doc/Kernel_d/Concepts/Kernel--Contained_in_simplex_d.h @@ -19,7 +19,7 @@ simplex of the points in `A = tuple [first,last)`. \pre The objects in \f$ A\f$ are of the same dimension and affinely independent. \tparam ForwardIterator has `Kernel_d::Point_d` as value type. */ -template Bounded_side +template bool operator()( ForwardIterator first, ForwardIterator last, const Kernel_d::Point_d& p); From f1b07a31e3c2812bb3a530f1e068c8c5f070fc13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 23 May 2023 19:00:52 +0200 Subject: [PATCH 2/2] Add missing include --- GraphicsView/include/CGAL/Qt/vec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/GraphicsView/include/CGAL/Qt/vec.h b/GraphicsView/include/CGAL/Qt/vec.h index 903db34f0f9..9e29db285e5 100644 --- a/GraphicsView/include/CGAL/Qt/vec.h +++ b/GraphicsView/include/CGAL/Qt/vec.h @@ -13,6 +13,8 @@ #ifndef QGLVIEWER_VEC_H #define QGLVIEWER_VEC_H +#include + #include #include