From 913f8796c9eb02432584c083c42c9c19644e2d2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Fri, 23 Feb 2024 16:17:23 +0100 Subject: [PATCH] Follow the OG paper's prescription of the SVD threshold It makes it less likely to have wild stuff happens on spiky geometry --- .../CGAL/Isosurfacing_3/internal/dual_contouring_functors.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h index e9c93f3953a..099e01552d4 100644 --- a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h +++ b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h @@ -167,8 +167,9 @@ bool cell_position_QEM(const typename Domain::Cell_descriptor& c, Eigen::JacobiSVD svd(A, Eigen::ComputeThinU | Eigen::ComputeThinV); - // set threshold as in Peter Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models" - svd.setThreshold(1e-3); + // Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models": 1e-3 + // Ju's paper, "Dual Contouring of Hermite Data": 1e-1 + svd.setThreshold(1e-1); Eigen_vector_3 x_hat; x_hat << x_coord(com), y_coord(com), z_coord(com);