songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Misc minor fixes

This commit is contained in:
Mael Rouxel-Labbé 2023-03-20 13:55:33 +01:00
parent 08c7c44b45
commit a741ec07cd
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Polygon_extrusion/include/CGAL/extrude_skeleton.h
View File

@ -81,7 +81,9 @@ enum class Slope
VERTICAL
};
// @todo Maybe this postprocessing is not really necessary?...
// @todo Maybe this postprocessing is not really necessary? Do users really care if the point
// is not perfectly above the input contour edge (it generally cannot be anyway if the kernel is not exact except for some
// specific cases)?
#define CGAL_SLS_SNAP_TO_VERTICAL_SLABS
#ifdef CGAL_SLS_SNAP_TO_VERTICAL_SLABS
@ -116,7 +118,7 @@ snap_point_to_contour_halfedge_plane(const typename GeomTraits::Point_2& op,
else
{
// Project orthogonally onto the halfedge
// @todo the best projection could be along the direction of the other offset edge sharing this point?
// @todo should the projection be along the direction of the other offset edge sharing this point?
Segment_2 s { sv->point(), tv->point() };
boost::optional<Line_2> line = CGAL_SS_i::compute_normalized_line_coeffC2(s);
CGAL_assertion(bool(line)); // otherwise the skeleton would have failed already

6
Straight_skeleton_2/doc/Straight_skeleton_2/Straight_skeleton_2.txt
View File

@ -416,7 +416,7 @@ or even cross each other.
Thus, it is necessary to use a kernel with exact constructions if offset polygons must be simple,
yet computing a straight skeleton using that kernel is very slow, much more than computing the offset
polygons. To help with this, it is possible to construct the straight skeleton using the recommended
kernel Exact_predicates_inexact_constructions_kernel`, then convert the skeleton to a different kernel
kernel `Exact_predicates_inexact_constructions_kernel`, then convert the skeleton to a different kernel
via the function `CGAL::convert_straight_skeleton_2()` and input the converted skeleton to the offsetting functions.
All the offsetting functions that take polygons as input (and create the straight skeleton
@ -434,7 +434,7 @@ The following example shows how to extrude the weighted skeleton of a polygon wi
\cgalExample{Straight_skeleton_2/extrude_skeleton.cpp}
\subsection Straight_skeleton_2LowlevelAPI Low level API
\subsection Straight_skeleton_2LowlevelAPI Low Level API
All the high level functions described above are just wrappers around the low-level API described here.
This low level API is richer and provides options and configurations not covered by any of those functions.
@ -503,7 +503,7 @@ Therefore, the `Exact_predicates_inexact_constructions_kernel` should be used.
Fernando Cacciola created the first version of this package, providing unweighted straight skeletons
and polygon offsetting.
Sébastien Loriot and Mael Rouxel-Labbé implemented further robustification techniues,
Sébastien Loriot and Mael Rouxel-Labbé implemented further robustification techniques,
as well as weighted straight skeletons, and skeleton extrusion.
*/