From a8cd0902a8fa26b536971436ab385e971a2df0c1 Mon Sep 17 00:00:00 2001 From: Sven Oesau Date: Thu, 17 Apr 2025 15:46:21 +0200 Subject: [PATCH] integrating reviews --- Mesh_3/include/CGAL/Labeled_mesh_domain_3.h | 6 +----- .../Poisson_surface_reconstruction_3.txt | 4 ++-- .../include/CGAL/Poisson_mesh_domain_3.h | 10 ++++------ 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/Mesh_3/include/CGAL/Labeled_mesh_domain_3.h b/Mesh_3/include/CGAL/Labeled_mesh_domain_3.h index 5ad1060e6c5..a9284359d4a 100644 --- a/Mesh_3/include/CGAL/Labeled_mesh_domain_3.h +++ b/Mesh_3/include/CGAL/Labeled_mesh_domain_3.h @@ -1131,11 +1131,7 @@ public: /* * Returns a point in the intersection of the primitive `type` * with some boundary surface. - * `Type1` is either `Segment_3`, `Ray_3` or `Line_3`. - * The integer `dimension` is set to the dimension of the lowest - * dimensional face in the input complex containing the returned point, and - * `index` is set to the index to be stored at a mesh vertex lying - * on this face. + * `Type` is either `Segment_3`, `Ray_3` or `Line_3`. */ struct Construct_intersection { diff --git a/Poisson_surface_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt b/Poisson_surface_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt index 184e087e3a7..d37c3273547 100644 --- a/Poisson_surface_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt +++ b/Poisson_surface_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt @@ -119,9 +119,9 @@ The following example reads a point set, creates a Poisson implicit function and The computed implicit functions can be iso-contoured to reconstruct a surface by using the \ref PkgMesh3 : -`make_mesh_3()` with the `surface_only()` parameter for using parallel Mesh_3 +`make_mesh_3()` with the `surface_only()` parameter to only mesh the surface -The parameter `Tag` affects the behavior of `make_mesh_3()`: +The following `Tag` parameters affect the behavior of `make_mesh_3()`: - `Manifold_tag`: the output mesh is guaranteed to be a manifold surface without boundary. - `Manifold_with_boundary_tag`: the output mesh is guaranteed to be manifold and may have boundaries. - `Non_manifold_tag`: the output mesh has no guarantee and hence is outputted as a polygon soup. diff --git a/Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h b/Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h index a88fa7d5412..d852e182b8e 100644 --- a/Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h +++ b/Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h @@ -30,7 +30,7 @@ namespace CGAL { \tparam BGT is a geometric traits class that provides the basic operations to implement intersection tests and intersection computations through a bisection - method.This parameter must be instantiated with a model of the concept `BisectionGeometricTraits_3`. + method. This parameter must be instantiated with a model of the concept `BisectionGeometricTraits_3`. \cgalModels{MeshDomain_3} @@ -39,7 +39,9 @@ namespace CGAL { */ template class Poisson_mesh_domain_3 +#ifndef DOXYGEN_RUNNING : public Labeled_mesh_domain_3 +#endif { public: using Base = Labeled_mesh_domain_3; @@ -264,11 +266,7 @@ public: /* * Returns a point in the intersection of the primitive `type` * with some boundary surface. - * `Type1` is either `Segment_3`, `Ray_3` or `Line_3`. - * The integer `dimension` is set to the dimension of the lowest - * dimensional face in the input complex containing the returned point, and - * `index` is set to the index to be stored at a mesh vertex lying - * on this face. + * `Type` is either `Segment_3`, `Ray_3` or `Line_3`. */ struct Construct_intersection {