songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Follow the OG paper's prescription of the SVD threshold 

It makes it less likely to have wild stuff happens on spiky geometry
This commit is contained in:
Mael Rouxel-Labbé 2024-02-23 16:17:23 +01:00
parent 5799dc8d15
commit aa3925d829
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h
View File

@ -167,8 +167,9 @@ bool cell_position_QEM(const typename Domain::Cell_descriptor& c,
Eigen::JacobiSVD<typename Eigen_matrix_x::EigenType> svd(A, Eigen::ComputeThinU | Eigen::ComputeThinV);
// set threshold as in Peter Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models"
svd.setThreshold(1e-3);
// Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models": 1e-3
// Ju's paper, "Dual Contouring of Hermite Data": 1e-1
svd.setThreshold(1e-1);
Eigen_vector_3 x_hat;
x_hat << x_coord(com), y_coord(com), z_coord(com);