songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix the confusion between `handle` and `const_handle`

This commit is contained in:
Laurent Rineau 2025-09-26 10:22:15 +02:00
parent 757cc8525d
commit b5a180d9df
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Constrained_triangulation_3/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h
View File

@ -2227,7 +2227,7 @@ private:
if(it != e) { if(it != e) {
return *it; return *it;
} else { } else {
return std::as_const(vertices_of_cavity_union_find).end(); return vertices_of_cavity_union_find.end();
} }
}); });
CGAL_assertion(vertex_below_handle == vertices_of_cavity_union_find.end() || CGAL_assertion(vertex_below_handle == vertices_of_cavity_union_find.end() ||

8
STL_Extension/include/CGAL/iterator.h
View File

@ -82,8 +82,14 @@ Iterator_range<Prevent_deref<I> > make_prevent_deref_range(const I& begin, const
} }
template<typename R> template<typename R>
auto make_prevent_deref_range(const R& range) auto make_prevent_deref_range(R&& range)
{ {
static_assert( !std::is_rvalue_reference_v<R&&>,
"make_prevent_deref_range cannot be used with"
" rvalue references to avoid dangling references");
// Note: If CGAL were allowed to use C++20, we could use `std::ranges::begin/end`.
// That would allow this to work with rvalue ranges when `std::borrowed_range<R>` is `true`.
// See https://en.cppreference.com/w/cpp/ranges/begin.html#Notes
using std::begin; using std::begin;
using std::end; using std::end;
return make_range(make_prevent_deref(begin(range)), make_prevent_deref(end(range))); return make_range(make_prevent_deref(begin(range)), make_prevent_deref(end(range)));