songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

One more bug fix in Buffer_for_vao.h

This commit is contained in:
Guillaume Damiand 2017-12-01 17:03:38 +01:00 committed by Maxime Gimeno
parent 4f93b87634
commit b5a4cd1e4a
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
GraphicsView/include/CGAL/Buffer_for_vao.h
View File

@ -412,17 +412,17 @@ public:
/// @return true iff the points of 'facet' form a convex face
static bool is_facet_convex(const std::vector<Local_point>& facet,
const Local_vector& N)
const Local_vector& normal)
{
Local_kernel::Orientation orientation;
std::size_t id=0;
do
{
Local_point& S=facet[id];
Local_point& T=facet[id+1];
const Local_point& S=facet[id];
const Local_point& T=facet[id+1];
Local_vector V1=Local_vector((T-S).x(), (T-S).y(), (T-S).z());
Local_point& U=facet[id+2];
const Local_point& U=facet[id+2];
Local_vector V2=Local_vector((U-T).x(), (U-T).y(), (U-T).z());
orientation = Local_kernel::Orientation_3()(V1, V2, normal);
@ -439,11 +439,11 @@ public:
// Now we compute convexness
for(id=0; id<facet.size(); ++id)
{
Local_point& S=facet[id];
Local_point& T=facet[id+1];
const Local_point& S=facet[id];
const Local_point& T=facet[id+1];
Local_vector V1=Local_vector((T-S).x(), (T-S).y(), (T-S).z());
Local_point& U=facet[id+2];
const Local_point& U=facet[id+2];
Local_vector V2=Local_vector((U-T).x(), (U-T).y(), (U-T).z());
orientation = Local_kernel::Orientation_3()(V1, V2, normal);
@ -535,8 +535,8 @@ protected:
add_flat_normal(normal);
if (m_vertex_normals_for_face.size()>0)
{ add_gouraud_normal(normal); }
if (m_vertex_normals_for_face.size()==0)
{ add_gouraud_normal(normal); }
}
if (m_vertex_normals_for_face.size()>0)