From b9411822a4e9e4410087462ac724973b74ead3d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mael=20Rouxel-Labb=C3=A9?= Date: Tue, 27 Feb 2024 15:57:49 +0100 Subject: [PATCH] Revert "Follow the OG paper's prescription of the SVD threshold" This reverts commit 913f8796c9eb02432584c083c42c9c19644e2d2e. While a larger epsilon bound gave better results for non-manifold pinched configurations, it also resulted in a lot of sharpness loss. For now, I'd rather it does not do well at non-manifold configurations. Improving results on those configurations is todo. --- .../CGAL/Isosurfacing_3/internal/dual_contouring_functors.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h index 6cfe537dc8f..9d4a26a4879 100644 --- a/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h +++ b/Isosurfacing_3/include/CGAL/Isosurfacing_3/internal/dual_contouring_functors.h @@ -168,9 +168,8 @@ bool cell_position_QEM(const typename Domain::Cell_descriptor& c, Eigen::JacobiSVD svd(A, Eigen::ComputeThinU | Eigen::ComputeThinV); - // Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models": 1e-3 - // Ju's paper, "Dual Contouring of Hermite Data": 1e-1 - svd.setThreshold(1e-1); + // set threshold as in Peter Lindstrom's paper, "Out-of-Core Simplification of Large Polygonal Models" + svd.setThreshold(1e-3); Eigen_vector_3 x_hat; x_hat << x_coord(com), y_coord(com), z_coord(com);