songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

some TODOs

This commit is contained in:
Pierre Alliez 2018-03-18 12:46:12 +01:00
parent 9130cf7b63
commit b9be820b74
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Surface_mesh_approximation/include/CGAL/VSA_approximation.h
View File

@ -874,11 +874,11 @@ public:
* @param pca_plane set `true` if use PCA plane fitting, otherwise use the default area averaged plane parameters
* @return `true` if the extracted surface mesh is manifold, `false` otherwise.
*/
bool extract_mesh(const FT chord_error = FT(5.0),
const bool is_relative_to_chord = false,
const bool with_dihedral_angle = false,
const bool optimize_anchor_location = true,
const bool pca_plane = false)
bool extract_mesh(const FT chord_error = FT(5.0), // replace by optional named parama
const bool is_relative_to_chord = false, // replace by optional named parama
const bool with_dihedral_angle = false, // replace by optional named parama
const bool optimize_anchor_location = true, // replace by optional named parama
const bool pca_plane = false) // replace by optional named parama
{
// compute averaged edge length, used in chord subdivision
m_average_edge_length = compute_averaged_edge_length(*m_ptm, m_vpoint_map);

5
Surface_mesh_approximation/include/CGAL/mesh_approximation.h
View File

@ -47,7 +47,7 @@ namespace CGAL {
* \cgalParamEnd
* \cgalParamBegin{nb_of_relaxations} number of relaxation iterations interleaved within seeding.
* \cgalParamEnd
* \cgalParamBegin{mesh_chord_error} maximum chord approximation error used for meshing.
* \cgalParamBegin{mesh_chord_error} maximum chord approximation error used for meshing (TODO: precise unit).
* \cgalParamEnd
* \cgalParamBegin{face_proxy_map} a ReadWritePropertyMap with
* `boost::graph_traits<TriangleMesh>::%face_descriptor` as key and `std::size_t` as value type.
@ -102,7 +102,8 @@ bool mesh_approximation(const TriangleMesh &tm, const NamedParameters &np)
approx.run(nb_of_iterations);
#ifdef CGAL_SURFACE_MESH_APPROXIMATION_DEBUG
#ifdef CGAL_SURFACE_MESH_APPROXIMATION_DEBUG // TODO replace by verbose level?
std::cout << "#px = " << approx.proxies_size()
<< ", #itr = " << nb_of_iterations
<< ", #relx = " << nb_of_relaxations << std::endl;