songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify choice of cells to un-carve while enforcing manifoldness 

This combinatorial choice seemed like a good idea, but it can have
nasty cascading effects, adding very large tetrahedra. See this
issue: https://github.com/CGAL/cgal/issues/7625

In the end, the only thing we care about is small volumes being added.

I keep the artificial vertex for now, but I am not fully convinced
these should be actually kept too.
This commit is contained in:
Mael Rouxel-Labbé 2023-08-01 13:16:18 +02:00
parent 8076e20b71
commit c7b9317a96
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Alpha_wrap_3/include/CGAL/Alpha_wrap_3/internal/Alpha_wrap_3.h
View File

@ -1445,11 +1445,6 @@ private:
if(has_artificial_vertex(r)) if(has_artificial_vertex(r))
return true; return true;
const int l_bf_count = count_boundary_facets(l, v);
const int r_bf_count = count_boundary_facets(r, v);
if(l_bf_count != r_bf_count)
return l_bf_count > r_bf_count;
return sq_longest_edge(l) < sq_longest_edge(r); return sq_longest_edge(l) < sq_longest_edge(r);
}; };