songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check critical TODOs.

This commit is contained in:
André Nusser 2025-03-05 10:54:58 +01:00
parent 6a87562b86
commit cdb7989a85
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Frechet_distance/include/CGAL/Frechet_distance/internal/filter.h
View File

@ -139,9 +139,9 @@ void Filter<K>::increase(size_t& step) { step = std::ceil(1.5 * step); }
template <typename K>
void Filter<K>::decrease(size_t& step) { step /= 2; }
// NOTE: all calls to cert.XXX() do nothing if CERTIFY is not defined
// TODO: is it better to use #ifdef CERTIFY blocks here to avoid constructing
// CPosition objects?
// Also, calls to cert.XXX() seem to do unnecessary work right now
template <typename K>
bool Filter<K>::bichromaticFarthestDistance()

8
Frechet_distance/include/CGAL/Frechet_distance/internal/frechet_light.h
View File

@ -118,7 +118,6 @@ private:
Certificate cert;
// TODO re-inline these functions!
template <class IndexType>
CInterval getInterval(Curve const& curve1,
IndexType const& center_id,
@ -509,15 +508,13 @@ inline void FrechetLight<C>::continueQSimpleSearch(QSimpleInterval& qsimple,
}
// from here on, regular mode -> IndexType = PointID
// TODO: re-inline using if_static
// otherwise we have to compute the intersection interval:
// TODO: bad style: stripping down information added by getInterval
CInterval temp_interval = FrechetLight::getInterval<IndexType>(
fixed_curve, fixed, curve, cur);
Interval interval = Interval(temp_interval.begin.getPoint() == cur
? temp_interval.begin.getFraction()
: 1, ///@TODO Andre : really 1. ? pure guess, should be 0.
: 1,
temp_interval.end.getPoint() == cur
? temp_interval.end.getFraction()
: 1);
@ -1369,8 +1366,7 @@ bool FrechetLight<C>::isOnUpperLeft(const CPosition& pt) const
return pt[0] == 0 || pt[1] == curve_pair[1]->size() - 1;
}
// TODO, André: I am not sure whether this is currently fine using interval arithmetic
// TODO by André: I am not sure whether this is currently fine using interval arithmetic, but this only affects the certificates, which are currently not active. This needs to be checked in case certificates are used in the future.
template <typename C>
Certificate<C>& FrechetLight<C>::computeCertificate()
{

1
Frechet_distance/include/CGAL/Frechet_distance/internal/high_level_predicates.h
View File

@ -47,7 +47,6 @@ inline void make_less_than_one(Interval_nt<false>& n)
// <=> lambda^2 * a + lambda * 2 b + c = 0
// <=> lambda^2 + (2 b / a) * lambda + (c / a) = 0
// <=> lambda1/2 = - (b / a) +/- sqrt((b / a)^2 - c / a)
//TODO: use optional!
template <class Traits, class C, class Point, class AFT>
std::optional<bool>
fill_lambda(const Point& circle_center,