From ce1c890cb0ec71294a56f23199e9aa0a55b25ed4 Mon Sep 17 00:00:00 2001
From: Guillaume Damiand <guillaume.damiand@liris.cnrs.fr>
Date: Fri, 10 Oct 2025 09:42:43 +0200
Subject: [PATCH] order of parameter for lcc vtk functions

---
 .../linear_cell_complex_3_vtk_io.cpp          | 33 +++++++++++--------
 .../include/CGAL/Linear_cell_complex/IO/VTK.h | 31 ++++++++---------
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/Linear_cell_complex/examples/Linear_cell_complex/linear_cell_complex_3_vtk_io.cpp b/Linear_cell_complex/examples/Linear_cell_complex/linear_cell_complex_3_vtk_io.cpp
index d1c040ac29c..8bd7b39e38d 100644
--- a/Linear_cell_complex/examples/Linear_cell_complex/linear_cell_complex_3_vtk_io.cpp
+++ b/Linear_cell_complex/examples/Linear_cell_complex/linear_cell_complex_3_vtk_io.cpp
@@ -1,26 +1,31 @@
 #include <CGAL/Linear_cell_complex_for_combinatorial_map.h>
 #include <CGAL/Linear_cell_complex/IO/VTK.h>
-#include <CGAL/Combinatorial_map_save_load.h>
 #include <vector>
 #include <cstdlib>
 
 int main()
 {
   CGAL::Linear_cell_complex_for_combinatorial_map<3> lcc;
-  CGAL::load_combinatorial_map("data/beam-with-mixed-cells.3map", lcc);
+  std::ifstream is("data/beam-with-mixed-cells.3map");
+  if(!is)
+  {
+    std::cout<<"Error opening data/beam-with-mixed-cells.3map."<<std::endl;
+    return EXIT_FAILURE;
+  }
 
-    // Compute per-volume vertex count
-    std::vector<std::size_t> volume_scalars;
-    for(auto it=lcc.template one_dart_per_cell<3>().begin(),
-         itend=lcc.template one_dart_per_cell<3>().end(); it!=itend; ++it)
-    {
-      std::size_t nbv=lcc.template one_dart_per_incident_cell<0,3>(it).size();
-      volume_scalars.push_back(nbv);
-    }
+  is>>lcc;
+  // Compute per-volume vertex count
+  std::vector<std::size_t> volume_scalars;
+  for(auto it=lcc.template one_dart_per_cell<3>().begin(),
+        itend=lcc.template one_dart_per_cell<3>().end(); it!=itend; ++it)
+  {
+    std::size_t nbv=lcc.template one_dart_per_incident_cell<0,3>(it).size();
+    volume_scalars.push_back(nbv);
+  }
 
-    if(!CGAL::IO::write_VTK("beam-with-mixed-cells.vtk", lcc, nullptr,
-                            &volume_scalars))
-    { return EXIT_FAILURE; }
+  if(!CGAL::IO::write_VTK("beam-with-mixed-cells.vtk", lcc, nullptr,
+                          &volume_scalars))
+  { std::cout<<"Error for write_VTK."<<std::endl; return EXIT_FAILURE; }
 
-    return EXIT_SUCCESS;
+  return EXIT_SUCCESS;
 }
diff --git a/Linear_cell_complex/include/CGAL/Linear_cell_complex/IO/VTK.h b/Linear_cell_complex/include/CGAL/Linear_cell_complex/IO/VTK.h
index 115d2e2a416..a5700661597 100644
--- a/Linear_cell_complex/include/CGAL/Linear_cell_complex/IO/VTK.h
+++ b/Linear_cell_complex/include/CGAL/Linear_cell_complex/IO/VTK.h
@@ -597,8 +597,7 @@ bool write_lcc_topo_to_vtk_ascii(std::ostream& os, const LCC& alcc,
 
 ////////////////////////////////////////////////////////////////////////////////////
 template <typename LCC, typename VertexScalarType, typename VolumeScalarType>
-bool read_VTK(LCC& alcc,
-              const char* filename,
+bool read_VTK(const char* filename, LCC& alcc,
               std::vector<VertexScalarType>* vertex_scalars,
               std::vector<VolumeScalarType>* volume_scalars)
 {
@@ -614,25 +613,21 @@ bool read_VTK(LCC& alcc,
 }
 
 template <typename LCC>
-bool read_VTK(LCC& alcc,
-    const char* filename)
-{ return read_VTK<LCC, float, float>
-      (alcc, filename, nullptr, nullptr); }
+bool read_VTK(const char* filename, LCC& alcc)
+{ return read_VTK<LCC, float, float>(filename, alcc, nullptr, nullptr); }
 
 template <typename LCC, typename VertexScalarType>
-bool read_VTK(LCC& alcc,
-    const char* filename,
-    std::vector<VertexScalarType>* vertex_scalars)
+bool read_VTK(const char* filename, LCC& alcc,
+              std::vector<VertexScalarType>* vertex_scalars)
 { return read_VTK<LCC, VertexScalarType, float>
-      (alcc, filename, vertex_scalars, nullptr); }
+      (filename, alcc, vertex_scalars, nullptr); }
 
 template <typename LCC, typename VolumeScalarType>
-bool read_VTK(LCC& alcc,
-    const char* filename,
-    std::nullptr_t,
-    std::vector<VolumeScalarType>* volume_scalars)
+bool read_VTK(const char* filename, LCC& alcc,
+              std::nullptr_t,
+              std::vector<VolumeScalarType>* volume_scalars)
 { return read_VTK<LCC, float, VolumeScalarType>
-      (alcc, filename, nullptr, volume_scalars); }
+      (filename, alcc, nullptr, volume_scalars); }
 ////////////////////////////////////////////////////////////////////////////////////
 template <typename LCC, typename PointFunctor, typename CellFunctor>
 inline bool write_VTK_with_fct(const char* filename, const LCC& alcc,
@@ -691,14 +686,14 @@ bool write_VTK(const char* filename, const LCC& alcc,
 template <typename LCC>
 bool write_VTK(const char* filename, const LCC& alcc)
 {
-  return write_VTK<LCC, float, float>(alcc, filename, nullptr, nullptr);
+  return write_VTK<LCC, float, float>(filename, alcc, nullptr, nullptr);
 }
 
 template <typename LCC, typename VertexScalarType>
 bool write_VTK(const char* filename, const LCC& alcc,
                const std::vector<VertexScalarType>* vertex_scalars)
 {
-  return write_VTK<LCC, VertexScalarType, float>(alcc, filename, vertex_scalars,
+  return write_VTK<LCC, VertexScalarType, float>(filename, alcc, vertex_scalars,
                                                  nullptr);
 }
 
@@ -707,7 +702,7 @@ bool write_VTK(const char* filename, const LCC& alcc,
                std::nullptr_t,
                const std::vector<VolumeScalarType>* volume_scalars)
 {
-  return write_VTK<LCC, float, VolumeScalarType>(alcc, filename, nullptr,
+  return write_VTK<LCC, float, VolumeScalarType>(filename, alcc, nullptr,
                                                  volume_scalars);
 }
 ////////////////////////////////////////////////////////////////////////////////////