songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not define _USE_MATH_DEFINES (#9094) 

## Summary of Changes

This leads to a warning in the
[testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-11/Periodic_2_triangulation_2/TestReport_Christo_ICPC-2025.1-Release.gz)
Also it is a weaker test as this `#define`  is not required.

## Release Management

* Affected package(s): Periodic_2_triangulation_2
* License and copyright ownership: unchanged
This commit is contained in:
Sebastien Loriot 2025-10-13 09:30:54 +02:00 committed by GitHub
parent f77f06eede 7816c70770
commit d95917e06f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Bounding_volumes/include/CGAL/pierce_rectangles_2.h
View File

@ -892,8 +892,8 @@ four_cover_points(Staircases< Traits >& d, OutputIterator o, bool& ok)
sdistx(*(shf - 1), bottom) <= FT(2) * d.r)))) sdistx(*(shf - 1), bottom) <= FT(2) * d.r))))
#else #else
if (sdistx(bottom_i.second, bottom) <= FT(2) * d.r && if (sdistx(bottom_i.second, bottom) <= FT(2) * d.r &&
((!d.is_x_greater_y() || (!d.is_x_greater_y() ||
(shl == Citerator(share.end()) || ((shl == Citerator(share.end()) ||
sdistx(share.back(), bottom) <= FT(2) * d.r) && sdistx(share.back(), bottom) <= FT(2) * d.r) &&
(shf == Citerator(share.begin()) || (shf == Citerator(share.begin()) ||
sdistx(*(shf - 1), bottom) <= FT(2) * d.r)))) sdistx(*(shf - 1), bottom) <= FT(2) * d.r))))

2
Periodic_2_triangulation_2/test/Periodic_2_triangulation_2/include/types.h
View File

@ -4,8 +4,6 @@
#ifndef P2T2_UNIT_TEST_TYPES_H #ifndef P2T2_UNIT_TEST_TYPES_H
#define P2T2_UNIT_TEST_TYPES_H #define P2T2_UNIT_TEST_TYPES_H
#define _USE_MATH_DEFINES
#include <math.h>
#include <CGAL/Periodic_2_triangulation_2.h> #include <CGAL/Periodic_2_triangulation_2.h>
#include <CGAL/Periodic_2_triangulation_traits_2.h> #include <CGAL/Periodic_2_triangulation_traits_2.h>

2
Periodic_2_triangulation_2/test/Periodic_2_triangulation_2/test_p2t2_delaunay_remove.cpp
View File

@ -30,7 +30,7 @@ int main()
vh_midpoint = t.insert(Point(0, 0) + midpoint); vh_midpoint = t.insert(Point(0, 0) + midpoint);
for (int i = 0; i < n; ++i) for (int i = 0; i < n; ++i)
{ {
t.insert(Point(0.3 * sin(i * 1.0 / n * 2 * M_PI), 0.3 * cos(i * 1.0 / n * 2 * M_PI)) + midpoint); t.insert(Point(0.3 * sin(i * 1.0 / n * 2 * CGAL_PI), 0.3 * cos(i * 1.0 / n * 2 * CGAL_PI)) + midpoint);
} }
t.remove(vh_midpoint); t.remove(vh_midpoint);
assert(t.is_valid(true)); assert(t.is_valid(true));