From a11b69e3193a29db7d5bcfc0ee61e22103bcdf77 Mon Sep 17 00:00:00 2001 From: Michael Hemmer Date: Thu, 6 Aug 2020 08:16:54 -0700 Subject: [PATCH] Fix do_intersect for Tetrahedron_3 Tetrahedron_3 In Line 65 in function do_intersect_tetrahedron_bounded (tr,tet,p,k) we eval k.has_on_bounded_side_3_object()(tet, p), where tr=lh_tet and tet=rh_tet. Thus p must be generated from lh_tet, or L65 is always true. This is a flyby and has not been tested. --- .../internal/Tetrahedron_3_Bounded_3_do_intersect.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Intersections_3/include/CGAL/Intersections_3/internal/Tetrahedron_3_Bounded_3_do_intersect.h b/Intersections_3/include/CGAL/Intersections_3/internal/Tetrahedron_3_Bounded_3_do_intersect.h index dbbfd64178e..bb85726ae6b 100644 --- a/Intersections_3/include/CGAL/Intersections_3/internal/Tetrahedron_3_Bounded_3_do_intersect.h +++ b/Intersections_3/include/CGAL/Intersections_3/internal/Tetrahedron_3_Bounded_3_do_intersect.h @@ -162,11 +162,11 @@ do_intersect(const typename K::Sphere_3 &sp, template inline typename K::Boolean -do_intersect(const typename K::Tetrahedron_3 &tet, - const typename K::Tetrahedron_3 &sp, +do_intersect(const typename K::Tetrahedron_3 &lh_tet, + const typename K::Tetrahedron_3 &rh_tet, const K & k) { - return do_intersect_tetrahedron_bounded(sp, tet, tet[0], k); + return do_intersect_tetrahedron_bounded(lh_tet, rh_tet, lh_tet[0], k); } template