songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6925 from MaelRL/OBB-Do_not_use_void_as_default-GF 

Do not use `void` as default for the geometric traits if Eigen is not present
This commit is contained in:
Laurent Rineau 2022-10-07 15:46:36 +02:00
parent 4a26b482a7 71e51b5678
commit de92e2c729
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Optimal_bounding_box/include/CGAL/Optimal_bounding_box/oriented_bounding_box.h
View File

@ -26,6 +26,7 @@
#include <CGAL/boost/graph/named_params_helper.h> #include <CGAL/boost/graph/named_params_helper.h>
#include <CGAL/convex_hull_3.h> #include <CGAL/convex_hull_3.h>
#include <CGAL/Convex_hull_traits_3.h> #include <CGAL/Convex_hull_traits_3.h>
#include <CGAL/Default.h>
#include <CGAL/Iterator_range.h> #include <CGAL/Iterator_range.h>
#include <CGAL/Kernel_traits.h> #include <CGAL/Kernel_traits.h>
#include <CGAL/Random.h> #include <CGAL/Random.h>
@ -333,14 +334,14 @@ void oriented_bounding_box(const PointRange& points,
typedef typename CGAL::Kernel_traits<Point>::type K; typedef typename CGAL::Kernel_traits<Point>::type K;
typedef Oriented_bounding_box_traits_3<K> Default_traits; typedef Oriented_bounding_box_traits_3<K> Default_traits;
#else #else
typedef void Default_traits; typedef CGAL::Default Default_traits;
#endif #endif
typedef typename internal_np::Lookup_named_param_def<internal_np::geom_traits_t, typedef typename internal_np::Lookup_named_param_def<internal_np::geom_traits_t,
NamedParameters, NamedParameters,
Default_traits>::type Geom_traits; Default_traits>::type Geom_traits;
CGAL_static_assertion_msg(!(std::is_same<Geom_traits, void>::value), CGAL_static_assertion_msg(!(std::is_same<Geom_traits, CGAL::Default>::value),
"You must provide a traits class or have Eigen enabled!"); "You must provide a traits class or have Eigen enabled!");
Geom_traits traits = choose_parameter<Geom_traits>(get_parameter(np, internal_np::geom_traits)); Geom_traits traits = choose_parameter<Geom_traits>(get_parameter(np, internal_np::geom_traits));