songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes after review

This commit is contained in:
Maxime Gimeno 2020-02-11 14:06:53 +01:00
parent 0378d7825f
commit e9864cf874
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/clip.h
View File

@ -411,7 +411,7 @@ void split_along_edges(TriangleMesh& tm,
* See Subsection \ref coref_clip for more details. * See Subsection \ref coref_clip for more details.
* \attention With the current implementation, `clipper` will be modified (refined with the intersection with `tm`). * \attention With the current implementation, `clipper` will be modified (refined with the intersection with `tm`).
* *
* \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(tm1)` \endlink * \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(tm)` \endlink
* \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(clipper)` \endlink * \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(clipper)` \endlink
* \pre \link CGAL::Polygon_mesh_processing::does_bound_a_volume() `CGAL::Polygon_mesh_processing::does_bound_a_volume(clipper)` \endlink * \pre \link CGAL::Polygon_mesh_processing::does_bound_a_volume() `CGAL::Polygon_mesh_processing::does_bound_a_volume(clipper)` \endlink
* *
@ -580,7 +580,7 @@ bool clip( TriangleMesh& tm,
* \ingroup PMP_corefinement_grp * \ingroup PMP_corefinement_grp
* corefines `tm` and `splitter` and duplicates edges in `tm` that are on the intersection with `splitter`. * corefines `tm` and `splitter` and duplicates edges in `tm` that are on the intersection with `splitter`.
* *
* \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(tm1)` \endlink * \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(tm)` \endlink
* \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(splitter)` \endlink * \pre \link CGAL::Polygon_mesh_processing::does_self_intersect() `!CGAL::Polygon_mesh_processing::does_self_intersect(splitter)` \endlink
* *
* @tparam TriangleMesh a model of `MutableFaceGraph`, `HalfedgeListGraph` and `FaceListGraph`. * @tparam TriangleMesh a model of `MutableFaceGraph`, `HalfedgeListGraph` and `FaceListGraph`.
@ -666,6 +666,9 @@ void split( TriangleMesh& tm,
* @param np optional sequence of \ref pmp_namedparameters "Named Parameters" among the ones listed below * @param np optional sequence of \ref pmp_namedparameters "Named Parameters" among the ones listed below
* *
* \cgalNamedParamsBegin * \cgalNamedParamsBegin
* \cgalParamBegin{vertex_point_map}
* the property map with the points associated to the vertices of `tm`.
* \cgalParamEnd
* \cgalParamBegin{visitor} a class model of `PMPCorefinementVisitor` * \cgalParamBegin{visitor} a class model of `PMPCorefinementVisitor`
* that is used to track the creation of new faces. * that is used to track the creation of new faces.
* \cgalParamEnd * \cgalParamEnd

3
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/connected_components.h
View File

@ -1056,8 +1056,7 @@ void split_connected_components_impl(
* *
* *
* \tparam PolygonMesh a model of `FaceListGraph` * \tparam PolygonMesh a model of `FaceListGraph`
* \tparam PolygonMeshRange a model of `SequenceContainer` (providing * \tparam PolygonMeshRange a model of `SequenceContainer` with `PolygonMesh` as value type.
* `void push_back()` and `PolygonMesh& back()`) with `PolygonMesh` as value type.
* *
* \tparam NamedParameters a sequence of Named Parameters * \tparam NamedParameters a sequence of Named Parameters
* *

5
Polyhedron/demo/Polyhedron/Plugins/PMP/Join_and_split_polyhedra_plugin.cpp
View File

@ -153,7 +153,6 @@ void Polyhedron_demo_join_and_split_polyhedra_plugin::on_actionSplitPolyhedra_tr
if (new_polyhedra.size()==1) if (new_polyhedra.size()==1)
{ {
new_polyhedra.front();
CGAL::Three::Three::information( tr("%1 has only one connected component").arg(item->name()) ); CGAL::Three::Three::information( tr("%1 has only one connected component").arg(item->name()) );
QApplication::restoreOverrideCursor(); QApplication::restoreOverrideCursor();
continue; continue;
@ -167,9 +166,9 @@ void Polyhedron_demo_join_and_split_polyhedra_plugin::on_actionSplitPolyhedra_tr
compute_color_map(item->color(), new_polyhedra.size(), std::back_inserter(color_map)); compute_color_map(item->color(), new_polyhedra.size(), std::back_inserter(color_map));
Scene_group_item *group = new Scene_group_item("CC"); Scene_group_item *group = new Scene_group_item("CC");
scene->addItem(group); scene->addItem(group);
for(FaceGraph polyhedron_ptr : new_polyhedra) for(FaceGraph& poly : new_polyhedra)
{ {
Scene_facegraph_item* new_item=new Scene_facegraph_item(polyhedron_ptr); Scene_facegraph_item* new_item=new Scene_facegraph_item(poly);
new_item->setName(tr("%1 - CC %2").arg(item->name()).arg(cc)); new_item->setName(tr("%1 - CC %2").arg(item->name()).arg(cc));
new_item->setColor(color_map[cc]); new_item->setColor(color_map[cc]);
++cc; ++cc;

1
Surface_mesh_parameterization/package_info/Surface_mesh_parameterization/dependencies
View File

@ -1,7 +1,6 @@
Algebraic_foundations Algebraic_foundations
BGL BGL
Box_intersection_d Box_intersection_d
Cartesian_kernel
Circulator Circulator
Distance_2 Distance_2
Distance_3 Distance_3