songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sanitize result of square root

This commit is contained in:
Mael Rouxel-Labbé 2019-06-26 15:09:19 +02:00
parent 056e846e0d
commit f882c5d3a6
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Segment_Delaunay_graph_2/include/CGAL/Segment_Delaunay_graph_2/Basic_predicates_C2.h
View File

@ -146,8 +146,11 @@ public:
static
FT to_ft(const Sqrt_3& x)
{
FT sqrt_e = compute_sqrt( to_ft(x.e()), FT_Has_sqrt() );
FT sqrt_f = compute_sqrt( to_ft(x.f()), FT_Has_sqrt() );
// If the number type does not offer a square root, x.e() and x.f() (which are of type sqrt_1)
// might be negative after (approximately) evaluating them. Taking the max sanitize these values
// to ensure that we do not take the square root of a negative number.
FT sqrt_e = compute_sqrt( (std::max)(FT(0), to_ft(x.e())), FT_Has_sqrt() );
FT sqrt_f = compute_sqrt( (std::max)(FT(0), to_ft(x.f())), FT_Has_sqrt() );
FT sqrt_ef = sqrt_e * sqrt_f;
return to_ft(x.a()) + to_ft(x.b()) * sqrt_e
+ to_ft(x.c()) * sqrt_f + to_ft(x.d()) * sqrt_ef;