From 03202d874fefba9bda6cb79f659aa1d1041d0a90 Mon Sep 17 00:00:00 2001 From: Laurent Rineau Date: Fri, 17 May 2019 16:44:14 +0200 Subject: [PATCH] Fix the default of 3rd template parameter of Convex_hull_traits_3 The documentation of `convex_hull_3` says that, if the kernel is "like `Epick`", then the default traits class of `convex_hull_3` is `Convex_hull_traits_3`. But that is wrong, because `Convex_hull_traits_3` is documented with only two template parameters, and if the kernel is "like `Epick`", the third argument is `CGAL::Tag_true`, whereas the default of that parameter is `CGAL::Tag_false`. If users want to write explicitly the traits in the call to `convex_hull_3`, they cannot know that there is a third parameters, and that it must be `Tag_true`. This commit fixes the default of that third argument. --- Convex_hull_3/include/CGAL/Convex_hull_traits_3.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Convex_hull_3/include/CGAL/Convex_hull_traits_3.h b/Convex_hull_3/include/CGAL/Convex_hull_traits_3.h index 699155f983d..e243afcae86 100644 --- a/Convex_hull_3/include/CGAL/Convex_hull_traits_3.h +++ b/Convex_hull_3/include/CGAL/Convex_hull_traits_3.h @@ -159,7 +159,12 @@ struct GT3_for_CH3 { - template + template ::type::value && + R_::Has_filtered_predicates_tag::value + > > class Convex_hull_traits_3 { public: