songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
114,474 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

62 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 40c6a25fe0 Move functions 2024-12-13 14:17:00 +01:00
albert-github 40c7765ffb Spelling corrections 
Corrections based on review
 2023-07-30 17:54:10 +02:00
Sébastien Loriot cf45dd3d5b boost::is_base_of -> std::is_base_of 2023-04-23 22:37:07 +02:00
Andreas Fabri c04dceb71d Merge master 2022-10-14 14:40:58 +01:00
Mael Rouxel-Labbé cf12f90cbf Fix broken is_hyperbolic(face/edge) framework 
The previous code tries to handle finite/infinite and hyperbolic/non-hyperbolic
with a single flag, which caused errors to get stuff like finite
but non-hyperbolic edges (see e.g. https://github.com/CGAL/cgal/issues/6869).

In addition, it used tds_data(), which is something that now also
exists in the triangulation_ds_face_base_2 class.

Hence, completely re-implement the hyperbolic stack / query.

 #	../../../../Installation/CHANGES.md.orig
 2022-09-26 16:08:43 +02:00
Mael Rouxel-Labbé 145a817cc1 Remove (broken) HDT2::insert(p, lt, li) from documentation 
The 'lt' is documented to be HDT2::Locate_type, which is wrong, the function's
signature uses HDT2::DT2::Locate_type, and that's for a precise reason:
HDT2::locate() returns location based on hyperbolic simplicies, and not
the underlying DT2 triangulation. So, one might retrieve "OUTSIDE_CONVEX_HULL"
if a query is on a non-hyperbolic Delaunay face, but a finite underlying DT2
face. In that configuration, it'd break the triangulation to do an insertion
with "OUTSIDE_CONVEX_HULL".

The documentation could be fixed, but it is too dangerous so it's best
to just remove it. (Maybe it should also be simply removed
from the triangulation class.)
 2022-09-26 16:07:52 +02:00
Mael Rouxel-Labbé a7eedb0c74 Fix `ensuring_hyperbolic_face_handle` not doing anything (dim > 2 is 'false') 2022-09-26 15:15:35 +02:00
Mael Rouxel-Labbé 25df7a7565 Misc tiny improvements 2022-09-26 15:14:29 +02:00
Mael Rouxel-Labbé 98b6b95054 Fix issues in HDT2::locate(): 
- Fix not setting up 'li' when landing on a non hyperbolic face but hyperbolic
  edge
- Fix returning Face_handle()s for some EDGE cases
 2022-09-26 15:11:38 +02:00
Mael Rouxel-Labbé a1752b8b27 Misc cleaning 2022-09-24 23:29:03 +02:00
Mael Rouxel-Labbé 94900beec6 Do not return point copies in HT2::point() 2022-09-24 16:48:15 +02:00
Mael Rouxel-Labbé c8e029438b Remove superfluous call to ensure_hyperbolic_face_handle() (insert() does it) 2022-09-24 16:46:07 +02:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces 
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
 2020-03-26 14:16:06 +01:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags 
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
 2019-10-18 21:57:54 +02:00
Andreas Fabri 4581f1b7a8 Morte replacements 2019-06-05 08:39:55 +02:00
Iordan Iordanov 8e1dfa329e Fixes for a few more warnings in the testsuite 2019-01-16 16:46:56 +01:00
Iordan Iordanov f84a4b0405 Bugfix for operator= test 2019-01-10 13:57:55 +01:00
Iordan Iordanov 38ec4cf946 A couple of fixes for the hyperbolic vertex circulator; (failed) attempt to fix operator= 2019-01-09 20:41:06 +01:00
Iordan Iordanov 843ce26596 Fixed to hyperbolic vertex circulator (used for 'adjacent_vertices') 2019-01-08 17:24:50 +01:00
Iordan Iordanov c0f0d474a9 Bugfix for 'locate' function 2019-01-08 12:31:02 +01:00
Iordan Iordanov 21b841c9f4 Added new functions point(Vertex_handle) and point(Face_handle, int) 2018-12-30 17:47:29 +01:00
Iordan Iordanov e5eab9fe46 Resolved a few todo's 2018-12-30 17:21:15 +01:00
Iordan Iordanov 3e9ad7ea94 Added missing functions (todo list in documentation) 2018-12-27 20:54:52 +01:00
Mael Rouxel-Labbé 5084e6db5b Fixed Periodic/Weighted triangulation tags 2018-12-20 09:48:07 +01:00
Mael Rouxel-Labbé 42e151372e Fixed HT_2 includes 2018-12-19 19:36:37 +01:00
Mael Rouxel-Labbé 33908ab7a2 Code improvements in HT_2 
- Fixed missing consts
- Fixed warnings
- Rewrote the most common traits class (others to do)
- Various tiny improvements
- ...
 2018-12-19 16:08:27 +01:00
Mael Rouxel-Labbé 2b580e7a21 Cleaned HT_2 code 2018-12-19 13:13:17 +01:00
Iordan Iordanov c4f687ef6a Fixed access modified for class Hyperbolic_faces_iterator 2018-11-16 18:36:58 +01:00
Iordan Iordanov 6fa8ba5c25 removed class Mark_face and relative calls 2018-09-24 14:56:47 +02:00
Iordan Iordanov 7f231a3f96 changed geometryc types according to the renames in the Traits classes; removed 'is_infinite' functions (now using Base::is_infinite where appropriate) 2018-09-03 13:49:54 +02:00
Iordan Iordanov 1641e32ed0 renamed segment() and triangle() to hyperbolic_segment() and hyperbolic_triangle(); note that DT_2 still needs triangle() and segment(), so these members are left undocumented; changes to demo to account for renames 2018-08-23 22:55:50 +02:00
Iordan Iordanov 731d95aee8 renamed circulators and iterators from Finite_ and Hyperbolic_ to All_; changes to demo to account for renames 2018-08-23 22:55:50 +02:00
Iordan Iordanov 8fe498884f renamed function get_conflicts() to find_conflicts() 2018-08-23 22:55:50 +02:00
Iordan Iordanov 72676baf17 removed flags from face base, substituted with tds_data(),which is of type CGAL::Object; to discuss: Mark_face tester in triangulation class 2018-08-23 15:14:19 +02:00
Iordan Iordanov 14861cf93e small bigfix: comparison instead of assignment in function side_of_hyperbolic_triangle() 2018-08-18 13:51:08 +02:00
Iordan Iordanov 7715a2c605 renamed flag-setting functions in Face base class to 'set_flag' and 'set_char' to hide low-leven functionality; will be required in the concept 2018-08-11 13:30:49 +02:00
Iordan Iordanov 4da5b7b4de renamed 'incident_vertices' to 'adjacent_vertices'; added a new circulator to ensure that adjacent vertices are connected with hyperbolic edges 2018-08-11 12:58:36 +02:00
Iordan Iordanov 11d82968b2 added function to ensure that the face pointed to by a vertex is always hyperbolic 2018-08-09 10:52:55 +02:00
Iordan Iordanov e133fcea32 removed object Side_of_hyperbolic_triangle from traits; added object Side_of_oriented_hyperbolic_segment in traits; added function side_of_hyperbolic_triangle in triangulation class 2018-08-08 22:41:01 +02:00
Iordan Iordanov a4851a8ef9 renamed functions 'is_non_hyperbolic' to 'is_Delaunay_hyperbolic' (for consistency in affirmative queries) 2018-08-08 21:33:39 +02:00
Iordan Iordanov 8287d55a98 renamed predicate 'Is_hyperbolic' to 'Is_Delaunay_hyperbolic' 2018-08-08 21:26:18 +02:00
Iordan Iordanov 08c11a06aa bugfix (conflicting Locate_type decarations) 2018-06-11 18:02:14 +02:00
Iordan Iordanov 3ee5441819 added enum for Locate_type 2018-05-22 10:56:16 +02:00
Iordan Iordanov 967b369c0b changed inheritance from public to private for triangulation class; added Triangle_2 class in traits 2018-05-09 11:08:31 +02:00
Iordan Iordanov 1720dd20c2 correction to locate; correction to typedef name for return type of Side_of_hyperbolic_triangle 2018-03-20 15:09:25 +01:00
Iordan Iordanov 4c7ba72443 added locate() 2018-03-19 19:50:48 +01:00