albert-github
ef8f294288
Documentation correction
...
Added missing end double quotes as noted in (a.o.) overnight documentation build: https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.2-I-22/index.html
2025-10-20 18:58:27 +02:00
Laurent Rineau
c657cb7dd3
try to workaround MSVC 2017 compilation error
...
As the compilation error seems to be related to the conversion of cells iterators to
cells handles, use a range-for loop, so that the iteration variable is directly a cell
handle instead of an iterator. That might help MSVC 2017.
2025-05-22 10:24:35 +02:00
Sébastien Loriot
8c4a37ee43
another semantic update
2025-05-20 20:43:21 +02:00
Mael Rouxel-Labbé
18eb5b4640
Remove bad init
2025-04-17 10:59:19 +02:00
Andreas Fabri
ad64590d57
Periodic_c_mesh_3: Use kernel functor
2025-04-10 18:49:47 +01:00
Mael Rouxel-Labbé
be6109dc14
Fix predicate/construction inconsistencies in P3T3 canonicalization functions
...
There are two use cases:
- either we care about the shifted position (for example for P3M3 where
we will insert the shifted position)
- either we don't care about the shifted position, and we are ok with
point + shifting offset (for example in P3M3 predicates to determine
is_bad)
In the first case, we cannot determine the shift using predicates,
otherwise we could have an inconsitency in the final result:
the predicates say the point is in, but once constructed it is not.
So this commit distinguishes between both. When we care about the
actual shifted position, we construct the point. There might be
numerical errors if we are not using exact constructions, but it
does not really matter.
What should be done better:
- use compare_x/y/z_3 instead of <
- handle the case where the numerical errors are such that you
get a really silly point far from the truth. Maybe this should
all be done in EPECK. There is something like this in the
history of canonicalize_helper.h ....
2025-03-27 12:14:14 +01:00
Sébastien Loriot
6f65025259
use std tuple
2025-02-05 16:54:18 +01:00
Sébastien Loriot
107f3696dc
boost::tie -> std::tie
2025-01-24 14:20:00 +01:00
albert-github
dd02af92a2
issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
...
Spelling corrections, `en-GB` -> `en-US`
2024-10-05 11:28:29 +02:00
Laurent Rineau
67466144bb
Merge pull request #8139 from janetournois/Mesh_3-revert_encroachment_loop-jtournois
...
Mesh_3 - revert encroachment rule modification, and fix infinite refinement
2024-04-22 14:53:50 +02:00
Jane Tournois
a8debb0d2d
Revert "Fix sometimes creating holes in the C3T3"
...
This reverts commit 06d272169f .
There may be an inconsistency between exact and inexact computations,
in the facet encroachment rule
This code was leading to a local infinite refinement loop during cells refinement
2024-04-11 14:16:41 +02:00
Sébastien Loriot
25233e8f67
undo bad change
2023-11-07 09:15:18 +01:00
Sébastien Loriot
8700394122
boost::mpl::if_ -> std::conditional
2023-09-24 22:57:20 +02:00
Sébastien Loriot
eada3ee8ca
Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl'
2023-08-14 14:19:25 +02:00
Laurent Rineau
a746283359
Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
...
Fix initialisation issues in Mesh_3
2023-07-26 17:34:33 +02:00
Laurent Rineau
820b1c5609
Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
...
Fix initialisation issues in Mesh_3
2023-07-26 17:30:40 +02:00
Mael Rouxel-Labbé
80834a640e
Mirror 6f65ecf246 for P3M3
2023-07-12 10:08:36 +02:00
Sébastien Loriot
b66afab814
Merge remote-tracking branch 'sloriot/CGAL-using_c++17_stl' into HEAD
2023-07-05 11:29:35 +02:00
Sébastien Loriot
f936680600
Merge remote-tracking branch 'cgal/master' into HEAD
2023-06-15 18:48:39 +02:00
Sébastien Loriot
9cdfe70abb
Merge remote-tracking branch 'sloriot/CGAL-toward_6.0'
2023-06-15 11:34:09 +02:00
Sébastien Loriot
56499e017d
do not use API that did not go into the standard
2023-06-15 10:57:10 +02:00
Sébastien Loriot
9a0bdb5d96
boost::variant ---> std::variant
2023-06-15 10:57:10 +02:00
Sébastien Loriot
604dcdc435
boost::optional => std::optional
2023-06-15 10:57:09 +02:00
Mael Rouxel-Labbé
ed354b4669
Silence a (wrong) warning in assertion code
2023-05-03 12:24:09 +02:00
Mael Rouxel-Labbé
4b92e10322
Add missing header include
2023-04-24 13:25:06 +02:00
Sébastien Loriot
99619dc634
boost::prior -> std::prev
2023-04-23 22:37:07 +02:00
Mael Rouxel-Labbé
58cc66188e
Fix point() for P3T3/P3DT3/P3RT3/P3M3
2023-03-23 23:47:58 +01:00
Mael Rouxel-Labbé
f5fd746503
Fix stack-use-after-scope error
2023-03-23 17:30:54 +01:00
Mael Rouxel-Labbé
cd0c81a98a
Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF
2023-03-20 10:14:27 +01:00
Sébastien Loriot
759d820ede
add missing const
2023-02-20 15:10:31 +01:00
Mael Rouxel-Labbé
69662f0e47
Try to please MSVC
2023-01-31 11:22:38 +01:00
Mael Rouxel-Labbé
f29872c15d
Fix warnings
2023-01-30 17:06:13 +01:00
Mael
8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF
2023-01-27 21:48:32 +01:00
Mael Rouxel-Labbé
041df2f7e8
Hide debug messages behind macros
2023-01-23 12:04:18 +01:00
Mael Rouxel-Labbé
b12f8e69e1
Fix not initializing vertex realizing the min
2022-12-06 15:43:21 +01:00
Mael Rouxel-Labbé
78a1fc1d14
Check that generic dummies create a proper cover
2022-12-06 15:13:22 +01:00
Mael Rouxel-Labbé
28f672a5b4
Further robustification improvements to P3_mesh_triangulation_3:
...
avoid canonicalization (i.e. construction) when possible
2022-12-06 14:48:59 +01:00
Mael Rouxel-Labbé
9b396fb0df
Improve error message when attempting to use parallel periodic meshing
2022-12-06 14:47:08 +01:00
Mael Rouxel-Labbé
06d272169f
Fix sometimes creating holes in the C3T3
...
Example here: https://stackoverflow.com/questions/74403892/missing-elements-in-periodic-c3t3-mesh
See details in the comments (diff)
2022-12-06 11:37:41 +01:00
Mael Rouxel-Labbé
7910d82c6c
Misc minor changes
2022-12-01 12:34:50 +01:00
Mael Rouxel-Labbé
7b72dc9c22
Better bound for dummy projection
2022-11-29 12:36:00 +01:00
Mael Rouxel-Labbé
cdc3bd22cf
Fix project_on_surface's projection direction
...
See also https://github.com/CGAL/cgal/pull/5209
2022-11-29 12:31:44 +01:00
Mael Rouxel-Labbé
b10b84fb7f
Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF
2022-11-18 16:47:07 +01:00
Mael Rouxel-Labbé
0867cb888e
Apply projections of dummy points as long as there are dummy points in the C2T3
2022-11-18 16:17:46 +01:00
Mael Rouxel-Labbé
9abfc25c55
Add support for non-cubic dummy points in P3M3
2022-11-18 16:16:48 +01:00
Mael Rouxel-Labbé
5a93b1fb47
Remove obsolete P3M3 assertion enforcing cubic domains
2022-11-18 16:16:02 +01:00
Mael Rouxel-Labbé
6b6a1b8e3e
Always print twice facets in medit output of periodic meshes
...
Because of the boundary, we want facets to be consistent with their
position as part of a cell that might be sharing vertices in different
periodic instances of the canonical domain
2022-11-18 16:11:21 +01:00
Mael Rouxel-Labbé
1869294e50
Misc code improvements
2022-11-18 00:21:58 +01:00
Mael Rouxel-Labbé
c682f8dc20
Add some comments
2022-11-18 00:17:22 +01:00
albert-github
eed54a0ae5
spelling corrections
...
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00