Commit Graph

639 Commits

Author SHA1 Message Date
Laurent Rineau 5ccbe16a1e P3t3: add all_cell_handles() and all_cell_handles() 2025-05-21 17:44:37 +02:00
Laurent Rineau 0befb153de Periodic_3_triangulation_3 a few add ranges
to make it compatible with the changes in `File_Medit.h`
2025-05-21 10:46:29 +02:00
Mael Rouxel-Labbé 884b0e41a1 Fix comment 2025-03-27 12:20:42 +01:00
Mael Rouxel-Labbé be6109dc14 Fix predicate/construction inconsistencies in P3T3 canonicalization functions
There are two use cases:
- either we care about the shifted position (for example for P3M3 where
we will insert the shifted position)
- either we don't care about the shifted position, and we are ok with
point + shifting offset (for example in P3M3 predicates to determine
is_bad)

In the first case, we cannot determine the shift using predicates,
otherwise we could have an inconsitency in the final result:
the predicates say the point is in, but once constructed it is not.

So this commit distinguishes between both. When we care about the
actual shifted position, we construct the point. There might be
numerical errors if we are not using exact constructions, but it
does not really matter.

What should be done better:
- use compare_x/y/z_3 instead of <
- handle the case where the numerical errors are such that you
get a really silly point far from the truth. Maybe this should
all be done in EPECK. There is something like this in the
history of canonicalize_helper.h ....
2025-03-27 12:14:14 +01:00
Mael Rouxel-Labbé 3a1e3d83c8 Add missing filtered periodic predicates
How did things even work before...
2025-03-18 12:05:17 +01:00
Mael Rouxel-Labbé c5d51c4909 Fix compilation in periodic triangulations 2025-03-16 14:25:04 +01:00
Mael Rouxel-Labbé 13842b219f Fix periodic predicates relying on a result_type typedef 2025-03-16 13:26:31 +01:00
Sébastien Loriot 107f3696dc boost::tie -> std::tie 2025-01-24 14:20:00 +01:00
Andreas Fabri 24046e1974 Remove lines with = delete; 2024-12-03 11:01:35 +00:00
Andreas Fabri 81e1bf2a5a typedef Self 2024-12-03 10:00:57 +00:00
Andreas Fabri 4ae3982969 cleanup 2024-12-03 09:28:26 +00:00
Andreas Fabri ac6bebdb1a cleanup 2024-12-03 09:22:58 +00:00
Andreas Fabri 0261184dee WIP 2024-11-28 14:31:01 +00:00
albert-github dd02af92a2 issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
Spelling corrections, `en-GB` -> `en-US`
2024-10-05 11:28:29 +02:00
Andreas Fabri ff89ba08ad Deal with duplicate lines 2024-08-06 08:06:41 +01:00
albert-github 36c8b7589d Spelling corrections
Last batch (for now) of spelling corrections in doxygen and normal comments
2024-05-31 19:05:34 +02:00
Sébastien Loriot c99b69a0e7 add missing license headers 2024-01-04 13:50:15 +01:00
Sébastien Loriot e7c26349f2 move header in a package to GPL 2024-01-04 13:36:34 +01:00
Sébastien Loriot 241e1bf557 add missing license include directives 2024-01-04 11:53:18 +01:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 074d63119a Merge pull request #7586 from MaelRL/P23T23-Unique_iterators-GF
Add unique simplex iterators for periodic triangulations
2023-07-17 09:52:23 +02:00
Mael Rouxel-Labbé f41e69a5fe Misc fixes 2023-07-07 02:09:35 +02:00
Mael Rouxel-Labbé 5759ce49ae Add unique simplex iterators 2023-07-07 02:04:01 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Mael Rouxel-Labbé 5656a7d11c Rework P3M3 snapping
Can't guarantee that the double construction is correct, even by going
through an intermediate exact offset computation; so if there's an issue,
just snap the intermediate point to the domain (it should have been close
enough in the first place)

Remove all functions related to zealous snapping that are just to get
"nice" coordinates (and not 1e-17).
2023-05-26 11:18:52 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Mael Rouxel-Labbé d8f4bc059d Fix conversion warnings 2023-05-03 12:24:23 +02:00
Mael Rouxel-Labbé d0f63f52c7 Fix wrong argument type in P3T3 offset's operator[] 2023-05-02 14:14:27 +02:00
Sébastien Loriot a88af6c0c6 boost::array -> std::array 2023-04-23 22:37:07 +02:00
Mael Rouxel-Labbé c593b76a38 Fix conversion warnings 2023-04-19 12:49:35 +02:00
Jane Tournois 170f54f0c0 avoid conversion warnings 2023-04-13 17:18:35 +02:00
Mael Rouxel-Labbé 58cc66188e Fix point() for P3T3/P3DT3/P3RT3/P3M3 2023-03-23 23:47:58 +01:00
Mael Rouxel-Labbé 4f6846776a Fix conversion warning 2023-03-17 14:43:26 +01:00
Mael Rouxel-Labbé 9d9a51731a Fix typo 2023-02-09 23:27:01 +01:00
Mael Rouxel-Labbé a8d38e84af Fix warnings 2023-01-31 11:22:54 +01:00
Mael Rouxel-Labbé d9b6eb856b Further robustify periodic circumcenter computations 2023-01-30 17:14:33 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Mael Rouxel-Labbé fca313bba9 Fix compilation with homogeneous exact number types 2023-01-23 11:30:49 +01:00
Mael Rouxel-Labbé efa486ca1c Remove useless typedef 2023-01-23 11:30:14 +01:00
Mael Rouxel-Labbé 3f4ebb1e0e Remove unused variables 2023-01-02 13:54:14 +01:00
Mael Rouxel-Labbé 2cdb9086dc Further robustify robust_canonicalize_point(): remove many constructions 2022-12-06 15:08:58 +01:00
Mael Rouxel-Labbé 6ab2a2f72c Add a macro to use a sparser dummy grid (can't be used with domain w/ features) 2022-12-06 14:50:17 +01:00
Mael Rouxel-Labbé c475f7de45 Add a comment to clarify that cells are destroyed when P3T3::remove rejects 2022-12-06 14:49:47 +01:00
Mael Rouxel-Labbé 28f672a5b4 Further robustification improvements to P3_mesh_triangulation_3:
avoid canonicalization (i.e. construction) when possible
2022-12-06 14:48:59 +01:00
Mael Rouxel-Labbé 7910d82c6c Misc minor changes 2022-12-01 12:34:50 +01:00
Mael Rouxel-Labbé c255b51b4b Generalize orthosphere radius threshold computation to non-cubic domains 2022-11-29 12:15:24 +01:00
Mael Rouxel-Labbé 0fdfec9ccb Same as 6021d5a9f1 for tr.point(Cell_handle, int) 2022-11-25 14:16:48 +01:00
Mael Rouxel-Labbé 6021d5a9f1 Fix making P3T3 an abstract class 2022-11-24 12:59:17 +01:00
Mael Rouxel-Labbé b10b84fb7f Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-11-18 16:47:07 +01:00
Mael Rouxel-Labbé 9699035179 Add a dummy point generator that can handle non-cubic domains 2022-11-18 16:13:13 +01:00