0fc710e95d
Fix bad 'if' condition & warning ( #9126 )
...
## Summary of Changes
```
Building CXX object test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Stream_support && /bin/clang++ -DCGAL_DATA_DIR=\"/mnt/testsuite/data\" -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/include -I/mnt/testsuite/include -isystem /usr/local/boost/include -Wall -O3 -std=c++20 -DCGAL_NDEBUG -MD -MT test/Stream_support/CMakeFiles/issue8155.dir/issue8155.cpp.o -MF CMakeFiles/issue8155.dir/issue8155.cpp.o.d -o CMakeFiles/issue8155.dir/issue8155.cpp.o -c /mnt/testsuite/test/Stream_support/issue8155.cpp
/mnt/testsuite/test/Stream_support/issue8155.cpp:27:17: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
27 | if (len > 0 || len != 1.0) {
| ~~~~~~~~^~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Stream_support/TestReport_cgaltest_ArchLinux-clang-CXX20-Release.gz
## Release Management
* Affected package(s): `Stream_support`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:43:26 +01:00
dee5ed8cc2
Fix edge collapse with incident non-triangular faces ( #9117 )
...
Make collapse able to handle non-triangular faces. The fix is easy as
you simply don't need to join faces in case the face won't disappear
after collapse
**TODO:**
update doc and constrained version
2025-11-19 14:42:28 +01:00
737bcb264e
Doc: fixing thirdparty links ( #9134 )
...
## Summary of Changes
fixed Metis/Eigen3/Qt6 links in Thirdparty
removed LEDA from doc as it is outdated
## Release Management
* Affected package(s): Documentation
2025-11-19 14:41:58 +01:00
2f9854b422
Fix warning about discarding return type of function with [[nodiscard]] ( #9127 )
...
## Summary of Changes
```
Building CXX object test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o
cd /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo && /bin/clang++ -DCGAL_TEST_SUITE=1 -DCGAL_USE_GMPXX=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_KEYWORDS -DQT_OPENGLWIDGETS_LIB -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo -I/mnt/testsuite/test/Generator_Demo -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/include -I/mnt/testsuite/include -I/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/AABB_tree_Demo -isystem /home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang/test/Generator_Demo/Generator_2_autogen/include -isystem /usr/include/qt6/QtCore -isystem /usr/include/qt6 -isystem /usr/lib/qt6/mkspecs/linux-g++ -isystem /usr/include/qt6/QtOpenGLWidgets -isystem /usr/include/qt6/QtOpenGL -isystem /usr/include/qt6/QtGui -isystem /usr/include/qt6/QtWidgets -Wall -fno-direct-access-external-data -MD -MT test/Generator_Demo/CMakeFiles/Generator_2.dir/Generator_2.cpp.o -MF CMakeFiles/Generator_2.dir/Generator_2.cpp.o.d -o CMakeFiles/Generator_2.dir/Generator_2.cpp.o -c /mnt/testsuite/test/Generator_Demo/Generator_2.cpp
In file included from /mnt/testsuite/test/Generator_Demo/Generator_2.cpp:27:
In file included from /mnt/testsuite/include/CGAL/Qt/DemosMainWindow.h:130:
/mnt/testsuite/include/CGAL/Qt/DemosMainWindow_impl.h:224:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
224 | about_CGAL.open(QIODevice::ReadOnly);
| ^~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-36/Generator_Demo/TestReport_gimeno_ArchLinux-clang.gz
## Release Management
* Affected package(s): `GraphicsView`
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-19 14:41:07 +01:00
e12a760f03
fixed Metis/Eigen3/Qt6 links in Thirdparty
...
removed LEDA from doc as it is outdated
2025-11-13 16:32:40 +01:00
eb992b38ca
Fix missing I/O function links
2025-11-13 15:20:23 +01:00
3ccdc134fe
Slightly simplified the code of Approximate_2::operator()(xcv...)
2025-11-13 15:10:17 +02:00
1602be1348
precompiled demos for CGAL-6.1
2025-11-13 13:29:35 +01:00
ba17e0bdde
cleanup an example
2025-11-13 11:05:26 +00:00
12445cc6e1
revert unintended modification
2025-11-13 11:52:21 +01:00
e7205b985d
Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main'
2025-11-13 10:42:42 +01:00
12a0f67674
Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch'
2025-11-13 10:41:53 +01:00
5812c1d6b5
Changed Cartesian to Simple_cartesian. Used size_t for Multiplicity. Properly indented and cleaned up.
2025-11-13 11:10:49 +02:00
07347da411
Fix Ceres deprecation warning ( #9121 )
...
## Summary of Changes
Changing the used cmake target for Ceres to Ceres::ceres.
## Release Management
* Affected package(s): Installation, Polygon_mesh_processing
2025-11-13 10:02:36 +01:00
1dc39039e9
merge cgal/main
2025-11-13 08:48:43 +00:00
1673cd0f9e
Fix OBJ loader crashing the demo on reading failure ( #9128 )
...
## Release Management
* Affected package(s): `Lab`
* Issue(s) solved (if any): a few entries in #6690
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2025-11-13 09:40:07 +01:00
dfc5fb5065
IO: write_PLY() for Epeck ( #7874 )
...
## Summary of Changes
As reported in #7868 the function `CGAL::IO::write_PLY()` used in binary
mode does not correctly write the coordinates if the points are from a
kernel with exact constructions.
~~This PR applies `to_double()" to the coordinates.~~
~~After a discussion with @MaelRL we decided that the user is in charge
to pass a `vertex_point_map` as named parameter that does the
conversion. This is straightforward as we offer the
[`Cartesian_converter_property_map`](https://doc.cgal.org/latest/Property_map/structCGAL_1_1Cartesian__converter__property__map.html ).~~
Moving back to the previous proposal: hardcode some to_double and
to_float casts such that we meet the requirements of the file format,
whatever the input.
As the problem is the same for the vertex normals we add a named
parameter `vertex_normal_map`.
### Todo
- [x] Fix the generic function `write_polygon_mesh()`. Currently it is
fixed for `Surface_mesh`
## Release Management
* Affected package(s): Stream_support
* Issue(s) solved (if any): fix #7868 and fix
https://github.com/CGAL/cgal/issues/7327
* License and copyright ownership: unchanged
* upcoming integration, update #9072 and test it
2025-11-13 09:38:55 +01:00
48262b8068
Removed unnecessary include
2025-11-13 10:28:01 +02:00
24d3cd4bec
Added missing inline
2025-11-13 09:33:58 +02:00
d226e504c4
fix a warning
...
use the correct implementation `popupAboutCGAL` from the base class
2025-11-12 16:48:59 +01:00
097fc2c5ab
fix memory leaks
2025-11-12 16:48:29 +01:00
c751ee6bc9
fix for AppleClang
2025-11-12 12:35:12 +01:00
066159f792
assertion should be before the removal...
2025-11-10 10:17:33 +01:00
333a15584f
Handle (invalid) zero vertex index in face
2025-11-07 22:02:20 +01:00
cd787c84d1
Use verbose OBJ reader in Lab
2025-11-07 22:02:08 +01:00
0ac856dd41
Fix OBJ loader crahsing the demo on reading failure
2025-11-07 21:00:12 +01:00
31734df2ef
Fix warning about discarding return type of function with [[nodiscard]]
2025-11-07 17:16:31 +01:00
3ef43324bb
Fix bad 'if' condition & warning
2025-11-07 17:05:21 +01:00
3c7d507530
update doc + apply changes to the constrained version
2025-11-06 19:40:48 +01:00
76552ccca1
class name
2025-11-06 18:16:43 +01:00
546d0b2871
verbs
2025-11-06 18:14:37 +01:00
af94906903
leftover from Eigen5 update
2025-11-06 10:08:56 +01:00
3b0d95e0e5
Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main'
2025-11-06 10:07:15 +01:00
ffda347171
adding support for Eigen3 5.0.0 (6.1 version)
...
moving the Eigen3 version check into CGAL_Eigen3_support.cmake
2025-11-06 10:06:29 +01:00
a9b369650a
Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch'
2025-11-06 10:04:46 +01:00
faae741666
Eigen3 5.0.0 support ( #9112 )
...
## Summary of Changes
Adding support for Eigen3 5.0.0 by updating CMakeLists.txt scripts.
## Release Management
* Issue(s) solved (if any): fix #9110
2025-11-06 10:03:20 +01:00
9e36c6744b
adding support for Eigen3 5.0.0
...
moving the Eigen3 version check into CGAL_Eigen3_support.cmake
2025-11-06 10:01:01 +01:00
828d57a419
Update Combinatorial_map/include/CGAL/Combinatorial_map.h
...
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-11-06 09:45:20 +01:00
6f2c3d819e
Merge branch 'main' into Small_feature/read_write_vtk_for_LCC
2025-11-06 09:38:10 +01:00
459fcf3c3f
adart -> d1
2025-11-05 20:46:02 +01:00
1c1245d5c0
update comments
2025-11-05 20:37:36 +01:00
d1c66eaa0f
formatting
2025-11-05 20:29:40 +01:00
c63a3d721e
Spelling correction ( #9120 )
...
Spelling correction
2025-11-05 11:12:08 +01:00
05bf3c4ffc
Changing cmake target for Ceres
2025-11-04 17:04:58 +01:00
3569406da1
master -> main remaining
2025-11-04 11:32:32 +01:00
d3d5d4575a
Spelling correction
...
Spelling correction
2025-11-04 11:15:57 +01:00
458e79bde8
master > main across scripts and documentation ( #9076 )
...
## Summary of Changes
TODO:
- [x] github wiki
([9d7282a](6ae93584f0...9d7282a43fhttps://github.com/CGAL/cgal-web/pull/75 )
- [ ] testsuite plateforms
- [ ] gf.com
## Release Management
* Affected package(s): Various
* Issue(s) solved (if any): n/a
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-11-03 18:52:56 +01:00
8a136c50c9
CGAL: An Halfedge ( #9119 )
...
## Summary of Changes
Replace several "an" by "a"
## Release Management
* Affected package(s): global
* License and copyright ownership: unchanged
2025-11-03 18:51:32 +01:00
7e1f685ea3
changes is for 6.2
2025-11-03 15:49:49 +01:00
f92b41ae0a
Merge remote-tracking branch 'cgal/main' into 'efifogel/Bso_2-do_intersect_efif'
2025-11-03 15:47:22 +01:00
Sebastien Loriot
Sven Oesau
Mael
Efi Fogel
Laurent Rineau
Andreas Fabri
Guillaume Damiand
Guillaume Damiand
albert-github