Commit Graph

1612 Commits

Author SHA1 Message Date
Giles Bathgate 254f1bf6b9 Add conditional noexcept to Handle/Handle_for 2021-04-28 21:03:03 +01:00
Giles Bathgate 0ef8127c71 The CGAL_NOEXCEPT macro is no longer needed 2021-04-28 21:03:00 +01:00
Giles Bathgate 0dcadee486 Fix dereference after null in Polyhedron_incremental_builder_3.h 2021-04-28 17:54:19 +01:00
Laurent Rineau 7ba37d8967 Merge pull request #5408 from sgiraudot/Arrangement-Compact_container_based_DCEL-GF
Arrangement:  Use Compact Container for DCEL
2021-04-28 15:24:21 +02:00
Sébastien Loriot 6672cd0014 use std::shared_ptr for CGAL::Object 2021-04-28 10:45:36 +02:00
Sebastien Loriot 5b253ad2fc
Merge pull request #4099 from sloriot/CGAL-epeck_pts_cmp
Speed up comparison of points
2021-04-21 15:24:11 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Sebastien Loriot 0c6404d1bc
Merge pull request #5596 from sloriot/Doc-precompiled_demos
Add doc for precompiled demos
2021-04-17 10:57:02 +02:00
Sebastien Loriot 076cb5fa13
Merge pull request #5573 from maxGimeno/Demo-Fixes-maxGimeno
Polyhedron Demo:  Trivial Warning
2021-04-17 10:53:46 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Sébastien Loriot 350b9172c5 replace %CGAL by \cgal (but in titles) 2021-04-11 14:52:01 +02:00
Sébastien Loriot 68dc09b3d9 optimize filter failures
cmp_epeck_points.cpp runtime goes from 23s. to 5s.

based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Maxime Gimeno 17602e589e Merge remote-tracking branch 'cgal/master' into CGAL-clang_tidy__nullptr_on_Mesh_2-GF 2021-04-07 09:17:51 +02:00
Laurent Rineau 1b54449dc5 Merge pull request #4878 from danston/Kernels-decltypes-danston
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Maxime Gimeno 8f7e12ebdc Fix another similar warning 2021-04-06 13:17:37 +02:00
Simon Giraudot 3cf1853832 Rebase 2021-03-25 10:03:35 +01:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Laurent Rineau d6e9bdd0c1 Merge pull request #5269 from GilesBathgate/move-assignment-operators
Move assignment operators
2021-03-24 15:05:39 +01:00
Simon Giraudot 3448035fc6 Fix CC_iterator by making constructor from pointer explicit 2021-03-24 08:25:29 +01:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Laurent Rineau b2ed4e5f7e Merge pull request #5423 from afabri/PMP-corefine_OM-GF
PMP:: Use operator<  instead of operator> as OM only implements the former

Conflicts:
	Polygon_mesh_processing/examples/Polygon_mesh_processing/corefinement_consecutive_bool_op.cpp
	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Corefinement/intersection_impl.h
2021-03-10 11:33:30 +01:00
Andreas Fabri fa44e3c543 Add missing const 2021-03-05 08:18:45 +00:00
Laurent Rineau 3ab3b10d47 Merge pull request #5247 from MaelRL/SDG-Fix_doc-GF
Doc improvements for TDS-related classes
2021-03-03 17:38:18 +01:00
Laurent Rineau 8c3f5ccb93 Merge pull request #5496 from afabri/BGL_fix_hash_openmesh_edge-GF
Provide specialization of hash for the edge_descriptor we provide for OpenMesh
2021-03-03 17:21:25 +01:00
Andreas Fabri 3a9ffc89cf Reorganize #ifdef as the edge_descriptor is not the one from OpenMesh 2021-02-26 16:33:13 +00:00
Efi Fogel fb1d6dea5a Merge remote-tracking branch 'cgal/master' into Boolean_operations-Use_GPS_based_polylines-GF 2021-02-24 12:54:13 +02:00
Mael Rouxel-Labbé 5efa544734 Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-02-22 17:19:40 +01:00
Marc Glisse 220d26da98 Merge remote-tracking branch 'cgal/master' into mt-glisse 2021-02-18 22:10:12 +01:00
Laurent Rineau 8fc88a9463 Merge pull request #5409 from lrineau/Triangulation_3-fix__move__semantic__of__Triangulation_hierarchy_3-GF
Fix the move-semantic of Triangulation_hierarchy_3
2021-02-18 15:19:11 +01:00
Maxime Gimeno d5811d0a41 clang-tidy on tests 2021-02-18 15:15:12 +01:00
Marc Glisse 52b07799b4 Bug fixing 2021-02-17 00:25:16 +01:00
Marc Glisse 612037fb12 Missed one occurence in a search&replace 2021-02-16 21:16:59 +01:00
Laurent Rineau 160118e7e9 Fix a warning from MSVC 2015
include\CGAL/array.h(67): warning C4814:
     'CGAL::Construct_array::operator ()': in C++14 'constexpr' will
     not imply 'const'; consider explicitly specifying 'const'

It cannot harm.
2021-02-11 14:36:26 +01:00
Dmitry Anisimov 81d9556707 Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston 2021-02-10 10:06:45 +01:00
Dmitry Anisimov af3f6dd07f fixed warnings with Intersect_3 and result_of 2021-02-09 17:30:06 +01:00
Laurent Rineau 519870c4cb Add support for MSVC 2015
MSVC 2015 has a partial support for C++14, and in particular for C++14
`constexpr` functions. Since Boost-1.57 (that is the minimal
requirement for CGAL since version 5.0), `<boost/config.hpp>` has a
macro `BOOST_CXX14_CONSTEXPR` that can be either `constexpr` for
fully-C++14 compilers, or empty for non-compliant compilers.
2021-02-09 15:38:08 +01:00
Laurent Rineau a735e849c0 Merge pull request #5152 from sloriot/CGAL-remove_bind
Replace usages of boost::bind
2021-02-05 16:14:04 +01:00
Laurent Rineau 9799879eef Modernize a bit <CGAL/array.h> assuming C++14 2021-02-03 21:51:00 +01:00
Laurent Rineau 8dbf50a94b Create CGAL::make_filled_array
That function template will replace my adhoc
`create_array_of_triangulation`.
2021-02-03 21:50:10 +01:00
Sébastien Loriot 5da7e84bab decltype(auto) -> auto 2021-02-02 10:58:31 +01:00
Sébastien Loriot e49fd1e732 deref it once 2021-01-29 18:04:19 +01:00
Andreas Fabri 2ac1b9632b Fix composition testsuite 2021-01-29 12:35:52 +00:00
Andreas Fabri 0cb34126af Remove typedefs 2021-01-29 12:35:16 +00:00
Andreas Fabri 55e23ae840 Remove types from Binary_compose_2 (which is not documented 2021-01-29 10:37:41 +00:00
Simon Giraudot 80e99153dc Use Compact Container in DCEL base instead of in place list 2021-01-28 10:30:55 +01:00
Mael Rouxel-Labbé 1f45360d7a Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-01-26 09:05:24 +01:00
Laurent Rineau ca9febf3b8 Merge pull request #5063 from maxGimeno/CMake-modernization-maxGimeno
CMake modernization

# Conflicts:
#	CGAL_ipelets/demo/CGAL_ipelets/CMakeLists.txt
2021-01-22 15:25:54 +01:00
Maxime Gimeno 9ac0a1de04 Merge remote-tracking branch 'cgal/master' into CMake-modernization-maxGimeno 2021-01-18 11:52:30 +01:00
Giles Bathgate 2ceedcfe81 Fix segmentation fault in destructor of Handle_for_virtual.h 2021-01-14 14:56:04 +00:00
Maxime Gimeno 2255f8e8ea Merge remote-tracking branch 'cgal/master' into CMake-modernization-maxGimeno 2021-01-13 14:34:09 +01:00
Marc Glisse 9f0f7eb033 is_currently_single_threaded 2021-01-11 19:40:13 +01:00
Marc Glisse a513a4802a comment about __libc_single_threaded 2021-01-10 23:50:41 +01:00
Maxime Gimeno 3d1c41fd14 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2021-01-07 15:05:28 +01:00
Laurent Rineau 85325d789f Merge pull request #5090 from afabri/FastEnvelope-GF
Polygon Mesh Processing:  Add envelope test
2021-01-06 16:11:56 +01:00
Laurent Rineau bbf4a54a9f Merge pull request #5104 from gdamiand/CMap-other_containers-gdamiand
Allow to use compact container or concurrent compact container for CMap, GMap and LCC
2021-01-06 16:11:54 +01:00
Laurent Rineau 78ca6bb109 Merge pull request #5292 from maxGimeno/CTest-Fix_examples_and_tests_for_ctest-maxGImeno
CTest: Fix some examples and tests
2021-01-06 16:11:25 +01:00
Sébastien Loriot ea0386c333 replace last bind 2021-01-06 12:59:12 +01:00
Sébastien Loriot 41ceed5347 match requirements of CGAL adaptors 2021-01-06 12:59:12 +01:00
Sébastien Loriot cef46c9ee6 replace bind in STL_extension 2021-01-06 12:59:12 +01:00
Maxime Gimeno dc291b8c0d Fix tests and examples for ctest. 2020-12-17 14:27:54 +01:00
Laurent Rineau 2264a204ed Merge pull request #5261 from lrineau/fix-Wnon-c-typedef-for-linkage
Fix warnings [-Wnon-c-typedef-for-linkage] In Ridges and Jet_fitting
2020-12-16 17:49:14 +01:00
Laurent Rineau a98d5ec638 Merge pull request #5261 from lrineau/fix-Wnon-c-typedef-for-linkage
Fix warnings [-Wnon-c-typedef-for-linkage] In Ridges and Jet_fitting
2020-12-16 17:47:53 +01:00
Giles Bathgate 9aea175746 Add a move constructor to Handle.h 2020-12-13 13:52:52 +00:00
Giles Bathgate d29baab363 Add a move assignment operator to Handle.h 2020-12-13 13:50:19 +00:00
Maxime Gimeno c7c5ae9150 add missing define 2020-12-11 13:56:35 +01:00
Laurent Rineau 71d489d3cb Fix also a TBB deprecation warning 2020-12-10 15:30:27 +01:00
Mael Rouxel-Labbé 6b87fe393d Fix various grammar issues 2020-12-05 11:11:33 +01:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Giles Bathgate e7aebc424e Fix uncaught exception in In_place_list.h 2020-11-29 14:42:55 +00:00
Giles Bathgate 48831abece Fix uncaught exception in Handle_for.h 2020-11-29 14:42:55 +00:00
Giles Bathgate 78bbe15325 Add a destructor assertion catch macro 2020-11-28 14:17:59 +00:00
Maxime Gimeno 3b70343590 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-11-16 16:19:43 +01:00
Marc Glisse 6338f89ae4 conditional code for TSAN 2020-11-13 19:39:24 +01:00
Marc Glisse bf0a42d740 lock-like protection for update_exact
The exact choice of memory_order_* is hard, and even for versions that
seem to work on x86_64 TSAN complains like crazy.

TODO: a version that, instead of blocking if another thread is updating,
also does the computation, with suitable protection to ensure that
pruning the tree cannot happen while anyone is computing on it.

TODO: try having AT in Lazy instead of Lazy_rep (i.e. not shared) to
avoid the indirection. We can possibly choose one or the other depending
on the type.
2020-11-13 19:39:24 +01:00
Marc Glisse 0bd0e7e47d atomic count in Handle 2020-11-13 19:39:24 +01:00
Marc Glisse 29c9fd3f02 Refactor ++ and -- in Handle 2020-11-13 19:39:24 +01:00
Marc Glisse 3edf7a836d atomic count in Handle_for 2020-11-13 19:39:24 +01:00
Marc Glisse 695fe37394 Constructor for Rep 2020-11-13 19:39:24 +01:00
Marc Glisse 511103e14c Use a constructor for RefCounted 2020-11-13 19:39:24 +01:00
Andreas Fabri f246c4abf8 merge 2020-11-13 16:26:57 +00:00
Maxime Gimeno 8e23d5c482 Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-11-10 09:00:41 +01:00
Laurent Rineau d0dd5a93bf Merge pull request #4639 from janetournois/Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
Small feature - Triangulation Segment Cell/Simplex Iterator
2020-11-10 08:45:38 +01:00
Maxime Gimeno cc00d293df Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-11-06 09:37:18 +01:00
Laurent Rineau 21c48c50dd Merge pull request #4899 from sgiraudot/STL_Extension-Multiset_with_CC_allocation-GF
Surface Sweep: Enhance memory allocation with Compact Container
2020-11-04 20:46:18 +01:00
Maxime Gimeno 1c00bf6847 Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-29 15:09:16 +01:00
Guillaume Damiand 086a09991f Add index method in concurrent compact container (to have same API for CC and CCC) 2020-10-22 10:29:57 +02:00
Simon Giraudot 6b991a95ad Update code with changes in Compact container 2020-10-22 09:45:31 +02:00
Simon Giraudot 739a8b66e8 Use named constructor to resolve ambiguity 2020-10-22 08:59:49 +02:00
Simon Giraudot 9d21b57013 Test multiset with CC allocation 2020-10-22 08:59:48 +02:00
Simon Giraudot 781f367580 Add option to use CC for allocation in multiset 2020-10-22 08:59:48 +02:00
Simon Giraudot b31b6ba980 Construct iterator from pointer 2020-10-22 08:59:47 +02:00
Simon Giraudot 2c490b7ec7 Merge remote-tracking branch 'mine/Surface_sweep_2-Small_unordered_set-GF' into Surface_sweep_2-Small_unordered_set-GF 2020-10-20 15:17:24 +02:00
Simon Giraudot 3e17be2b30 Merge branch 'Arrangement-Fix_polycurve_intersection-efif-GF' into Boolean_operations-Use_GPS_based_polylines-GF 2020-10-20 10:34:46 +02:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Sébastien Loriot 87b8f66e14 update from master 2020-10-20 09:19:13 +02:00
Andreas Fabri b101674749 Make the intersection point static; Move the normal construction higher up 2020-10-20 09:17:15 +02:00
Jane Tournois 2bf4da4edc Merge branch 'master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-10-19 16:27:04 +02:00
Maxime Gimeno 107c4350d0 remove all /src directories 2020-10-14 11:22:49 +02:00
Mael Rouxel-Labbé f55ef7dd50 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-10-09 18:36:17 +02:00
Sebastien Loriot 7652091b9c
Merge pull request #4931 from sloriot/CGAL-cosmetic_cleanup
Cosmetic cleaning
2020-10-02 15:15:31 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Simon Giraudot ff845cc7ca Fix single 2020-08-25 13:48:48 +02:00
Simon Giraudot 2992fcc508 Add CGAL::Single to create range of one isolated element 2020-08-25 12:50:30 +02:00
Mael Rouxel-Labbé 8682f9bafb Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2020-08-24 11:45:17 +02:00
Sébastien Loriot e893ac1178 cosmetic changes 2020-08-18 10:06:51 +02:00
Simon Giraudot b51be554b9 Fixes from review 2020-08-12 12:50:10 +02:00
Simon Giraudot d6d189b4a1 Bugfix: only test existing values in the array 2020-08-05 10:07:02 +02:00
Simon Giraudot 9ea82441c2 Use unique_ptr and add copy/move semantics 2020-08-05 10:06:49 +02:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Simon Giraudot ca794fa991 Remove now useless Curve_pair, move and fix includes/classes accordingly 2020-08-03 14:01:18 +02:00
Simon Giraudot 58b06bfe5f Add Small_unordered_set file 2020-08-03 12:57:03 +02:00
Dmitry Anisimov 209513dc56 fixed docs + a few code improvements 2020-07-31 15:58:38 +02:00
Dmitry Anisimov 758ae808c0 better use of declval 2020-07-30 17:33:00 +02:00
Mael Rouxel-Labbé 5bd28b4aea Remove extra backticks on some \tparam 2020-07-29 10:24:47 +02:00
Mael Rouxel-Labbé 0d66e19361 IO documentation fixes
See @sloriot's review:

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Polgyon_soup_mesh_IO/2nd_round/Answer_to_review

(+ some commits before and after this one)
2020-07-24 17:06:00 +02:00
Dmitry Anisimov 2f7f37983b periodic 3 and generator fixes + the issue #3083 is addressed 2020-07-24 11:26:28 +02:00
Dmitry Anisimov 847e2277d6 result_of types to decltype(declval), both issues #3035 and #3846 are addressed 2020-07-23 18:46:46 +02:00
Dmitry Anisimov 4248a8a9f7 lazy and type mapper result_of fix 2020-07-23 16:00:06 +02:00
Mael Rouxel-Labbé 83b9408529 Fix compilation of [[deprecated]] inline 2020-07-13 16:57:08 +02:00
Jane Tournois 9e8d12d9cf Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF
# Conflicts:
#	Installation/CHANGES.md
2020-07-06 06:57:32 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Laurent Rineau bcf8409e46 Merge pull request #4611 from rathod-sahaab/replace-throws-with-noexcept
replaced throw() with noexcept
2020-06-23 18:50:20 +02:00
Laurent Rineau e0b2bc6235 Merge pull request #4798 from maxGimeno/STL_Extension-Fix_compact_container-GF
Fix unknown behavior that changed in Visual 2019
2020-06-23 18:49:49 +02:00
Mael Rouxel-Labbé ad803b82b5 Enhance is_convertible.h with boost::mpl rather than handmade enum { value = } 2020-06-21 12:09:08 +02:00
Mael Rouxel-Labbé 2d49f7d702 Countless IO fixes...
Don't have the patience to split it nicely
2020-06-21 12:03:28 +02:00
Maxime Gimeno 83fed40f0b Fix unknown behavior that changed in Visual 2019 2020-06-19 14:45:32 +02:00
Abhay Raj Singh 3302086812
Removed Unnecessary Destructor 2020-06-13 23:41:39 +05:30
Abhay Raj Singh 04305dc82c
Removed unecessary Destructor 2020-06-13 23:39:35 +05:30
Laurent Rineau 9b8ecd720b Merge pull request #4636 from sgiraudot/CMake-Third_party_imported_targets-GF
CMake: Use Imported Targets for 3rd Party Libs
2020-06-05 17:54:14 +02:00
Laurent Rineau 871c97273a Merge pull request #4496 from lrineau/CGAL-move_semantic_for_triangulations-GF
Add move-semantic to Compact_container and Triangulations
2020-06-03 16:23:22 +02:00
Simon Giraudot 89285f1feb Merge remote-tracking branch 'mine/CMake-Third_party_imported_targets-GF' into CMake-Third_party_imported_targets-GF 2020-05-28 08:53:17 +02:00
Laurent Rineau 7173530dad Merge pull request #4557 from lrineau/NewKernel_d-det-GF-CGAL-5.0
NewKernel_d: Accelerate by using Mpzf instead of Gmpq (CGAL-5.0 and later)
2020-05-27 18:27:56 +02:00
Laurent Rineau 88250aee80 Merge pull request #4557 from lrineau/NewKernel_d-det-GF-CGAL-5.0
NewKernel_d: Accelerate by using Mpzf instead of Gmpq (CGAL-5.0 and later)
2020-05-27 18:20:14 +02:00
Laurent Rineau 14c3b7ec72 Merge pull request #4640 from mglisse/spaceship
C++20 fixes
2020-05-27 16:33:33 +02:00
Laurent Rineau 14b18f81ee Merge pull request #4735 from lrineau/Triangulation_2-fix_CDT_2_degenerate_case-GF
Fix a bug in <CGAL/Constrained_triangulation_2.h>
2020-05-27 16:33:21 +02:00
Laurent Rineau a8fca35b1d Merge pull request #4735 from lrineau/Triangulation_2-fix_CDT_2_degenerate_case-GF
Fix a bug in <CGAL/Constrained_triangulation_2.h>
2020-05-27 16:32:49 +02:00
Laurent Rineau 0ea385712f Fix compatibility with C++03 2020-05-22 14:52:18 +02:00
Marc Glisse f3d5a573df Use allocator_traits for destroy 2020-05-21 11:52:21 +02:00
Laurent Rineau 8b474ddf59 Re-add the use of Lazy objects in Compact_container 2020-05-20 10:32:03 +02:00
Laurent Rineau 319383c963 Revert "Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand"
This reverts commit bcab082f82, reversing
changes made to 2d3e126450.
2020-05-20 09:47:58 +02:00
Laurent Rineau dcc4fb1cc1 Merge remote-tracking branch 'cgal/master' into CGAL-move_semantic_for_triangulations-GF
# Conflicts:
#	STL_Extension/include/CGAL/Compact_container.h
2020-05-20 09:46:26 +02:00
Laurent Rineau bb012da683 Merge pull request #4568 from sgiraudot/PSP-Cluster_points-GF
[Small Feature] Point Set Clustering
2020-05-18 12:24:56 +02:00
Laurent Rineau fcc5ccca53 Merge pull request #4669 from gdamiand/CGAL_warning-gdamiand
Remove "unused-but-set-parameter" warnings
2020-05-18 12:24:44 +02:00
Simon Giraudot fefdd13f45 Merge remote-tracking branch 'mine/PSP-Cluster_points-GF' into PSP-Cluster_points-GF 2020-05-06 08:59:40 +02:00
Laurent Rineau dc12dea776 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-05-04 17:52:26 +02:00
Laurent Rineau c211224a29 Cherry-pick pull requests #4682 and #4683
Prevent dynamic binding of references to null pointers
2020-05-04 17:50:20 +02:00
Sebastien Loriot dab49b938e
Merge pull request #4682 from mhsaar/patch-3
Prevent dynamically bind references to null pointer.
2020-04-29 14:03:47 +02:00
Sebastien Loriot bcab082f82
Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand
Enable the use of Lazy objects in Compact_container
2020-04-29 13:56:59 +02:00
Michael Hemmer 704cdab314
Prevent dynamically bind references to null pointer.
This is a manually-generated change. Ensure that behavior and style are
preserved by carefully inspecting the diff.
2020-04-26 07:43:22 +02:00
Simon Giraudot c1d8fb69b7 Move transform ranges in property_maps 2020-04-22 13:47:33 +02:00
Sébastien Loriot c5af2b25f3 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-04-22 13:27:29 +02:00
Sébastien Loriot 157bdbda08 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-04-22 13:26:52 +02:00
Guillaume Damiand 74d89220e2 Remove warnings 2020-04-20 15:25:40 +02:00
Simon Giraudot 1dd6a665a1 Merge remote-tracking branch 'mine/CMake-Third_party_imported_targets-GF' into CMake-Third_party_imported_targets-GF 2020-04-20 09:09:32 +02:00
Jane Tournois 9a722c4ef1
Merge branch 'master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF 2020-04-20 06:40:24 +02:00
Mael bbd24f2946
Fix missing include 2020-04-16 19:46:09 +02:00
Mael 4fb633a6be
Add missing include 2020-04-16 18:59:54 +02:00
Sebastien Loriot 98fafe4ef1
Merge pull request #4514 from MaelRL/CGAL-Fix_warnings-GF
Fix (some) testuite warnings
2020-04-16 18:15:11 +02:00
Simon Giraudot 60cb33fa31 Merge remote-tracking branch 'mine/PSP-Cluster_points-GF' into PSP-Cluster_points-GF 2020-04-16 17:02:19 +02:00
Simon Giraudot 421096fd7f Use imported targets everywhere 2020-04-15 14:06:13 +02:00
Sébastien Loriot d845d6ce8d Merge remote-tracking branch 'cgal/master' 2020-04-10 18:16:18 +02:00
Sébastien Loriot 2876ad9af1 remove trailing whitespaces 2020-04-10 18:15:32 +02:00
Mael Rouxel-Labbé c16c1a7ea3 Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF 2020-04-10 16:10:11 +02:00
Jeff Trull 8b21a67508 Forward declare class template Instead of including a new header 2020-04-07 14:50:17 -07:00
Jeff Trull 905dabc3a2 Fix reference-to-null-pointer UB
Hash compact_container iterators directly from their underlying
pointers, rather than taking the address of their dereferenced objects
2020-04-07 14:47:58 -07:00
Mael Rouxel-Labbé 3ddf7e7287 Fix warning (ignoring return of nodiscard-marked functions)
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-115/STL_Extension/TestReport_afabri_x64_Cygwin-Windows10_MSVC2017-Debug-64bits.gz
2020-04-06 22:24:24 +02:00
rathod-sahaab dbbee667af replaced throw() with noexcept 2020-04-02 18:31:00 +05:30
Jane Tournois a1b292e805 Merge remote-tracking branch 'cgal/master' into Triangulation_segment_traverser_3-tvanlank__rewrote_history-GF 2020-04-01 13:52:57 +01:00
Andreas Fabri 6ae64e7a73 Make functor a template parameter in the internal function 2020-03-27 16:41:53 +01:00
Sébastien Loriot 822bc55640 extra run of the script to remove tabs and trailing whitespaces 2020-03-27 08:28:48 +01:00
Sébastien Loriot 5c5d445eb3 Update branch from master after trailing whitespaces and tabs removal 2020-03-27 08:27:43 +01:00
Sébastien Loriot 2e180ac589 extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:29:44 +01:00
Sébastien Loriot a0345b135c Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:29:05 +01:00
Sébastien Loriot 97e46accad extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:26:37 +01:00
Sébastien Loriot 34ce87be56 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:26:15 +01:00
Sébastien Loriot d1a323c730 extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:24:14 +01:00
Sébastien Loriot 86e25f7e71 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:23:54 +01:00
Sébastien Loriot 35b83deffd Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:16:25 +01:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 0a46621dc6 Merge branch 'cgal/releases/CGAL-4.14-branch'
whitespace+tab removal, merged with option -Xignore-all-space
2020-03-26 13:28:46 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Simon Giraudot 63c1090c04 Upate test_for_each 2020-03-23 13:42:45 +01:00
Mael Rouxel-Labbé 2556196dad Merge remote-tracking branch 'cgal/master' into CGAL-Optimal_bounding_box-GF 2020-03-23 08:59:49 +01:00
Simon Giraudot 320876ab23 Replace exception by return value to stop for_each loops 2020-03-23 08:29:08 +01:00
Sébastien Loriot 2a13c8cbec Update from master 2020-03-20 09:05:58 +01:00
Simon Giraudot c8aa0c8f57 Prevent from testing Parallel_tag if TBB is not here 2020-03-19 15:54:53 +01:00
Simon Giraudot 16625cda01 Fix for_each and add a comment on what it does 2020-03-19 10:38:58 +01:00
Simon Giraudot 61d331f456 Fix for_each 2020-03-18 09:11:41 +01:00
Simon Giraudot c4e62d70e8 Remove K parameter and update doc from reviews 2020-03-17 12:04:44 +01:00
Guillaume Damiand 650a7dcbc2
Merge branch 'master' into Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand 2020-03-16 16:24:54 +01:00
Mael Rouxel-Labbé 100304667d Remove CGAL::internal::boost_::function_property_map
This file was duplicated from BOOST 1.64 because it appeared in a boost
release that was younger than the oldest boost release supported by CGAL
when the file was first required.

The minimum boost version (1.57) now required by CGAL is younger
than the version in which the file appeared in boost (1.51)
and it can thus be removed.
2020-03-12 20:58:44 +01:00
Laurent Rineau 1eba82246e Rule of zero for CC_iterator
This commit is the one fixing the mis-compilation by MSVC 2015.
2020-03-09 17:35:52 +01:00
Laurent Rineau 378554e5a7 Change the API of `for_compact_container`/`Compact_container_traits`
Now, we have a proper pair of getter/setter, and the `void` pointer is
get by a `reinterpret_cast`, instead of a union.

Cc: @mglisse
2020-03-09 17:19:58 +01:00
Laurent Rineau fbf790637e Patch for MSVC and clang 2020-03-09 16:32:26 +01:00
Mael Rouxel-Labbé 0133e9f2f9 Merge branch 'PMP-soup_to_mesh_add_vpm-old' into PMP-soup_to_mesh_add_vpm 2020-03-06 11:41:31 +01:00
Laurent Rineau 0dfd416395 Use [[noreturn]] directly 2020-03-06 09:26:54 +01:00
Simon Giraudot b2db69f8f1 Fix license 2020-03-05 14:36:38 +01:00
Simon Giraudot b99402f953 Add convenient for_each to transparently use sequential/parallel/randomaccess/not 2020-03-02 12:23:10 +01:00
Laurent Rineau e3d7f7946d CC_iterator(CC_iterator&&) is now `= default`
That fixes a segmentation fault with Visual Studio in Skin Surface
Meshing.
2020-02-28 14:01:54 +01:00
Marc Glisse 3e4c0d28e5 More swaps. 2020-02-25 01:29:48 +01:00
Mael Rouxel-Labbé 752fc00bf4 Fix includes 2020-02-20 12:14:40 +01:00
Mael Rouxel-Labbé 3bbc07ebf5 Regroup some helpers to call reserve/resize on containers that do not offer it
Useful because sometimes models of the range concepts we demand
do not offer reserve or resize, yet we still want to call it
when it's available.
2020-02-20 11:16:54 +01:00
Laurent Rineau 0c40f7a458 "Fix" for dumb MSVC compilers
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.1-Ic-77/Triangulation_2/TestReport_afabri_x64_Cygwin-Windows10_MSVC2015-Debug-64bits.gz

My guess is that the compiler short-circuits `Const &&` when the
argument `Const` is `false`, and then the expression `Const &&
!OtherConst` is no-longer dependent on the argument `OtherConst`.

That "fix" just turn `Const &&  !OtherConst` to `!OtherConst && Const`.
2020-02-19 16:27:10 +01:00
Laurent Rineau 7508a6f93c Merge remote-tracking branch 'cgal/master' into CGAL-move_semantic_for_triangulations-GF 2020-02-12 17:05:49 +01:00
Laurent Rineau 0f0a0ed82d Try to enable the use of Lazy objects in Compact_container 2020-02-12 09:59:51 +01:00
Marc Glisse 6c65f5d929 Some noexcept, swap, etc to help Handle* types 2020-02-12 09:42:51 +01:00
Mael Rouxel-Labbé 84215c95c4 Merge branch 'Box_intersection_d-accelerate-GF-old' into Box_intersection_d-accelerate-GF 2020-02-07 11:03:07 +01:00
Laurent Rineau b311ab59ed [modernize-use-nullptr] (clang-tidy) 2020-01-31 12:11:16 +01:00
Laurent Rineau 2717864bd7 Fix warnings cppcoreguidelines-special-member-functions (clang-tidy)
- Remove trivial copy-constructors that prevents the compiler to
  generate the other special member functions.
2020-01-31 12:08:05 +01:00
Laurent Rineau db55548830 Fix a conversion warning 2020-01-31 12:01:43 +01:00
Laurent Rineau e82ea5de96 Add move-semantic to Compact_container
That required a refactoring the timestamper feature. And the
explanation why is quite long... Let's do it.

The CGAL triangulations use the `Rebind_TDS` feature. During the
instanciation of `Compact_container<T>` it is important that `T` is
allowed to be incomplete, otherwise the circular dependencies between
TDS and Vertex/Cell cannot be resolved by the compiler. In previous
implementation of the timestamper, to allow `T` to be an incomplete
type, the compact container only carried a *point* to the time
stamper, allocated on the heap. A moved-from compact container would
only be valid if one recreated a time stamper for it on the head in
the move-constructor. As I want move operations to be `noexcept`, I
needed to change that implementation. Now the triangulation always
carries a time stamp counter (`std::size`), independently of the type
`T`, and the time stamper is an empty class, with static methods. That
allows `T` to be incomplete during the declaration of
`Compact_container<T>`.
2020-01-31 11:29:55 +01:00
Laurent Rineau 315a0b54d1 Merge pull request #4468 from maxGimeno/TBB-Fix_deprecation_warnings-5_0-maxGimeno
TBB deprecated code replacement
2020-01-29 16:27:53 +01:00
Maxime Gimeno 35600534f0 fixes 2020-01-21 10:05:19 +01:00
Maxime Gimeno e3a20071a1 Fix call to compare_exchange_strong() in Spatial_lock_grid_3.h 2020-01-14 15:50:32 +01:00
Maxime Gimeno 85712ba28c WIP replacing tbb deprecated includes. 2020-01-14 15:03:20 +01:00
Sebastien Loriot 6367f5e9cb
Merge pull request #4401 from fritzm/set-error-handler-fix
Fix set_error_handler() header-only-mode issue (#4400)
2019-12-20 09:53:57 +01:00
Fritz Mueller 01f69b5e9d Fix set_error_handler() header-only-mode issue (#4400) 2019-12-20 09:53:22 +01:00
Sébastien Loriot 87d2d83703 Merge remote-tracking branch 'cgal/master' 2019-12-20 09:24:41 +01:00
Sebastien Loriot f4317d4d7f
Merge pull request #4372 from MaelRL/CGAL-clean_obsolete_doc-GF
Doc: Remove some obsolete links
2019-12-20 09:18:37 +01:00
Laurent Rineau 674627937c Merge pull request #4389 from lrineau/DT_3-issue4388-GF
Fix  DT3 parallel performance loss (issue #4388)
2019-12-17 09:16:52 +01:00
Laurent Rineau b826770302 Merge pull request #4397 from afabri/T3_accelerate_insert_in_hole
Triangulation_3: Accelerate point insertion
2019-12-17 09:16:35 +01:00
Laurent Rineau de1074426b Merge pull request #4389 from lrineau/DT_3-issue4388-GF
Fix  DT3 parallel performance loss (issue #4388)
2019-12-17 09:15:48 +01:00
Laurent Rineau 0460176a2b Fix another warning 2019-12-10 13:52:33 +01:00
Laurent Rineau c08c632fc8 Merge branch 'releases/CGAL-5.0-branch' into T3_accelerate_insert_in_hole-rebased 2019-12-10 13:02:24 +01:00
Andreas Fabri 29a4f441c9 Shift depends on sizeof(T) not on sizeof(T*) 2019-12-10 12:45:23 +01:00
Laurent Rineau 435bb4d4c4 Cleanup the patch 2019-12-10 10:59:13 +01:00
Mael 40f747bd45 Fix license 2019-12-10 10:20:14 +01:00
Andreas Fabri 35fa824216 Move hash 2019-12-10 10:20:14 +01:00
Andreas Fabri 2edab88f81 variable must be constexpr too 2019-12-10 10:20:14 +01:00
Andreas Fabri 02e3d25914 cleanup 2019-12-10 10:20:14 +01:00
Andreas Fabri 27a93fc25a First cleanup 2019-12-10 10:19:07 +01:00
Andreas Fabri febb607934 WIP: Hard coded appromimated hash function 2019-12-10 10:19:07 +01:00
Andreas Fabri 8aa4fc547f Fix counting collisions 2019-12-10 10:19:07 +01:00
Laurent Rineau a93dd81642 Cleanup 2019-12-10 10:17:08 +01:00
Andreas Fabri 3fd81fc4f2 Split freelist and occupied (todo: save memory) 2019-12-10 10:17:08 +01:00
Andreas Fabri 6462016ce3 Use an unordered map to find neighbor cells 2019-12-10 10:17:03 +01:00
Fritz Mueller 643c8f70d0 Fix set_error_handler() header-only-mode issue (#4400) 2019-12-08 01:25:41 -08:00
Laurent Rineau 04e007a3bf Merge pull request #4323 from MaelRL/STL-Simplify_hash_functor-GF
STL Extension:  Simplify 'Hash_handles_with_or_without_timestamps'
2019-12-05 11:05:20 +01:00
Laurent Rineau e9f1cb405f Improvement for set_size 2019-12-04 15:43:01 +01:00
Laurent Rineau 6cdd833e13 Merge branch 'DT_3-issue4388__for_CGAL-4.14.2-GF' into DT_3-issue4388-GF 2019-12-04 15:39:55 +01:00
Laurent Rineau 6ded244449 Merge branch 'DT_3-issue4388__for_CGAL-4.13.2-GF' into DT_3-issue4388__for_CGAL-4.14.2-GF 2019-12-04 15:32:07 +01:00
Laurent Rineau 3ade506eba Create approximate_size() in Concurrent_compact_container
Instead of having an atomic integer for the size of the compact
container, now all free lists have an atomic integer for their size,
but it is only updated when the size is increased by 10%.
2019-12-04 15:20:52 +01:00
Laurent Rineau 4208951252 revert "Access to the "current" size of the compact container"
Reverts commit 2836828d61
2019-12-04 15:16:25 +01:00
Mael Rouxel-Labbé 57fed1416a Factorize code creating throwing output iterators 2019-12-04 09:10:49 +01:00
Laurent Rineau 65cde3ce79
Merge branch 'master' into Faster_dd_spatial_searching-cjamin 2019-12-03 19:18:15 +01:00
Mael Rouxel-Labbé 9d2e92ac4c Document the new type 2019-12-03 14:09:48 +01:00
Mael Rouxel-Labbé 7ff2ffb238 Remove some obsolete doc links
Mostly a consequence of using stuff from 'std::' rather than 'CGAL::'
2019-11-20 13:16:40 +01:00
Mael Rouxel-Labbé ac86fadd7a Misc code formatting improvements 2019-11-19 12:51:17 +01:00